Bug 1482334 - fix add-on options menu by replacing .value with .getAttribute('value'). r+a=jorgk
authoraceman <acelists@atlas.sk>
Thu, 11 Oct 2018 23:36:25 +0200
changeset 31855 01d10b64821078746e600ea322d3f48b23f735f5
parent 31854 1615e21f1be9bf032b68401d62f2e43f6bf64972
child 31856 807198ad8091a0098ea846f62e408c6b7e867ae0
push id86
push usermozilla@jorgk.com
push dateSun, 14 Oct 2018 09:47:49 +0000
treeherdercomm-esr60@e524897f5bde [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1482334
Bug 1482334 - fix add-on options menu by replacing .value with .getAttribute('value'). r+a=jorgk
mail/base/content/mailWindowOverlay.xul
--- a/mail/base/content/mailWindowOverlay.xul
+++ b/mail/base/content/mailWindowOverlay.xul
@@ -1359,17 +1359,17 @@
         </splitmenu>
         <spacer class="appmenuPane-spacer"/>
         <splitmenu id="appmenu_addons"
                    class="menuitem-iconic"
                    label="&addons.label;"
                    oncommand="openAddonsMgr();">
           <menupopup id="appmenu_addonPrefs"
                      onpopupshowing="initAddonPrefsMenu(this);"
-                     oncommand="openAddonPrefs(event.target.value, event.target.getAttribute('optionsType'));">
+                     oncommand="openAddonPrefs(event.target.getAttribute('value'), event.target.getAttribute('optionsType'));">
             <menuitem label="&addons.label;" oncommand="openAddonsMgr(); event.stopPropagation();"/>
             <menuseparator class="appmenu-menuseparator"/>
             <menuitem label="&addonNoPrefs.label;" disabled="true"/>
           </menupopup>
         </splitmenu>
         <splitmenu id="appmenu_customize"
 #ifdef XP_WIN
                    label="&preferencesCmd2.label;"
@@ -3060,17 +3060,17 @@
               label="&addonPrefsUnix.label;"
               accesskey="&addonPrefsUnix.accesskey;">
 #else
               label="&addonPrefs.label;"
               accesskey="&addonPrefs.accesskey;">
 #endif
           <menupopup id="addonPrefs"
                      onpopupshowing="initAddonPrefsMenu(this);"
-                     oncommand="openAddonPrefs(event.target.value, event.target.getAttribute('optionsType'));">
+                     oncommand="openAddonPrefs(event.target.getAttribute('value'), event.target.getAttribute('optionsType'));">
             <menuitem label="&addonNoPrefs.label;" disabled="true"/>
           </menupopup>
         </menu>
         <menuitem id="activityManager" label="&activitymanager.label;"
                   accesskey="&activitymanager.accesskey;"
                   oncommand="openActivityMgr();"/>
         <menu id="imAccountsStatus" label="&imAccountsStatus.label;"
               accesskey="&imAccountsStatus.accesskey;"