Bug 1248158 - For the menulist dropmarker use a background image instead the dropmarker itself. r=mkmelin a=rkent THUNDERBIRD450b3_2016032415_RELBRANCH
authorRichard Marti <richard.marti@gmail.com>
Sun, 14 Feb 2016 15:01:01 +0100
branchTHUNDERBIRD450b3_2016032415_RELBRANCH
changeset 26841 e9cec34f984d9c5dfad6bdec1625ee03a2457468
parent 26840 4ff73baeaada0610f6b99a8a60d18eb7d7074fe2
child 26842 8599de737858aec437fe3039383062d6cd843a05
push id1850
push userclokep@gmail.com
push dateWed, 08 Mar 2017 19:29:12 +0000
treeherdercomm-esr52@028df196b2d9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin, rkent
bugs1248158
Bug 1248158 - For the menulist dropmarker use a background image instead the dropmarker itself. r=mkmelin a=rkent
mail/themes/linux/mail/compose/messengercompose.css
mail/themes/linux/mail/mailWindow1.css
--- a/mail/themes/linux/mail/compose/messengercompose.css
+++ b/mail/themes/linux/mail/compose/messengercompose.css
@@ -176,31 +176,29 @@ menulist[open="true"] {
   border-color: var(--toolbarbutton-active-bordercolor);
   box-shadow: var(--toolbarbutton-active-boxshadow);
 }
 
 menulist[disabled="true"] {
   opacity: .6;
 }
 
-.menulist-dropmarker {
+menulist > .menulist-label-box {
   -moz-appearance: none;
-  display:-moz-box;
-  list-style-image: none;
-}
-
-menulist > .menulist-dropmarker > .dropmarker-icon {
-  width: 9px;
-  max-height: 7px;
-  margin: 7px 5px;
-  margin-inline-end: 0;
+  padding-inline-end: 12px;
+  background-repeat: no-repeat;
+  background-position: right;
   background-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow.png");
 }
 
-toolbar[brighttext] menulist > .menulist-dropmarker > .dropmarker-icon {
+menulist:-moz-locale-dir(rtl) > .menulist-label-box {
+  background-position: left;
+}
+
+toolbar[brighttext] menulist > .menulist-label-box {
   background-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow-inverted.png");
 }
 
 /* ::::: special toolbar colors ::::: */
 
 #attachmentbucket-sizer {
   border-top: none;
 }
@@ -237,16 +235,17 @@ toolbar[brighttext] menulist > .menulist
 /* XXX I should really have a selector rule here to select just .listcell-icon objects underneath the attachmentList listbox */
 
 .listcell-icon {
   -moz-margin-start: 2px;
   margin-top: 2px;
 }
 
 #subjectLabel {
+  margin-inline-end: 7px;
   padding-bottom: 1px;
 }
 
 #subject-box {
   -moz-margin-start: -2px;
 }
 
 #msgSubject {
@@ -350,49 +349,42 @@ treechildren::-moz-tree-image(subscribed
   -moz-border-top-colors: ThreeDShadow ThreeDHighlight !important;
   -moz-border-right-colors: ThreeDShadow ThreeDHighlight !important;
   -moz-border-bottom-colors: ThreeDShadow ThreeDHighlight !important;
   -moz-border-left-colors: ThreeDShadow ThreeDHighlight !important;
 }
 
 .aw-menulist {
   -moz-binding: url("chrome://messenger/content/messengercompose/menulistCompactBindings.xml#menulist-compact");
-  -moz-appearance: none;
-  -moz-box-align: center;
-  -moz-box-pack: center;
   margin: 0;
   -moz-margin-start: 5px;
   -moz-margin-end: 7px;
-  color: ButtonText;
-  list-style-image: url("chrome://global/skin/arrow/arrow-dn.gif");
-  background-color: rgba(125, 125, 125, .3);
-  border: rgba(125, 125, 125, .4) 1px solid;
-  transition: background-color .25s ease-in;
+  padding-inline-end: 0;
+  outline: 1px solid transparent;
+  outline-offset: -3px;
 }
 
 .aw-menulist:-moz-window-inactive {
   opacity: .7;
 }
 
-.aw-menulist:hover {
-  background-color: rgba(125, 125, 125, .4);
-}
-
-.aw-menulist[disabled="true"] {
-  list-style-image: url("chrome://global/skin/arrow/arrow-dn-dis.gif");
+.aw-menulist > .menulist-label-box {
+  margin: -3px 1px;
+  padding-inline-start: 12px;
+  padding-inline-end: 0;
+  background-position: left;
 }
 
-.aw-menulist > .menulist-label-box {
-  -moz-appearance: none;
-  margin: -3px 1px;
-  border: 1px solid transparent;
+.aw-menulist:-moz-locale-dir(rtl) > .menulist-label-box {
+  background-position: right;
 }
 
-.aw-menulist:focus > .menulist-label-box {
-  border: 1px dotted;
+.aw-menulist:focus {
+  outline-color: -moz-DialogText;
+  outline-style: dotted;
 }
 
 .aw-menulist > .menulist-label-box > .menulist-label {
   margin: 0 3px !important;
   text-align: end;
 }
 
 .aw-menulist > .menulist-label-box > .menulist-icon {
--- a/mail/themes/linux/mail/mailWindow1.css
+++ b/mail/themes/linux/mail/mailWindow1.css
@@ -17,20 +17,16 @@
 
 /* give the toolbox a min-height of 42px for Australis theme */
 .mail-toolbox:not([mode="full"]) > toolbar:only-of-type,
 .mail-toolbox[mode="full"][labelalign="end"] > toolbar:only-of-type {
   margin-top: 7px;
   margin-bottom: 7px;
 }
 
-#viewPickerLabel:not(:-moz-lwtheme) {
-  color: MenuText;
-}
-
 menu > #folderLocationPopup > menu > .menu-iconic-left,
 menu > #folderLocationPopup > menuitem > .menu-iconic-left {
   -moz-padding-start: 2px;
 }
 
 #folderTree {
   border-bottom: 1px solid ThreeDShadow;
   background-color: -moz-OddTreeRow;
@@ -398,25 +394,23 @@ menulist[open="true"] {
   border-color: var(--toolbarbutton-active-bordercolor);
   box-shadow: var(--toolbarbutton-active-boxshadow);
 }
 
 menulist[disabled="true"] {
   opacity: .6;
 }
 
-.menulist-dropmarker {
+menulist > .menulist-label-box {
   -moz-appearance: none;
-  display:-moz-box;
-  list-style-image: none;
-}
-
-menulist > .menulist-dropmarker > .dropmarker-icon {
-  width: 9px;
-  max-height: 7px;
-  margin: 7px 5px;
-  margin-inline-end: 0;
+  padding-inline-end: 12px;
+  background-repeat: no-repeat;
+  background-position: right;
   background-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow.png");
 }
 
-toolbar[brighttext] menulist > .menulist-dropmarker > .dropmarker-icon {
+menulist:-moz-locale-dir(rtl) > .menulist-label-box {
+  background-position: left;
+}
+
+toolbar[brighttext] menulist > .menulist-label-box {
   background-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow-inverted.png");
 }