Bug 1138464 - 'Learn More' links for Telemetry and Crash Reporter in Settings'/Options' Data Choices tab open twice (as tab and in browser). r=aryx, a=mkmelin
authorMagnus Melin <mkmelin+mozilla@iki.fi>
Sat, 14 Mar 2015 21:06:42 +0200
changeset 25794 ad9a525a83b5182ad90db33a4b33169708be0865
parent 25793 ab534427dce3ecc60079e20ca280851845a9ed7c
child 25795 cbe3b7f342f5ea0e5fe8d7cb2ed10d5e1b0c7dd0
push id1850
push userclokep@gmail.com
push dateWed, 08 Mar 2017 19:29:12 +0000
treeherdercomm-esr52@028df196b2d9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaryx, mkmelin
bugs1138464
Bug 1138464 - 'Learn More' links for Telemetry and Crash Reporter in Settings'/Options' Data Choices tab open twice (as tab and in browser). r=aryx, a=mkmelin
mail/components/preferences/advanced.js
--- a/mail/components/preferences/advanced.js
+++ b/mail/components/preferences/advanced.js
@@ -495,16 +495,17 @@ updateWritePrefs: function ()
     // tab behind the modal options dialog.
     if (Services.prefs.getBoolPref("browser.preferences.instantApply")) {
       return true; // Yes, open the link in a content tab.
     }
     var url = evt.target.getAttribute("href");
     var messenger = Components.classes["@mozilla.org/messenger;1"]
       .createInstance(Components.interfaces.nsIMessenger);
     messenger.launchExternalURL(url);
+    evt.preventDefault();
     return false;
   },
 
   /**
    * Set up or hide the Learn More links for various data collection options
    */
   _setupLearnMoreLink: function (pref, element) {
     // set up the Learn More link with the correct URL