Bug 1287642 - Open as dialog for Add-ons and Data Managers should no longer be associated with browser.link.open_external; r=Ratty, a=IanN
authorrsx11m <rsx11m.pub@gmail.com>
Tue, 09 Aug 2016 15:34:35 -0500
changeset 27357 8342f65746bc2f1b779b5ac8e3edecb4665cdcb4
parent 27356 33f25c84a76a6748846a69e4b2ca62f89ea79135
child 27358 6ba8abbc0969bb9c7ccb1a8c3b25ef35960c0a8a
push id1850
push userclokep@gmail.com
push dateWed, 08 Mar 2017 19:29:12 +0000
treeherdercomm-esr52@028df196b2d9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersRatty, IanN
bugs1287642
Bug 1287642 - Open as dialog for Add-ons and Data Managers should no longer be associated with browser.link.open_external; r=Ratty, a=IanN
suite/common/utilityOverlay.js
--- a/suite/common/utilityOverlay.js
+++ b/suite/common/utilityOverlay.js
@@ -1665,19 +1665,17 @@ function switchToTabHavingURI(aURI, aOpe
     if (browserWin.closed || browserWin == window)
       continue;
     if (switchIfURIInWindow(browserWin))
       return true;
   }
 
   // No opened tab has that url.
   if (aOpenNew) {
-    let newWindowPref = Services.prefs.getIntPref("browser.link.open_external");
-    let where = newWindowPref == kNewTab ? "tabfocused" : "window";
-    let browserWin = openUILinkIn(aURI.spec, where);
+    let browserWin = openUILinkIn(aURI.spec, "tabfocused");
     if (aCallback) {
       browserWin.addEventListener("pageshow", function browserWinPageShow(event) {
         if (event.target.location.href != aURI.spec)
           return;
         browserWin.removeEventListener("pageshow", browserWinPageShow, true);
         aCallback(browserWin.getBrowser().selectedBrowser);
       }, true);
     }