Bug 1234619 - foldercycler invisible on dark LW-themes. r=clokep a=jorgk
authorRichard Marti <richard.marti@gmail.com>
Tue, 05 Jan 2016 14:47:04 +0100
changeset 26641 314f07a4926ef68e552d09595f4357eecffcf624
parent 26640 3e2c79311fe081a68226226b521a06e3076ced21
child 26642 98ebf79bc3aba8bd962f73f87a90e04ef84238ac
push id1850
push userclokep@gmail.com
push dateWed, 08 Mar 2017 19:29:12 +0000
treeherdercomm-esr52@028df196b2d9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersclokep, jorgk
bugs1234619
Bug 1234619 - foldercycler invisible on dark LW-themes. r=clokep a=jorgk
mail/themes/linux/jar.mn
mail/themes/linux/mail/icons/arrow/foldercycler-arrow-left.png
mail/themes/linux/mail/icons/arrow/foldercycler-arrow-right.png
mail/themes/linux/mail/mailWindow1.css
mail/themes/shared/mail/icons/foldercycler-arrow.svg
mail/themes/windows/jar.mn
mail/themes/windows/mail/icons/arrow/foldercycler-arrow-left.png
mail/themes/windows/mail/icons/arrow/foldercycler-arrow-right.png
mail/themes/windows/mail/mailWindow1.css
--- a/mail/themes/linux/jar.mn
+++ b/mail/themes/linux/jar.mn
@@ -229,18 +229,17 @@ classic.jar:
   skin/classic/messenger/icons/arrow/arrow-left.png           (mail/icons/arrow/arrow-left.png)
   skin/classic/messenger/icons/arrow/arrow-right.png          (mail/icons/arrow/arrow-right.png)
   skin/classic/messenger/icons/arrow/arrow-up.png             (mail/icons/arrow/arrow-up.png)
   skin/classic/messenger/icons/arrow/arrow-down.png           (mail/icons/arrow/arrow-down.png)
   skin/classic/messenger/icons/arrow/arrow-left-dim.png       (mail/icons/arrow/arrow-left-dim.png)
   skin/classic/messenger/icons/arrow/arrow-right-dim.png      (mail/icons/arrow/arrow-right-dim.png)
   skin/classic/messenger/icons/arrow/arrow-up-dim.png         (mail/icons/arrow/arrow-up-dim.png)
   skin/classic/messenger/icons/arrow/arrow-down-dim.png       (mail/icons/arrow/arrow-down-dim.png)
-  skin/classic/messenger/icons/arrow/foldercycler-arrow-left.png        (mail/icons/arrow/foldercycler-arrow-left.png)
-  skin/classic/messenger/icons/arrow/foldercycler-arrow-right.png       (mail/icons/arrow/foldercycler-arrow-right.png)
+  skin/classic/messenger/icons/arrow/foldercycler-arrow.svg   (../shared/mail/icons/foldercycler-arrow.svg)
   skin/classic/messenger/icons/connecting.png                 (mail/icons/connecting.png)
   skin/classic/messenger/icons/loading.png                    (mail/icons/loading.png)
   skin/classic/messenger/icons/notloading.png                 (mail/icons/notloading.png)
   skin/classic/messenger/tagbg.png                            (mail/tagbg.png)
 % skin editor classic/1.0 %skin/classic/editor/
   skin/classic/editor/editor.css                              (editor/editor.css)
   skin/classic/editor/EditorDialog.css                        (editor/EditorDialog.css)
   skin/classic/editor/icons/img-align-bottom.gif              (editor/img-align-bottom.gif)
deleted file mode 100644
index 211fe4d67920b7004037a1ab71f1d5ad0a8f5b9c..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 9f95d5f0d3f31ca3f404d6b7f320b6c9f64fc670..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/mail/themes/linux/mail/mailWindow1.css
+++ b/mail/themes/linux/mail/mailWindow1.css
@@ -225,32 +225,35 @@ treechildren::-moz-tree-image(subjectCol
 treechildren::-moz-tree-image(subjectCol, imapdeleted) {
   list-style-image: url("chrome://messenger/skin/icons/message.png");
   -moz-image-region: rect(0 80px 16px 64px);
 }
 
 /* ..... folder pane adjustments ..... */
 
 #folderpane-title {
-  -moz-padding-start: 12px;
-  -moz-padding-end: 8px;
+  padding-inline-start: 12px;
+  padding-inline-end: 8px;
+}
+
+.folderview-cycler {
+  padding-inline-end: 0 !important;
 }
 
 .folderview-cycler {
-  -moz-padding-end: 0px !important;
+  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow.svg#normal");
 }
 
-.folderview-cycler[dir="prev"],
-.folderview-cycler[dir="next"]:-moz-locale-dir(rtl) {
-  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow-left.png");
+.folderview-cycler:-moz-lwtheme-brighttext {
+  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow.svg#inverted");
 }
 
-.folderview-cycler[dir="next"],
-.folderview-cycler[dir="prev"]:-moz-locale-dir(rtl) {
-  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow-right.png");
+.folderview-cycler[dir="prev"]:-moz-locale-dir(ltr) > .toolbarbutton-icon,
+.folderview-cycler[dir="next"]:-moz-locale-dir(rtl) > .toolbarbutton-icon {
+  transform: scaleX(-1);
 }
 
 /* ..... splitter adjustments ..... */
 
 #folderpane_splitter,
 #threadpane-splitter:not([orient="vertical"]) {
   -moz-appearance: none;
   /* splitter grip area */
new file mode 100644
--- /dev/null
+++ b/mail/themes/shared/mail/icons/foldercycler-arrow.svg
@@ -0,0 +1,15 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg width="16" height="16" xmlns="http://www.w3.org/2000/svg">
+  <style>
+    path {
+      display: none;
+    }
+    path:target {
+      display: block;
+    }
+  </style>
+  <path id="normal" d="m 3,2 9,6 -9,6 z" style="fill: -moz-dialogtext;"/>
+  <path id="inverted" d="m 3,2 9,6 -9,6 z" style="fill: white;"/>
+</svg>
--- a/mail/themes/windows/jar.mn
+++ b/mail/themes/windows/jar.mn
@@ -308,18 +308,17 @@ classic.jar:
   skin/classic/messenger/icons/arrow/arrow-down.png           (mail/icons/arrow/arrow-down.png)
   skin/classic/messenger/icons/arrow/arrow-left-dim.png       (mail/icons/arrow/arrow-left-dim.png)
   skin/classic/messenger/icons/arrow/arrow-right-dim.png      (mail/icons/arrow/arrow-right-dim.png)
   skin/classic/messenger/icons/arrow/arrow-up-dim.png         (mail/icons/arrow/arrow-up-dim.png)
   skin/classic/messenger/icons/arrow/arrow-down-dim.png       (mail/icons/arrow/arrow-down-dim.png)
   skin/classic/messenger/icons/timeline.png                   (mail/icons/timeline.png)
   skin/classic/messenger/icons/timeline-inverted.png          (mail/icons/timeline-inverted.png)
   skin/classic/messenger/icons/empty-search-results.png       (mail/icons/empty-search-results.png)
-  skin/classic/messenger/icons/arrow/foldercycler-arrow-left.png        (mail/icons/arrow/foldercycler-arrow-left.png)
-  skin/classic/messenger/icons/arrow/foldercycler-arrow-right.png       (mail/icons/arrow/foldercycler-arrow-right.png)
+  skin/classic/messenger/icons/arrow/foldercycler-arrow.svg   (../shared/mail/icons/foldercycler-arrow.svg)
   skin/classic/messenger/icons/xp-pin-grey.png                (mail/icons/xp-pin-grey.png)
   skin/classic/messenger/icons/xp-pin-red.png                 (mail/icons/xp-pin-red.png)
   skin/classic/messenger/tagbg.png                            (mail/tagbg.png)
 % skin messenger-newsblog classic/1.0 %skin/classic/messenger-newsblog/
   skin/classic/messenger-newsblog/feed-subscriptions.css      (mail/newsblog/feed-subscriptions.css)
   skin/classic/messenger-newsblog/icons/rss-feed.png          (mail/newsblog/rss-feed.png)
   skin/classic/messenger-newsblog/icons/server-rss.png        (mail/newsblog/server-rss.png)
   skin/classic/messenger-newsblog/icons/server-rss-XP.png     (mail/newsblog/server-rss-XP.png)
deleted file mode 100644
index 211fe4d67920b7004037a1ab71f1d5ad0a8f5b9c..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 9f95d5f0d3f31ca3f404d6b7f320b6c9f64fc670..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/mail/themes/windows/mail/mailWindow1.css
+++ b/mail/themes/windows/mail/mailWindow1.css
@@ -291,34 +291,37 @@ treechildren::-moz-tree-image(subjectCol
 
 treechildren::-moz-tree-image(subjectCol, imapdeleted) {
   -moz-image-region: rect(0 80px 16px 64px);
 }
 
 /* ..... folder pane adjustments ..... */
 
 #folderpane-title {
-  -moz-padding-start: 12px;
-  -moz-padding-end: 8px;
+  padding-inline-start: 12px;
+  padding-inline-end: 8px;
 }
 
 @media (-moz-os-version: windows-xp) {
   .folderview-cycler {
-    -moz-padding-end: 0px;
+    padding-inline-end: 0;
   }
 }
 
-.folderview-cycler[dir="prev"],
-.folderview-cycler[dir="next"]:-moz-locale-dir(rtl) {
-  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow-left.png");
+.folderview-cycler {
+  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow.svg#normal");
 }
 
-.folderview-cycler[dir="next"],
-.folderview-cycler[dir="prev"]:-moz-locale-dir(rtl) {
-  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow-right.png");
+.folderview-cycler:-moz-lwtheme-brighttext {
+  list-style-image: url("chrome://messenger/skin/icons/arrow/foldercycler-arrow.svg#inverted");
+}
+
+.folderview-cycler[dir="prev"]:-moz-locale-dir(ltr) > .toolbarbutton-icon,
+.folderview-cycler[dir="next"]:-moz-locale-dir(rtl) > .toolbarbutton-icon {
+  transform: scaleX(-1);
 }
 
 /* ..... splitter adjustments ..... */
 
 #mailContent[layout="standard"] #threadpane-splitter {
   /* Overlap the folder pane splitter to make the splitters appear unified. */
   -moz-margin-start: -1px;
 }
@@ -834,18 +837,18 @@ treechildren::-moz-tree-image(subjectCol
   }
 
   #messagepanebox {
     border-top-width: 0px;
     -moz-border-start: none;
   }
 
   .folderview-cycler {
-    -moz-padding-start: 5px;
-    -moz-padding-end: 5px;
+    padding-inline-start: 5px;
+    padding-inline-end: 5px;
   }
 
   .treecol-image image {
     -moz-padding-start: 1px;
     -moz-padding-end: 2px;
   }
 
   .junkStatusHeader {