Bug 1048524 - "Function does not always return a value" warning in TagMenu. r=florian
authoraleth <aleth@instantbird.org>
Tue, 05 Aug 2014 00:39:13 +0200
changeset 16433 314d2f8b8de60c3b4b30342085da08508942335b
parent 16432 c05e65ecf57371b41ec6ef3cae57caa599d733b6
child 16434 f4fb90bd05f788ad320633be46eb636163d7a9ae
push id1234
push usermbanner@mozilla.com
push dateMon, 13 Oct 2014 17:59:18 +0000
treeherdercomm-esr52@b5a0add9fb18 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflorian
bugs1048524
Bug 1048524 - "Function does not always return a value" warning in TagMenu. r=florian
im/modules/ibTagMenu.jsm
--- a/im/modules/ibTagMenu.jsm
+++ b/im/modules/ibTagMenu.jsm
@@ -54,16 +54,17 @@ TagMenu.prototype = {
         if (aEvent.target.isAddTagItem)
           return this.addNewTag(aEvent);
         return this.tag(aEvent);
       case "popupshowing":
         return this.tagsPopupShowing(aEvent);
       case "popuphiding":
         return true;
     }
+    return true;
   },
   tagsPopupShowing: function(aEvent) {
     let item;
     while ((item = this.popup.firstChild) && item.localName != "menuseparator")
       item.remove();
 
     if (this.target) {
       var tags = this.target.contact.getTags();