Adapt comments in test to bug 428611 being fixed. Bug 599609, rs=standard8
authorBen Bucksch <ben.bucksch@beonex.com>
Wed, 27 Apr 2011 00:16:00 +0200
changeset 7629 9d16abe15b8b65e102e247a570f03ec9f4c44e74
parent 7628 0c9c4a20b02aa25a0ac445b1416d646adf04007f
child 7630 6fc9b3f397fe31b609bf1cd5f89a9d3c0d987e06
push idunknown
push userunknown
push dateunknown
reviewersstandard8
bugs428611, 599609
Adapt comments in test to bug 428611 being fixed. Bug 599609, rs=standard8
mailnews/local/test/unit/test_pop3ServerBrokenCRAMDisconnect.js
mailnews/test/fakeserver/auth.js
--- a/mailnews/local/test/unit/test_pop3ServerBrokenCRAMDisconnect.js
+++ b/mailnews/local/test/unit/test_pop3ServerBrokenCRAMDisconnect.js
@@ -12,18 +12,16 @@
  * I don't know if real servers do that, but bienvenu says they exist.
  *
  * TODO:
  * This test shows that the current situation is not good.
  * Problems:
  * - We should reopen the connection, remember which auth scheme failed
  *    and start with the next in list, not trying the broken one again.
  *    We currently neither retry nor remember.
- * - OnStopRunningUrl() returns success although the server closed the connection
- *    and it's clearly not successful.
  * - incomingServer thinks it is still running/busy although the connection is
  *    clearly done and over.
  *
  * @author Ben Bucksch
  */
 
 var server;
 var daemon;
@@ -37,16 +35,17 @@ const expectedTransaction = [ "AUTH", "C
 //const expectedTransaction = [ "AUTH", "CAPA", "AUTH CRAM-MD5", "CAPA", "AUTH PLAIN", "STAT" ];
 
 var urlListener =
 {
   OnStartRunningUrl: function (url) {
   },
   OnStopRunningUrl: function (url, result) {
     try {
+      // We should be getting an error here, because we couldn't log in.
       do_check_eq(result, Cr.NS_ERROR_FAILURE);
 
       var transaction = server.playTransaction();
       do_check_transaction(transaction, expectedTransaction);
 
       do_timeout(0, endTest);
     } catch (e) {
       server.stop();
--- a/mailnews/test/fakeserver/auth.js
+++ b/mailnews/test/fakeserver/auth.js
@@ -31,16 +31,17 @@
  * decision by deleting the provisions above and replace them with the notice
  * and other provisions required by the GPL or the LGPL. If you do not delete
  * the provisions above, a recipient may use your version of this file under
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
 /**
  * This file implements the authentication mechanisms
+ * - AUTH LOGIN
  * - AUTH PLAIN
  * - AUTH CRAM-MD5
  * for all the server implementations, i.e. in a generic way.
  * In fact, you could use this to implement a real server in JS :-) .
  *
  * @author Ben Bucksch <ben.bucksch beonex.com>
  */