Bug 937470 - Eliminate unsafe uses of cloneNode() with no arguments from calendar code r=philipp
authorStefan Sitter <ssitter@gmail.com>
Thu, 14 Nov 2013 20:35:33 +0100
changeset 16901 f583af6bca1ae57773f810d45434fecc8a2cae33
parent 16900 178eccc0971cebc3e04a1b41099cabb67ce90638
child 16902 c7205791228e2bf7a678f87bff4374b6aec4bac0
push id1074
push userbugzilla@standard8.plus.com
push dateMon, 03 Feb 2014 22:47:23 +0000
treeherdercomm-beta@6b791b5369ed [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersphilipp
bugs937470
Bug 937470 - Eliminate unsafe uses of cloneNode() with no arguments from calendar code r=philipp
calendar/base/content/dialogs/calendar-event-dialog.js
--- a/calendar/base/content/dialogs/calendar-event-dialog.js
+++ b/calendar/base/content/dialogs/calendar-event-dialog.js
@@ -1816,19 +1816,19 @@ function loadCloudProviders() {
 
         if (cloudProvider.iconClass) {
             item.setAttribute("class", "menuitem-iconic");
             item.setAttribute("image", cloudProvider.iconClass);
         }
 
         // Add the item to the different places we advertise cloud providers
         if (toolbarPopup) {
-            toolbarPopup.appendChild(item.cloneNode()).cloudProvider = cloudProvider;
+            toolbarPopup.appendChild(item.cloneNode(true)).cloudProvider = cloudProvider;
         }
-        attachmentPopup.appendChild(item.cloneNode()).cloudProvider = cloudProvider;
+        attachmentPopup.appendChild(item.cloneNode(true)).cloudProvider = cloudProvider;
 
         // The last one doesn't need to clone, just use the item itself.
         optionsPopup.appendChild(item).cloudProvider = cloudProvider;
     }
 }
 
 /**
  * Prompts the user to attach an url to this item.