Bug 1519696 - Make the AB card pane themeable. r=jorgk
authorRichard Marti <richard.marti@gmail.com>
Tue, 08 Jan 2019 07:05:40 +0100
changeset 33328 ef82c0a03335
parent 33327 bc4167748b7d
child 33329 a669bb42f03e
push id2368
push userclokep@gmail.com
push dateMon, 28 Jan 2019 21:12:50 +0000
treeherdercomm-beta@56d23c07d815 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorgk
bugs1519696
Bug 1519696 - Make the AB card pane themeable. r=jorgk
mail/components/addrbook/content/addressbook.xul
mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
mail/themes/linux/mail/addrbook/addressbook.css
mail/themes/osx/mail/addrbook/addressbook.css
mail/themes/shared/mail/addressbook.css
mail/themes/windows/mail/addrbook/addressbook.css
--- a/mail/components/addrbook/content/addressbook.xul
+++ b/mail/components/addrbook/content/addressbook.xul
@@ -663,20 +663,16 @@
 #endif
    </toolbar>
    <toolbarset id="customToolbars" context="toolbar-context-menu"/>
   </toolbox>
 
   <!-- The main address book three pane -->
   <hbox id="abContent" flex="1">
     <vbox id="dirTreeBox" persist="width collapsed">
-      <sidebarheader id="abDirTreeHeader" hidden="true" align="center">
-        <label id="abDirTreeHeader-title" value="&dirTreeHeader.label;" control="dirTree"/>
-      </sidebarheader>
-
       <!-- FIX ME - remove document.commandDispatcher.updateCommands() when tree selection calls this automatically -->
       <tree id="dirTree" class="abDirectory plain" seltype="single" minwidth="150" flex="1" persist="width"
             hidecolumnpicker="true"
             context="dirTreeContext"
             onselect="DirPaneSelectionChange(); document.commandDispatcher.updateCommands('addrbook-select');"
             ondblclick="DirPaneDoubleClick(event);"
             onclick="DirPaneClick(event);"
             onblur="goOnEvent(this,'blur')">
--- a/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
+++ b/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
@@ -169,19 +169,16 @@ because displayed names don't have the c
 <!ENTITY editPropertiesButton.tooltip                   "Edit the selected item">
 <!ENTITY editAbPropertiesButton.tooltip                 "Edit the properties of the selected address book">
 <!ENTITY editContactPropertiesButton.tooltip            "Edit the selected contact">
 <!ENTITY editMailingListPropertiesButton.tooltip        "Edit the selected mailing list">
 <!ENTITY newmsgButton.tooltip                           "Send a mail message">
 <!ENTITY newIM.tooltip                                  "Send an instant message or chat">
 <!ENTITY deleteButton2.tooltip                          "Delete selected item">
 
-<!-- Dir Tree header -->
-<!ENTITY dirTreeHeader.label                            "Address Books">
-
 <!-- Search Bar -->
 <!ENTITY SearchNameOrEmail.label                        "Name or Email">
 <!ENTITY SearchNameOrEmail.accesskey                    "N">
 <!ENTITY advancedButton.tooltip                         "Advanced address search">
 <!ENTITY quickSearchCmd.key                             "k">
 <!ENTITY searchItem.title "Quick Search">
 
 <!-- Results Pane -->
--- a/mail/themes/linux/mail/addrbook/addressbook.css
+++ b/mail/themes/linux/mail/addrbook/addressbook.css
@@ -17,24 +17,16 @@
 
 #ab-toolbox > toolbar {
   /* force iconsize="small" on these toolbars */
   counter-reset: smallicons;
 }
 
 /* ::::: directory pane adjustments ::::: */
 
-#abDirTreeHeader {
-  border-bottom: 1px solid ThreeDShadow;
-}
-
-#abDirTreeHeader-title {
-  padding-inline-start: 4px;
-}
-
 #dirTree:not(:-moz-lwtheme) {
   border-bottom: 1px solid ThreeDShadow;
 }
 
 /* ::::: splitters ::::: */
 
 #dirTree-splitter {
   -moz-appearance: none;
@@ -71,24 +63,16 @@
 }
 
 /* ::::: card view pane ::::: */
 
 #CardViewOuterBox {
   border-bottom: 1px solid ThreeDShadow;
 }
 
-#CardViewBox {
-  -moz-user-focus: ignore;
-  overflow: auto;
-  min-width: 150px;
-  background-color: -moz-Field;
-  color: -moz-FieldText;
-}
-
 #CardViewInnerBox {
   margin-top: 2px;
   margin-bottom: 2px;
   padding: 0 8px;
 }
 
 #CardTitle {
   font-size: 150%;
--- a/mail/themes/osx/mail/addrbook/addressbook.css
+++ b/mail/themes/osx/mail/addrbook/addressbook.css
@@ -29,21 +29,16 @@
 
 #ab-toolbox > toolbar {
   /* force iconsize="small" on these toolbars */
   counter-reset: smallicons;
 }
 
 /* ::::: directory pane icons ::::: */
 
-#abDirTreeHeader {
-  -moz-appearance: treeheadercell;
-  height: 16px;
-}
-
 :root:not([lwt-tree]) #dirTree {
   -moz-appearance: -moz-mac-source-list;
   -moz-font-smoothing-background-color: -moz-mac-source-list;
   border-inline-end: 1px solid #bdbdbd;
 }
 
 #dirTree treechildren::-moz-tree-row {
   padding-bottom: 1px;
@@ -153,22 +148,16 @@
 }
 
 #CardViewOuterBox {
   color: -moz-DialogText;
   margin: 0px;
   padding: 0px;
 }
 
-#CardViewBox {
-  -moz-user-focus: ignore;
-  overflow: auto;
-  min-width: 150px;
-}
-
 #CardViewInnerBox {
   background-color: #FFFFFF;
 }
 
 #CardViewInnerBox > hbox {
   background-color: #FFFFFF;
 }
 
--- a/mail/themes/shared/mail/addressbook.css
+++ b/mail/themes/shared/mail/addressbook.css
@@ -112,16 +112,22 @@ treechildren::-moz-tree-image(GeneratedN
 }
 
 treechildren::-moz-tree-cell-text(GeneratedName) {
   padding-inline-start: 0;
 }
 
 /* ::::: card view pane ::::: */
 
+#CardViewBox {
+  -moz-user-focus: ignore;
+  overflow: auto;
+  min-width: 150px;
+}
+
 #cvPhoto {
   list-style-image: url("chrome://messenger/skin/addressbook/icons/contact-generic.png");
 }
 
 #cvBuddyIcon {
   padding-inline-start: 20px;
   padding-top: 2px;
 }
@@ -137,17 +143,16 @@ treechildren::-moz-tree-cell-text(Genera
 .CardViewLink {
   padding-inline-start: 20px;
   padding-inline-end: 2px;
   min-width: 30px;
   margin: 0;
 }
 
 .CardViewLink {
-  color: -moz-nativehyperlinktext;
   cursor: pointer;
 }
 
 #blankResultsPaneMessageBox {
   background-color: -moz-field;
 }
 
 #blankResultsPaneMessage {
--- a/mail/themes/windows/mail/addrbook/addressbook.css
+++ b/mail/themes/windows/mail/addrbook/addressbook.css
@@ -4,38 +4,24 @@
 
 /* ===== addressbook.css ================================================
   == Styles for the main Address Book window.
   ======================================================================= */
 
 @import url("chrome://messenger/skin/");
 @import url("chrome://messenger/skin/shared/addressbook.css");
 
-/* ::::: directory pane adjustments ::::: */
-
-#abDirTreeHeader-title {
-  padding-inline-start: 4px;
-}
-
 /* ::::: results pane ::::: */
 
 #GeneratedName {
   padding-inline-start: 30px;
 }
 
 /* ::::: card view pane ::::: */
 
-#CardViewBox {
-  -moz-user-focus: ignore;
-  overflow: auto;
-  min-width: 150px;
-  background-color: -moz-Field;
-  color: -moz-FieldText;
-}
-
 #CardViewInnerBox {
   margin-top: 2px;
   margin-bottom: 2px;
   padding: 0 8px;
 }
 
 #CardTitle {
   font-size: 150%;