Bug 1374190 - Increase time waiting for spell checker due to bug 1370754. r=aceman
authorJorg K <jorgk@jorgk.com>
Thu, 22 Jun 2017 23:49:32 +0200
changeset 28375 ea17e74e9fe364786ad0e7b06c8a2eb385938fca
parent 28374 bd78c240ad996e5b46ba87f4b85ca8dd385a2c39
child 28376 213e1c2f2be591235563ac6f88acaeee4ac4c639
push id1986
push userclokep@gmail.com
push dateWed, 02 Aug 2017 14:43:31 +0000
treeherdercomm-beta@b51c9adf2c9e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaceman
bugs1374190, 1370754
Bug 1374190 - Increase time waiting for spell checker due to bug 1370754. r=aceman
mail/test/mozmill/content-tabs/test-content-tab.js
--- a/mail/test/mozmill/content-tabs/test-content-tab.js
+++ b/mail/test/mozmill/content-tabs/test-content-tab.js
@@ -60,17 +60,19 @@ function test_spellcheck_in_content_tabs
   let w = tabmail.selectedTab.browser.contentWindow;
   let textarea = w.document.querySelector("textarea");
   let eidMailContext = mc.eid("mailContext");
 
   // Test a few random items
   mc.click(new elementslib.Elem(textarea));
   // Bug 364914 causes textareas to not be spell checked until they have been
   // focused at last once, so give the event loop a chance to spin.
-  mc.sleep(0);
+  // Since bug 1370754 the inline spell checker waits 1 second, so let's
+  // wait 2 seconds to be on the safe side.
+  mc.sleep(2000);
   mc.rightClick(new elementslib.Elem(textarea));
   assert_element_visible("mailContext-spell-dictionaries");
   assert_element_visible("mailContext-spell-check-enabled");
   assert_element_not_visible("mailContext-replySender"); // we're in a content tab!
   close_popup(mc, eidMailContext);
 
   // Different test
   mc.rightClick(new elementslib.Elem(w.document.body.firstElementChild));
@@ -88,18 +90,16 @@ function test_spellcheck_in_content_tabs
 
   // Now check we don't have any suggestionss
   EventUtils.synthesizeMouse(textarea, 5, 5,
                              {type: "contextmenu", button: 2}, w);
   suggestions = mc.window.document.getElementsByClassName("spell-suggestion");
   assert_true(suggestions.length == 0, "But I just taught you this word!");
   close_popup(mc, eidMailContext);
 }
-// XXX Currently the spellcheck test has focus issues on non-Mac
-test_spellcheck_in_content_tabs.EXCLUDED_PLATFORMS = ['winnt', 'linux'];
 
 function test_content_tab_context_menu() {
   let tabmail = mc.tabmail;
   let w = tabmail.selectedTab.browser.contentWindow;
   let heading = w.document.querySelector("h1");
   let mailContext = mc.e("mailContext");
 
   // Make sure the page's menu items are added on right-click.