Bug 836921 - Remove nsIUpdateCheckListener onprogress from aboutDialog.js. r=mbanner
authorRobert Strong <robert.bugzilla@gmail.com>
Thu, 07 Feb 2013 14:50:23 -0800
changeset 14834 e58ec29c87f93b80f15a7591420f2c9a2212a5e2
parent 14833 899bbca945e57cafa22dadeb1bc459a82bf6e7c3
child 14835 d0116578620988c8a663907aaffba3a863ef85b5
push id867
push userbugzilla@standard8.plus.com
push dateMon, 01 Apr 2013 20:44:27 +0000
treeherdercomm-beta@797726b8d244 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmbanner
bugs836921
Bug 836921 - Remove nsIUpdateCheckListener onprogress from aboutDialog.js. r=mbanner
mail/base/content/aboutDialog.js
--- a/mail/base/content/aboutDialog.js
+++ b/mail/base/content/aboutDialog.js
@@ -309,30 +309,23 @@ appUpdater.prototype =
 
     this.selectPanel("checkingForUpdates");
     this.isChecking = true;
     this.checker.checkForUpdates(this.updateCheckListener, true);
   },
 
   /**
    * Implements nsIUpdateCheckListener. The methods implemented by
-   * nsIUpdateCheckListener have to be in a different scope from
-   * nsIIncrementalDownload because both nsIUpdateCheckListener and
-   * nsIIncrementalDownload implement onProgress.
+   * nsIUpdateCheckListener are in a different scope from nsIIncrementalDownload
+   * to make it clear which are used by each interface.
    */
   updateCheckListener: {
     /**
      * See nsIUpdateService.idl
      */
-    onProgress: function(aRequest, aPosition, aTotalSize) {
-    },
-
-    /**
-     * See nsIUpdateService.idl
-     */
     onCheckComplete: function(aRequest, aUpdates, aUpdateCount) {
       gAppUpdater.isChecking = false;
       gAppUpdater.update = gAppUpdater.aus.
                            selectUpdate(aUpdates, aUpdates.length);
       if (!gAppUpdater.update) {
         gAppUpdater.selectPanel("noUpdatesFound");
         return;
       }