Bug 1422970 - Stop using the 'toolbarbutton-image' binding in suite. r=frg.
authorstefanh@inbox.com
Mon, 04 Dec 2017 22:30:17 +0100
changeset 29740 dfd2aaddad149c537a38459735ec457ae179d086
parent 29739 6c5d6da403b7ecc43279ddc85db4dd85d8a345d0
child 29741 1420d31fa6714b0ab75d24b62ebb0b6e4f019287
push id2108
push userclokep@gmail.com
push dateMon, 22 Jan 2018 17:53:55 +0000
treeherdercomm-beta@c44930d8ad9b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfrg
bugs1422970
Bug 1422970 - Stop using the 'toolbarbutton-image' binding in suite. r=frg.
suite/mailnews/tabmail.xml
suite/themes/classic/communicator/sidebar/sidebar.css
suite/themes/classic/mac/communicator/sidebar/sidebar.css
suite/themes/modern/communicator/sidebar/sidebar.css
--- a/suite/mailnews/tabmail.xml
+++ b/suite/mailnews/tabmail.xml
@@ -1472,17 +1472,17 @@
        These bindings rely on the structure of the tabbrowser binding.
        Therefore they should only be used as a child of the tab or the tabs
        element (in both cases, when they are anonymous nodes of <tabbrowser>).
        These bindings are exposed as pseudo-public-APIs, so themes can customize
        the tabbar appearance without having to be scriptable
        (see globalBindings.xml in osx for example).
   -->
   <binding id="tabmail-new-tab-button"
-           extends="chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image">
+           extends="chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton">
     <handlers>
       <handler event="command">
         <![CDATA[
           let bindingParent = document.getBindingParent(this);
           if (bindingParent)
           {
             let tabmail = document.getBindingParent(bindingParent);
             if (bindingParent.localName == "tabs")
@@ -1498,17 +1498,17 @@
         <![CDATA[
           event.stopPropagation();
         ]]>
       </handler>
     </handlers>
   </binding>
 
   <binding id="tabmail-close-tab-button"
-           extends="chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image">
+           extends="chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton">
     <handlers>
       <handler event="command">
         <![CDATA[
           let bindingParent = document.getBindingParent(this);
           if (bindingParent)
           {
             let tabmail = document.getBindingParent(bindingParent);
             if (bindingParent.localName == "tab")
--- a/suite/themes/classic/communicator/sidebar/sidebar.css
+++ b/suite/themes/classic/communicator/sidebar/sidebar.css
@@ -51,17 +51,16 @@
 
 .sidebar-header-text {
   font-weight: bold;
 }
 
 /* ..... close button ..... */
 
 #sidebar-close-button {
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding-top: 1px;
   padding-bottom: 1px;
   padding-inline-start: 4px;
   padding-inline-end: 3px;
   list-style-image: url("chrome://communicator/skin/icons/close-button.gif");
 }
 
 /* ::::: sidebar panel ::::: */
@@ -157,17 +156,16 @@
 
 .sbtab-twisty[selected="true"] {
   list-style-image: url("chrome://communicator/skin/sidebar/sbtab-twisty-open.gif");
 }
 
 /* ::::: sidebar navigation buttons ::::: */
 
 .sidebar-nav-button {
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding: 5px 0px;
 }
 
 .tab-fwd {
   list-style-image: url("chrome://global/skin/arrow/arrow-up.gif");
 }
 
 .tab-back {
--- a/suite/themes/classic/mac/communicator/sidebar/sidebar.css
+++ b/suite/themes/classic/mac/communicator/sidebar/sidebar.css
@@ -49,17 +49,16 @@
 
 .sidebar-header-text {
   font-weight: bold;
 }
 
 /* ..... close button ..... */
 
 #sidebar-close-button {
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding-top: 1px;
   padding-bottom: 1px;
   padding-inline-start: 4px;
   padding-inline-end: 3px;
   list-style-image: url("chrome://communicator/skin/icons/close-button.gif");
 }
 
 /* ::::: sidebar panel ::::: */
@@ -154,17 +153,16 @@
 
 .sbtab-twisty[selected="true"] {
   list-style-image: url("chrome://communicator/skin/sidebar/sbtab-twisty-open.gif");
 }
 
 /* ::::: sidebar navigation buttons ::::: */
 
 .sidebar-nav-button {
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding: 5px 0px;
 }
 
 .tab-fwd {
   list-style-image: url("chrome://global/skin/arrow/arrow-up.gif");
 }
 
 .tab-back {
--- a/suite/themes/modern/communicator/sidebar/sidebar.css
+++ b/suite/themes/modern/communicator/sidebar/sidebar.css
@@ -50,17 +50,16 @@
   padding-inline-end: 2px;
   padding-inline-start: 2px;
 }
 
 /* ..... close button ..... */
 
 #sidebar-close-button {
   margin: 0px 1px;
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding: 0px;
   list-style-image: url("chrome://global/skin/icons/closebox.gif");
 }
 
 #sidebar-close-button > .toolbarbutton-icon {
   margin: 0px;
 }
 
@@ -231,17 +230,16 @@
 .box-texttab[selected] > .sidebar-tab-right-box > .sidebar-tab-right-top-box > .sidebar-tab-right-line 
 {
   -moz-border-bottom-colors: #E2EAF4 #8CA2B3 !important;
 }
 
 /* ::::: sidebar navigation buttons ::::: */
 
 .sidebar-nav-button {
-  -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-image");
   padding: 5px 0px 5px 0px;
 }
 
 .tab-fwd {
   list-style-image: url("chrome://global/skin/arrow/arrow-up.gif");
 }
 
 .tab-back {