Bug 466530 Create new/correct string for what's new tab. r=mkmelin
authorMark Banner <bugzilla@standard8.plus.com>
Sat, 20 Dec 2008 14:17:27 +0000
changeset 1468 d7d303b5048a45d222060eff88acf1c1f2c7c3b6
parent 1467 33b262c9560fd42ca57604c5dac7db2c006ebde9
child 1469 a36eb2e47cb24369169a061552141ebe690ccb49
push idunknown
push userunknown
push dateunknown
reviewersmkmelin
bugs466530
Bug 466530 Create new/correct string for what's new tab. r=mkmelin
mail/base/content/msgMail3PaneWindow.js
mail/locales/en-US/chrome/messenger/messenger.properties
--- a/mail/base/content/msgMail3PaneWindow.js
+++ b/mail/base/content/msgMail3PaneWindow.js
@@ -142,32 +142,19 @@ var whatsnewTabType = {
       maxTabs: 1
     }
   },
   openTab: function onTabOpened (aTab) {
     let startpage = Components.classes["@mozilla.org/toolkit/URLFormatterService;1"]
                               .getService(Components.interfaces.nsIURLFormatter)
                               .formatURLPref("mailnews.start_page.override_url");
     aTab.panel.setAttribute("src", startpage);
-    
-    try {
-      // Note: "updateType_major" is a temporary solution until we add
-      // tab title string into messenger string bundle. When done,
-      // final code will look like something like that;
-      //let msgBundle = document.getElementById("bundle_messenger");
-      //aTab.title = msgBundle.getString("whatsNew");
-      
-      let updateBundle = Components.classes["@mozilla.org/intl/stringbundle;1"]
-                                   .getService(Components.interfaces.nsIStringBundleService)
-                                  .createBundle(URI_UPDATES_PROPERTIES);
-      aTab.title = updateBundle.GetStringFromName("updateType_major");
-    }
-    catch(e) {
-      aTab.title = "What's New";
-    }
+
+    let msgBundle = document.getElementById("bundle_messenger");
+    aTab.title = msgBundle.getString("whatsNew");
   },
   closeTab: function onTabClosed (aTab) {
   },
   saveTabState: function onSaveTabState (aTab) {
   },
   showTab: function onShowTab (aTab) {
   }
 };
--- a/mail/locales/en-US/chrome/messenger/messenger.properties
+++ b/mail/locales/en-US/chrome/messenger/messenger.properties
@@ -449,8 +449,11 @@ emptyTrashDontAsk=Don't ask me again.
 
 # junkCommands.js
 junkAnalysisPercentComplete=Junk analysis %S complete
 processingJunkMessages=Processing Junk Messages
 
 # second person direct object pronoun; used in the collapsed header view if
 # the user is in the To or Cc field of a message
 headerFieldYou=You
+
+# The what's new tab title, shown on version update
+whatsNew=What's New