Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin a=wsmwk
authorJohn Bieling <john@thunderbird.net>
Thu, 19 Aug 2021 13:51:23 +0300
changeset 43588 c2490facf3f6dcaf10e1f7d19ac23d93a4823ead
parent 43587 559f1784650193f33573bbb77f138a7e8ea0d12a
child 43589 07019c5ba071a285db0c6a434d5e95c4bc2a3270
push id3270
push userthunderbird@calypsoblue.org
push dateWed, 01 Sep 2021 19:33:48 +0000
treeherdercomm-beta@2821aa689177 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin, wsmwk
bugs1725144
Bug 1725144 - Fix schema definitions of action buttons involving IconPath type. r=mkmelin a=wsmwk When I simplified the schema definitions in D115600 by using the IconPath type, I forgot to add the manifest namespace, which is needed when it is used in a function definition and not in the main manifest. Differential Revision: https://phabricator.services.mozilla.com/D122984
mail/components/extensions/schemas/browserAction.json
mail/components/extensions/schemas/composeAction.json
mail/components/extensions/schemas/messageDisplayAction.json
--- a/mail/components/extensions/schemas/browserAction.json
+++ b/mail/components/extensions/schemas/browserAction.json
@@ -250,17 +250,17 @@
                   { "$ref": "ImageDataDictionary" }
                 ],
                 "optional": true,
                 "description": "Either an ImageDataType object defining a single icon used for all sizes or an ImageDataDictionary object defining dedicated icons for different sizes."
               },
               "path": {
                 "choices": [
                   { "type": "string" },
-                  {"$ref": "IconPath" }
+                  { "$ref": "manifest.IconPath" }
                 ],
                 "optional": true,
                 "description": "Either a relative image path defining a single icon used for all sizes or an IconPathDictionary object defining dedicated icons for different sizes."
               }
             }
           },
           {
             "type": "function",
--- a/mail/components/extensions/schemas/composeAction.json
+++ b/mail/components/extensions/schemas/composeAction.json
@@ -249,17 +249,17 @@
                   { "$ref": "ImageDataDictionary" }
                 ],
                 "optional": true,
                 "description": "Either an ImageDataType object defining a single icon used for all sizes or an ImageDataDictionary object defining dedicated icons for different sizes."
               },
               "path": {
                 "choices": [
                   { "type": "string" },
-                  {"$ref": "IconPath" }
+                  { "$ref": "manifest.IconPath" }
                 ],
                 "optional": true,
                 "description": "Either a relative image path defining a single icon used for all sizes or an IconPathDictionary object defining dedicated icons for different sizes."
               }
             }
           },
           {
             "type": "function",
--- a/mail/components/extensions/schemas/messageDisplayAction.json
+++ b/mail/components/extensions/schemas/messageDisplayAction.json
@@ -248,17 +248,17 @@
                   { "$ref": "ImageDataDictionary" }
                 ],
                 "optional": true,
                 "description": "Either an ImageDataType object defining a single icon used for all sizes or an ImageDataDictionary object defining dedicated icons for different sizes."
               },
               "path": {
                 "choices": [
                   { "type": "string" },
-                  {"$ref": "IconPath" }
+                  { "$ref": "manifest.IconPath" }
                 ],
                 "optional": true,
                 "description": "Either a relative image path defining a single icon used for all sizes or an IconPathDictionary object defining dedicated icons for different sizes."
               }
             }
           },
           {
             "type": "function",