Bug 663636 - Missing addons, directory distribution/extensions is not there. r=KaiRo a=KaiRo
authorJustin Wood <bugspam.Callek>
Thu, 16 Jun 2011 22:07:00 -0400
changeset 7810 bc9932900a348ee6b6f2cf561ec30cd09c665c60
parent 7809 54a07d87ea36faa2b5147994460d683073e7e1d6
child 7811 c9d3e5785364a75a57e9c8de93fda7728fefc615
push id16
push userCallek@gmail.com
push dateSat, 18 Jun 2011 03:07:07 +0000
treeherdercomm-beta@bc9932900a34 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersKaiRo, KaiRo
bugs663636
Bug 663636 - Missing addons, directory distribution/extensions is not there. r=KaiRo a=KaiRo
suite/installer/windows/nsis/installer.nsi
--- a/suite/installer/windows/nsis/installer.nsi
+++ b/suite/installer/windows/nsis/installer.nsi
@@ -294,16 +294,22 @@ Section "-Application" APP_IDX
   DetailPrint $(STATUS_INSTALL_APP)
   SetDetailsPrint none
 
   ${LogHeader} "Installing Main Files"
   ${CopyFilesFromDir} "$EXEDIR\core" "$INSTDIR" \
                       "$(ERROR_CREATE_DIRECTORY_PREFIX)" \
                       "$(ERROR_CREATE_DIRECTORY_SUFFIX)"
 
+  ; distribution/extensions must exist for the optional extensions to install
+  ; properly. Ensure it is present on install, no harm if it is empty.
+  ; CreateDirectory creates nested dirs if required. If already present we'll
+  ; Just fix ourselves on ClearErrors below
+  CreateDirectory "$INSTDIR\distribution\extensions"
+
   ; The MAPI DLL's are copied and the copies are then registered to lessen
   ; file in use errors on application update.
   ClearErrors
   ${DeleteFile} "$INSTDIR\MapiProxy_InUse.dll"
   ${If} ${Errors}
     ; Clear the way for the new file and delete the old file on reboot
     Rename "$INSTDIR\MapiProxy_InUse.dll" "$INSTDIR\MapiProxy_InUse.dll.moz-delete"
     Delete /REBOOTOK "$INSTDIR\MapiProxy_InUse.dll.moz-delete"