Bug 807592 Frequent red on builders: error RC2135 : file not found: address-book.ico. r=sid0,a=Standard8 BETA_BASE_20121119
authorMark Banner <bugzilla@standard8.plus.com>
Fri, 16 Nov 2012 16:10:53 +0000
changeset 13946 305b7bcca6ebb40f921e0d20f97a233efc2e182d
parent 13945 367783b7c4a1281a2e8b607517c6fa2fb5f443f5
child 13947 b6099fb53a0e6b386125100096f15abd89dcadd8
push id762
push userbugzilla@standard8.plus.com
push dateMon, 19 Nov 2012 21:16:42 +0000
treeherdercomm-beta@4a2f61509b17 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssid0, Standard8
bugs807592
Bug 807592 Frequent red on builders: error RC2135 : file not found: address-book.ico. r=sid0,a=Standard8
mail/app/Makefile.in
--- a/mail/app/Makefile.in
+++ b/mail/app/Makefile.in
@@ -92,17 +92,17 @@ ifdef _MSC_VER
 WIN32_EXE_LDFLAGS += -ENTRY:wmainCRTStartup
 endif
 
 ifeq ($(OS_ARCH),WINNT)
 # Extract the icons we care about embedding into the EXE
 mailtoolbar = $(topsrcdir)/mail/themes/qute/mail/icons/mail-toolbar-aero.png
 # Each icon is 18x18 in the toolbar, and we want a 16x16 icon here, so we cut
 # off a pixel at each end.
-libs::
+embedded-icons::
 	$(call png2ico,$(mailtoolbar),19,1,16,write-message.ico)
 	$(call png2ico,$(mailtoolbar),37,1,16,address-book.ico)
 
 GARBAGE += write-message.ico address-book.ico
 
 RCINCLUDE = splash.rc
 ifndef GNU_CC
 RCFLAGS += -DMOZ_THUNDERBIRD -I$(srcdir)
@@ -115,16 +115,19 @@ ifeq ($(OS_ARCH),OS2)
 RESFILE=splashos2.res
 RCFLAGS += -DMOZ_THUNDERBIRD
 RCFLAGS += -DTHUNDERBIRD_ICO=\"$(DIST)/branding/thunderbird.ico\"
 endif
 
 include $(topsrcdir)/config/rules.mk
 
 ifeq ($(OS_ARCH),WINNT)
+
+$(RESFILE): embedded-icons
+
 #
 # Control the default heap size.
 # This is the heap returned by GetProcessHeap().
 # As we use the CRT heap, the default size is too large and wastes VM.
 #
 # The default heap size is 1MB on Win32.
 # The heap will grow if need be.
 #