Bug 610611 - redundant GetMessageKey() call; r=bienvenu
--- a/mailnews/db/msgdb/src/nsMsgThread.cpp
+++ b/mailnews/db/msgdb/src/nsMsgThread.cpp
@@ -199,24 +199,23 @@ NS_IMETHODIMP nsMsgThread::GetNumUnreadC
{
NS_ENSURE_ARG_POINTER(result);
*result = m_numUnreadChildren;
return NS_OK;
}
nsresult nsMsgThread::RerootThread(nsIMsgDBHdr *newParentOfOldRoot, nsIMsgDBHdr *oldRoot, nsIDBChangeAnnouncer *announcer)
{
+ nsresult rv = NS_OK;
+ mdb_pos outPos;
+ nsMsgKey newHdrAncestor;
nsCOMPtr <nsIMsgDBHdr> ancestorHdr = newParentOfOldRoot;
nsMsgKey newRoot;
- newParentOfOldRoot->GetMessageKey(&newRoot);
- mdb_pos outPos;
- nsMsgKey newHdrAncestor;
ancestorHdr->GetMessageKey(&newRoot);
- nsresult rv = NS_OK;
// loop trying to find the oldest ancestor of this msg
// that is a parent of the root. The oldest ancestor will
// become the root of the thread.
do
{
ancestorHdr->GetThreadParent(&newHdrAncestor);
if (newHdrAncestor != nsMsgKey_None && newHdrAncestor != m_threadRootKey && newHdrAncestor != newRoot)
{