Bug 1514068 - Use IDs for correct rules selection in FilterListDialog to correct statusbar. r=jorgk DONTBUILD
authorRichard Marti <richard.marti@gmail.com>
Fri, 14 Dec 2018 10:04:09 +0100
changeset 33140 948685252daa
parent 33139 d1f5261143d4
child 33141 f5c4404b29d2
push id2368
push userclokep@gmail.com
push dateMon, 28 Jan 2019 21:12:50 +0000
treeherdercomm-beta@56d23c07d815 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorgk
bugs1514068
Bug 1514068 - Use IDs for correct rules selection in FilterListDialog to correct statusbar. r=jorgk DONTBUILD
mail/base/content/FilterListDialog.xul
mail/themes/linux/mail/filterDialog.css
mail/themes/osx/mail/filterDialog.css
mail/themes/windows/mail/filterDialog.css
--- a/mail/base/content/FilterListDialog.xul
+++ b/mail/base/content/FilterListDialog.xul
@@ -29,17 +29,17 @@
     <stringbundle id="bundle_filter" src="chrome://messenger/locale/filter.properties"/>
   </stringbundleset>
 
   <keyset>
     <key key="&closeCmd.key;" modifiers="accel" oncommand="if (onFilterClose()) window.close();"/>
     <key keycode="VK_ESCAPE" oncommand="if (onFilterClose()) window.close();"/>
   </keyset>
 
-  <hbox align="center">
+  <hbox id="filterHeader" align="center">
     <label value="&filtersForPrefix.label;"
            accesskey="&filtersForPrefix.accesskey;" control="serverMenu"/>
 
     <menulist id="serverMenu"
               class="folderMenuItem">
       <menupopup id="serverMenuPopup" type="folder" mode="filters"
                  class="menulist-menupopup"
                  expandFolders="nntp"
@@ -51,17 +51,17 @@
              class="searchBox"
              flex="1"
              type="search"
              oncommand="rebuildFilterList();"
              emptytext="&searchBox.emptyText;"
              isempty="true"/>
   </hbox>
 
-  <grid flex="1">
+  <grid id="filterListGrid" flex="1">
     <columns>
       <column flex="1"/>
       <column/>
     </columns>
     <rows>
       <row>
         <separator class="thin"/>
       </row>
--- a/mail/themes/linux/mail/filterDialog.css
+++ b/mail/themes/linux/mail/filterDialog.css
@@ -30,19 +30,19 @@ checkbox:not([label]) .checkbox-label-bo
   display: none;
 }
 
 #gray_horizontal_splitter {
   margin-right: -6px;
   margin-left: -6px;
 }
 
-#filterListDialog > hbox,
-#filterListDialog > grid {
-   margin: 8px 6px 0;
+#filterHeader,
+#filterListGrid {
+  margin: 8px 6px 0;
 }
 
 #FilterEditor {
   padding-right: 4px;
   padding-left: 4px;
 }
 
 .small-button {
--- a/mail/themes/osx/mail/filterDialog.css
+++ b/mail/themes/osx/mail/filterDialog.css
@@ -9,23 +9,23 @@
 @import url("chrome://messenger/skin/");
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 #filterListDialog {
   padding: 0px;
 }
 
-#filterListDialog > hbox {
-   margin: 8px;
-   font: menu;
+#filterHeader {
+  margin: 8px;
+  font: menu;
 }
 
-#filterListDialog > grid {
-   margin: 8px;
+#filterListGrid {
+  margin: 8px;
 }
 
 /* ::::: columns :::::: */
 
 treecolpicker {
   display: none;
 }
 
--- a/mail/themes/windows/mail/filterDialog.css
+++ b/mail/themes/windows/mail/filterDialog.css
@@ -30,19 +30,19 @@ checkbox:not([label]) .checkbox-label-bo
   display: none;
 }
 
 #gray_horizontal_splitter {
   margin-right: -6px;
   margin-left: -6px;
 }
 
-#filterListDialog > hbox,
-#filterListDialog > grid {
-   margin: 8px 6px 0;
+#filterHeader,
+#filterListGrid {
+  margin: 8px 6px 0;
 }
 
 #FilterEditor {
   padding-right: 4px;
   padding-left: 4px;
 }
 
 .small-button {