Bug 1610474 - Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled. r=aleca
authorRichard Marti <richard.marti@gmail.com>
Tue, 21 Jan 2020 13:00:13 +0100
changeset 37109 81cf5d6780d7f5312504d6749990093ac8df5a66
parent 37108 61106214bab978442d9db6b0d4d3a3e8969bf387
child 37110 5982cbb01992cef9509a340087303578550c90de
push id2552
push userclokep@gmail.com
push dateMon, 10 Feb 2020 21:24:16 +0000
treeherdercomm-beta@f95a6f4408a3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaleca
bugs1610474
Bug 1610474 - Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled. r=aleca
mail/base/content/menulist.css
mail/themes/linux/mail/menulist.css
mail/themes/windows/mail/menulist.css
--- a/mail/base/content/menulist.css
+++ b/mail/base/content/menulist.css
@@ -18,13 +18,8 @@ menulist html|*.textbox-input {
   -moz-appearance: none;
   background: transparent;
   -moz-box-flex: 1;
   margin: 0;
   border: none;
   padding: 0;
   font: inherit;
 }
-
-menulist[is="menulist-editable"][editable="true"][disabled="true"]
-  .menulist-dropmarker {
-  display: none !important;
-}
--- a/mail/themes/linux/mail/menulist.css
+++ b/mail/themes/linux/mail/menulist.css
@@ -6,19 +6,16 @@
 @namespace html url("http://www.w3.org/1999/xhtml");
 
 menulist html|*.textbox-input {
   padding: 2px 2px 3px;
 }
 
 menulist[is="menulist-editable"][editable="true"] {
   -moz-appearance: textfield;
-}
-
-menulist[is="menulist-editable"][editable="true"]:not([disabled]) {
   margin-inline-end: 2.4em;
 }
 
 menulist[is="menulist-editable"][editable="true"] .menulist-dropmarker {
   display: -moz-box;
   min-width: 2em;
   margin-top: -2px;
   margin-bottom: -2px;
--- a/mail/themes/windows/mail/menulist.css
+++ b/mail/themes/windows/mail/menulist.css
@@ -18,16 +18,32 @@ html|input.menulist-input {
   margin-inline-start: -2px;
   margin-inline-end: 3px;
   padding-top: 1px;
   padding-bottom: 1px;
   padding-inline-start: 3px;
   padding-inline-end: 0;
 }
 
+@media (-moz-os-version: windows-win7) and (-moz-windows-default-theme: 0) {
+  html|input.menulist-input {
+    margin-top: 0;
+    margin-bottom: 0;
+    margin-inline-start: 0;
+  }
+}
+
+@media (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0) {
+  html|input.menulist-input {
+    margin-top: -1px;
+    margin-bottom: -1px;
+    margin-inline-start: 0;
+  }
+}
+
 menulist[is="menulist-editable"][editable="true"] .menulist-dropmarker {
   display: -moz-box;
 }
 
 @media (-moz-windows-default-theme) {
   menulist[is="menulist-editable"][editable="true"] > .menulist-dropmarker {
     margin-inline-end: 0;
     margin-inline-start: 0;