Bug 1609928 - Fix pill colour of addresses retrieved via LDAP. r=mkmelin
authorAlessandro Castellani <alessandro@thunderbird.net>
Tue, 18 Feb 2020 12:52:55 -0800
changeset 37382 7a9663e64dc8fa84e4dc2d5c11918add1a5aa457
parent 37381 1c9f4fdf777217c65e8760abbc9d5ef6215927b9
child 37383 1d6c19070bffe7689241ac8e0612736bca76d484
push id2566
push userclokep@gmail.com
push dateMon, 09 Mar 2020 19:20:31 +0000
treeherdercomm-beta@a352facfa0a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin
bugs1609928
Bug 1609928 - Fix pill colour of addresses retrieved via LDAP. r=mkmelin
mail/base/content/mailWidgets.js
mail/themes/shared/mail/messengercompose.css
--- a/mail/base/content/mailWidgets.js
+++ b/mail/base/content/mailWidgets.js
@@ -1951,22 +1951,16 @@
         MailServices.ab.mailListNameExists(listNames[0].name);
       let isNewsgroup = this.emailInput.classList.contains("news-input");
 
       this.classList.toggle(
         "error",
         !isValid && !isMailingList && !isNewsgroup
       );
 
-      let emailCard = DisplayNameUtils.getCardForEmail(this.emailAddress);
-      this.classList.toggle(
-        "warning",
-        isValid && !emailCard.card && !isMailingList && !isNewsgroup
-      );
-
       this.style.removeProperty("max-width");
       this.style.removeProperty("min-width");
       this.classList.remove("editing");
       this.pillLabel.removeAttribute("hidden");
       this.emailInput.setAttribute("hidden", "hidden");
       this.rowInput.focus();
     }
 
@@ -2220,25 +2214,16 @@
         MailServices.ab.mailListNameExists(listNames[0].name);
       let isNewsgroup = element.classList.contains("news-input");
 
       pill.classList.toggle(
         "error",
         !isValidAddress(address.email) && !isMailingList && !isNewsgroup
       );
 
-      let emailCard = DisplayNameUtils.getCardForEmail(address.email);
-      pill.classList.toggle(
-        "warning",
-        isValidAddress(address.email) &&
-          !emailCard.card &&
-          !isMailingList &&
-          !isNewsgroup
-      );
-
       pill.addEventListener("click", event => {
         this.checkSelected(pill, event);
       });
       pill.addEventListener("dblclick", event => {
         this.startEditing(pill, event);
       });
       pill.addEventListener("keypress", event => {
         this.handleKeyPress(pill, event);
--- a/mail/themes/shared/mail/messengercompose.css
+++ b/mail/themes/shared/mail/messengercompose.css
@@ -586,40 +586,18 @@
   background-color: #3e0006;
 }
 
 #MsgHeadersToolbar[brighttext] .address-pill.error:hover:not(.editing),
 #MsgHeadersToolbar[brighttext] .address-pill.error:focus:not(.editing)  {
   background-color: #310005;
 }
 
-.address-pill.warning {
-  color: #a44900;
-  background-color: #fff2e5;
-}
-
-.address-pill.warning:hover:not(.editing),
-.address-pill.warning:focus:not(.editing) {
-  background-color: rgba(255,130,0,0.15);
-}
-
-#MsgHeadersToolbar[brighttext] .address-pill.warning:not(.editing) {
-  color: #fe7100;
-  background-color: #341700;
-}
-
-#MsgHeadersToolbar[brighttext] .address-pill.warning:hover:not(.editing),
-#MsgHeadersToolbar[brighttext] .address-pill.warning:focus:not(.editing)  {
-  background-color: #301500;
-}
-
 .address-pill[selected]:not(.editing),
 #MsgHeadersToolbar[brighttext] .address-pill[selected]:not(.editing),
-.address-pill.warning[selected]:not(.editing),
-#MsgHeadersToolbar[brighttext] .address-pill.warning[selected]:not(.editing),
 .address-pill.error[selected]:not(.editing),
 #MsgHeadersToolbar[brighttext] .address-pill.error[selected]:not(.editing) {
   color: HighlightText;
   background-color: Highlight;
 }
 
 .address-identity-recipient {
   margin-inline-end: 8px;