Bug 1411069 - Port bug 1313150, follow-up: Remove |weak| parameter from nsIMutableArray methods (ldap, suite). r=jorgk
authorEdmund Wong <ewong@pw-wspx.org>
Mon, 23 Oct 2017 20:03:00 +0200
changeset 29250 6f2de28da2f15e964cc0c587da7c9535de864c49
parent 29249 dd1d559aeb262e3aac32d5da7d2ff5b31e7b3079
child 29251 9c51e042d2393b706a07ae1dab53af663ed82787
push id2068
push userclokep@gmail.com
push dateMon, 13 Nov 2017 19:02:14 +0000
treeherdercomm-beta@9c7e7ce8672b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorgk
bugs1411069, 1313150
Bug 1411069 - Port bug 1313150, follow-up: Remove |weak| parameter from nsIMutableArray methods (ldap, suite). r=jorgk
ldap/xpcom/src/nsLDAPModification.cpp
suite/common/pref/pref-applications.js
--- a/ldap/xpcom/src/nsLDAPModification.cpp
+++ b/ldap/xpcom/src/nsLDAPModification.cpp
@@ -101,17 +101,17 @@ nsLDAPModification::SetValues(nsIArray* 
 
   nsCOMPtr<nsISupports> value;
 
   while (hasMoreElements)
   {
     rv = enumerator->GetNext(getter_AddRefs(value));
     NS_ENSURE_SUCCESS(rv, rv);
 
-    rv = mValues->AppendElement(value, false);
+    rv = mValues->AppendElement(value);
     NS_ENSURE_SUCCESS(rv, rv);
 
     rv = enumerator->HasMoreElements(&hasMoreElements);
     NS_ENSURE_SUCCESS(rv, rv);
   }
 
   return NS_OK;
 }
@@ -149,10 +149,10 @@ nsLDAPModification::SetUpModificationOne
 
   if (!mValues)
     mValues = do_CreateInstance(NS_ARRAY_CONTRACTID, &rv);
   else
     rv = mValues->Clear();
 
   NS_ENSURE_SUCCESS(rv, rv);
   
-  return mValues->AppendElement(aValue, false);
+  return mValues->AppendElement(aValue);
 }
--- a/suite/common/pref/pref-applications.js
+++ b/suite/common/pref/pref-applications.js
@@ -537,17 +537,17 @@ FeedHandlerInfo.prototype = {
       enumerate: function() {
         return new ArrayEnumerator(this._inner);
       },
 
       indexOf: function indexOf(startIndex, element) {
         return this._inner.indexOf(element, startIndex);
       },
 
-      appendElement: function(aHandlerApp, aWeak) {
+      appendElement: function(aHandlerApp) {
         this._inner.push(aHandlerApp);
       },
 
       removeElementAt: function(aIndex) {
         this._removed.push(this._inner[aIndex]);
         this._inner.splice(aIndex, 1);
       },