Bug 1416461 - Port bug 1416164 to TB: Replace NS_NOTYETIMPLEMENTED with MOZ_ASSERT_UNREACHABLE. r=aceman
authorRichard Marti <richard.marti@gmail.com>
Sat, 11 Nov 2017 11:50:54 +0100
changeset 29359 6c8dea328d6d4b6cac2785eb6065078f5b9a86c4
parent 29358 01a7133ca6641ea24393dbaa7e8265679d47b768
child 29360 5b6e551a23fb5004ca8ff16dcb5913abde78f33d
push id2068
push userclokep@gmail.com
push dateMon, 13 Nov 2017 19:02:14 +0000
treeherdercomm-beta@9c7e7ce8672b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaceman
bugs1416461, 1416164
Bug 1416461 - Port bug 1416164 to TB: Replace NS_NOTYETIMPLEMENTED with MOZ_ASSERT_UNREACHABLE. r=aceman
mailnews/base/src/nsMsgFolderDataSource.cpp
mailnews/base/src/nsSubscribeDataSource.cpp
mailnews/base/util/nsMsgIncomingServer.cpp
--- a/mailnews/base/src/nsMsgFolderDataSource.cpp
+++ b/mailnews/base/src/nsMsgFolderDataSource.cpp
@@ -543,25 +543,25 @@ nsMsgFolderDataSource::getFolderArcLabel
   aArcs.AppendObject(kNC_CanSearchMessages);
 
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsMsgFolderDataSource::GetAllResources(nsISimpleEnumerator** aCursor)
 {
-  NS_NOTYETIMPLEMENTED("sorry!");
+  MOZ_ASSERT_UNREACHABLE("sorry!");
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 nsMsgFolderDataSource::GetAllCmds(nsIRDFResource* source,
                                       nsISimpleEnumerator/*<nsIRDFResource>*/** commands)
 {
-  NS_NOTYETIMPLEMENTED("no one actually uses me");
+  MOZ_ASSERT_UNREACHABLE("no one actually uses me");
   nsresult rv;
 
   nsCOMPtr<nsIMsgFolder> folder(do_QueryInterface(source, &rv));
   if (NS_FAILED(rv)) return rv;
 
   nsCOMPtr<nsIMutableArray> cmds =
     do_CreateInstance(NS_ARRAY_CONTRACTID);
   NS_ENSURE_STATE(cmds);
--- a/mailnews/base/src/nsSubscribeDataSource.cpp
+++ b/mailnews/base/src/nsSubscribeDataSource.cpp
@@ -554,17 +554,17 @@ nsSubscribeDataSource::ArcLabelsOut(nsIR
     }
 
     return NS_NewArrayEnumerator(labels, array);
 }
 
 NS_IMETHODIMP
 nsSubscribeDataSource::GetAllResources(nsISimpleEnumerator** aCursor)
 {
-	NS_NOTYETIMPLEMENTED("sorry!");
+	MOZ_ASSERT_UNREACHABLE("sorry!");
 	return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 
 
 NS_IMETHODIMP
 nsSubscribeDataSource::AddObserver(nsIRDFObserver *n)
 {
--- a/mailnews/base/util/nsMsgIncomingServer.cpp
+++ b/mailnews/base/util/nsMsgIncomingServer.cpp
@@ -956,24 +956,24 @@ nsMsgIncomingServer::SetLocalPath(nsIFil
     rv = NS_OK;
   NS_ENSURE_SUCCESS(rv, rv);
   return SetFileValue("directory-rel", "directory", aLocalPath);
 }
 
 NS_IMETHODIMP
 nsMsgIncomingServer::GetLocalStoreType(nsACString& aResult)
 {
-  NS_NOTYETIMPLEMENTED("nsMsgIncomingServer superclass not implementing GetLocalStoreType!");
+  MOZ_ASSERT_UNREACHABLE("nsMsgIncomingServer superclass not implementing GetLocalStoreType!");
   return NS_ERROR_UNEXPECTED;
 }
 
 NS_IMETHODIMP
 nsMsgIncomingServer::GetLocalDatabaseType(nsACString& aResult)
 {
-  NS_NOTYETIMPLEMENTED("nsMsgIncomingServer superclass not implementing GetLocalDatabaseType!");
+  MOZ_ASSERT_UNREACHABLE("nsMsgIncomingServer superclass not implementing GetLocalDatabaseType!");
   return NS_ERROR_UNEXPECTED;
 }
 
 NS_IMETHODIMP
 nsMsgIncomingServer::GetAccountManagerChrome(nsAString& aResult)
 {
   aResult.AssignLiteral("am-main.xul");
   return NS_OK;