Bug 453979 - Remove nsIMsgIncomingServer.isSecureServer attribute as it is obsolete. r=dbienvenu
authoraceman <acelists@atlas.sk>
Mon, 05 Mar 2012 19:59:01 -0500
changeset 11006 4ce2a7788011405cfc641feadbd77ccf36c2c20f
parent 11005 dfe4636e667d1aa7a217173d90c06e0e2ae274cb
child 11007 b3925ea79358874ecfd0348c772cd1a7cfdd65db
push id463
push userbugzilla@standard8.plus.com
push dateTue, 24 Apr 2012 17:34:51 +0000
treeherdercomm-beta@e53588e8f7b0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbienvenu
bugs453979
Bug 453979 - Remove nsIMsgIncomingServer.isSecureServer attribute as it is obsolete. r=dbienvenu
mailnews/base/public/nsIMsgIncomingServer.idl
mailnews/base/util/nsMsgIncomingServer.cpp
mailnews/imap/src/nsImapIncomingServer.cpp
mailnews/imap/src/nsImapIncomingServer.h
mailnews/local/src/nsMovemailIncomingServer.cpp
mailnews/local/src/nsMovemailIncomingServer.h
--- a/mailnews/base/public/nsIMsgIncomingServer.idl
+++ b/mailnews/base/public/nsIMsgIncomingServer.idl
@@ -55,17 +55,17 @@ interface nsIURI;
 interface nsIMsgPluggableStore;
 
 /*
  * Interface for incoming mail/news host
  * this is the base interface for all mail server types (imap, pop, nntp, etc)
  * often you will want to add extra interfaces that give you server-specific
  * attributes and methods.
  */
-[scriptable, uuid(ad2637ee-6dac-4fc3-a1da-19394f66cbc2)]
+[scriptable, uuid(7e03bc94-4e09-4c48-bee0-19d0d60c6767)]
 interface nsIMsgIncomingServer : nsISupports {
 
   /**
    * internal pref key - guaranteed to be unique across all servers
    */
   attribute ACString key;
 
   /**
@@ -201,19 +201,16 @@ interface nsIMsgIncomingServer : nsISupp
   /**
    * Whether to SSL or STARTTLS or not
    *
    * @see nsMsgSocketType (in MailNewsTypes2.idl)
    * Same as "mail.server...socketType" pref
    */
   attribute nsMsgSocketTypeValue socketType;
 
-  /* dead code. */
-  readonly attribute boolean isSecureServer;
-
   /* empty trash on exit */
   attribute boolean emptyTrashOnExit;
 
   /**
    * Get the server's list of filters.
    *
    * This SHOULD be the same filter list as the root folder's, if the server
    * supports per-folder filters. Furthermore, this list SHOULD be used for all
--- a/mailnews/base/util/nsMsgIncomingServer.cpp
+++ b/mailnews/base/util/nsMsgIncomingServer.cpp
@@ -328,25 +328,16 @@ NS_IMETHODIMP
 nsMsgIncomingServer::GetCanEmptyTrashOnExit(bool *canEmptyTrashOnExit)
 {
   // derived class should override if they need to do this.
   NS_ENSURE_ARG_POINTER(canEmptyTrashOnExit);
   *canEmptyTrashOnExit = true;
   return NS_OK;
 }
 
-NS_IMETHODIMP
-nsMsgIncomingServer::GetIsSecureServer(bool *isSecureServer)
-{
-  // derived class should override if they need to do this.
-  NS_ENSURE_ARG_POINTER(isSecureServer);
-  *isSecureServer = true;
-  return NS_OK;
-}
-
 // construct <localStoreType>://[<username>@]<hostname
 NS_IMETHODIMP
 nsMsgIncomingServer::GetServerURI(nsACString& aResult)
 {
   nsresult rv;
   rv = GetLocalStoreType(aResult);
   NS_ENSURE_SUCCESS(rv, rv);
   aResult.AppendLiteral("://");
--- a/mailnews/imap/src/nsImapIncomingServer.cpp
+++ b/mailnews/imap/src/nsImapIncomingServer.cpp
@@ -2737,26 +2737,16 @@ nsImapIncomingServer::GetCanEmptyTrashOn
 {
   NS_ENSURE_ARG_POINTER(canEmptyTrashOnExit);
   // Initialize canEmptyTrashOnExit true, a default value for IMAP
   *canEmptyTrashOnExit = true;
   GetPrefForServerAttribute("canEmptyTrashOnExit", canEmptyTrashOnExit);
   return NS_OK;
 }
 
-NS_IMETHODIMP
-nsImapIncomingServer::GetIsSecureServer(bool *isSecureServer)
-{
-  NS_ENSURE_ARG_POINTER(isSecureServer);
-  // Initialize isSecureServer true, a default value for IMAP
-  *isSecureServer = true;
-  GetPrefForServerAttribute("isSecureServer", isSecureServer);
-  return NS_OK;
-}
-
 nsresult
 nsImapIncomingServer::CreateHostSpecificPrefName(const char *prefPrefix, nsCAutoString &prefName)
 {
   NS_ENSURE_ARG_POINTER(prefPrefix);
 
   nsCString hostName;
   nsresult rv = GetHostName(hostName);
   NS_ENSURE_SUCCESS(rv,rv);
--- a/mailnews/imap/src/nsImapIncomingServer.h
+++ b/mailnews/imap/src/nsImapIncomingServer.h
@@ -78,17 +78,16 @@ public:
   NS_IMETHOD PerformExpand(nsIMsgWindow *aMsgWindow);
   NS_IMETHOD CloseCachedConnections();
   NS_IMETHOD GetConstructedPrettyName(nsAString& retval);
   NS_IMETHOD GetCanBeDefaultServer(bool *canBeDefaultServer);
   NS_IMETHOD GetCanCompactFoldersOnServer(bool *canCompactFoldersOnServer);
   NS_IMETHOD GetCanUndoDeleteOnServer(bool *canUndoDeleteOnServer);
   NS_IMETHOD GetCanSearchMessages(bool *canSearchMessages);
   NS_IMETHOD GetCanEmptyTrashOnExit(bool *canEmptyTrashOnExit);
-  NS_IMETHOD GetIsSecureServer(bool *isSecureServer);
   NS_IMETHOD GetOfflineSupportLevel(PRInt32 *aSupportLevel);
   NS_IMETHOD GeneratePrettyNameForMigration(nsAString& aPrettyName);
   NS_IMETHOD GetSupportsDiskSpace(bool *aSupportsDiskSpace);
   NS_IMETHOD GetCanCreateFoldersOnServer(bool *aCanCreateFoldersOnServer);
   NS_IMETHOD GetCanFileMessagesOnServer(bool *aCanFileMessagesOnServer);
   NS_IMETHOD GetFilterScope(nsMsgSearchScopeValue *filterScope);
   NS_IMETHOD GetSearchScope(nsMsgSearchScopeValue *searchScope);
   NS_IMETHOD GetServerRequiresPasswordForBiff(bool *aServerRequiresPasswordForBiff);
--- a/mailnews/local/src/nsMovemailIncomingServer.cpp
+++ b/mailnews/local/src/nsMovemailIncomingServer.cpp
@@ -60,24 +60,16 @@ nsMovemailIncomingServer::nsMovemailInco
 {    
     m_canHaveFilters = true;
 }
 
 nsMovemailIncomingServer::~nsMovemailIncomingServer()
 {
 }
 
-NS_IMETHODIMP
-nsMovemailIncomingServer::GetIsSecureServer(bool *aIsSecureServer)
-{
-    NS_ENSURE_ARG_POINTER(aIsSecureServer);
-    *aIsSecureServer = false;
-    return NS_OK;
-}
-
 NS_IMETHODIMP 
 nsMovemailIncomingServer::PerformBiff(nsIMsgWindow *aMsgWindow)
 {
     nsresult rv;
     nsCOMPtr<nsIMovemailService> movemailService(do_GetService(
                                                  kCMovemailServiceCID, &rv));
     if (NS_FAILED(rv)) return rv;
     nsCOMPtr<nsIMsgFolder> inbox;
--- a/mailnews/local/src/nsMovemailIncomingServer.h
+++ b/mailnews/local/src/nsMovemailIncomingServer.h
@@ -53,17 +53,16 @@ class nsMovemailIncomingServer : public 
 public:
     NS_DECL_ISUPPORTS_INHERITED
     NS_DECL_NSIMOVEMAILINCOMINGSERVER
     NS_DECL_NSILOCALMAILINCOMINGSERVER
 
     nsMovemailIncomingServer();
     virtual ~nsMovemailIncomingServer();
 
-    NS_IMETHOD GetIsSecureServer(bool *aIsSecureServer);
     NS_IMETHOD PerformBiff(nsIMsgWindow *aMsgWindow);
     NS_IMETHOD GetDownloadMessagesAtStartup(bool *getMessages);
     NS_IMETHOD GetCanBeDefaultServer(bool *canBeDefaultServer);
     NS_IMETHOD GetCanSearchMessages(bool *canSearchMessages);
     NS_IMETHOD GetServerRequiresPasswordForBiff(bool *aServerRequiresPasswordForBiff);
     NS_IMETHOD GetAccountManagerChrome(nsAString& aResult);
 };