Bug 1366602 - Fix appearance issues on msgIdentity in editable mode. r=aceman
authorRichard Marti <richard.marti@gmail.com>
Sun, 21 May 2017 16:33:40 +0200
changeset 28239 4c24e9125fc97770564ad6c9d18340cc3ec2e71e
parent 28238 883c453aed1cc801919dde0ee4a2c54472c645cb
child 28240 2662981ddb0984098f4e74844ac7e973ac7fab80
push id1966
push userclokep@gmail.com
push dateMon, 12 Jun 2017 16:57:35 +0000
treeherdercomm-beta@32d9b8d10da1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaceman
bugs1366602
Bug 1366602 - Fix appearance issues on msgIdentity in editable mode. r=aceman
mail/components/compose/content/MsgComposeCommands.js
mail/themes/linux/mail/compose/messengercompose.css
mail/themes/osx/mail/compose/messengercompose.css
--- a/mail/components/compose/content/MsgComposeCommands.js
+++ b/mail/components/compose/content/MsgComposeCommands.js
@@ -4665,17 +4665,16 @@ function MakeFromFieldEditable(ignoreWar
           getComposeBundle().getString("customizeFromAddressIgnore"),
           check) != 0)
       return;
     Services.prefs.setBoolPref("mail.compose.warned_about_customize_from", check.value);
   }
 
   var customizeMenuitem = document.getElementById("cmd_customizeFromAddress");
   customizeMenuitem.setAttribute("disabled", "true");
-  customizeMenuitem.setAttribute("checked", "true");
   var identityElement = document.getElementById("msgIdentity");
   identityElement.removeAttribute("type");
   identityElement.editable = true;
   identityElement.focus();
   identityElement.value = identityElement.selectedItem.value;
   identityElement.select();
   identityElement.inputField.placeholder = getComposeBundle().getFormattedString("msgIdentityPlaceholder", [identityElement.selectedItem.value]);
 }
--- a/mail/themes/linux/mail/compose/messengercompose.css
+++ b/mail/themes/linux/mail/compose/messengercompose.css
@@ -469,26 +469,25 @@ treechildren::-moz-tree-image(subscribed
   -moz-border-left-colors: ThreeDShadow ThreeDHighlight;
 }
 
 #msgIdentity > .menulist-editable-box {
   -moz-appearance: none;
   padding-top: 0;
   padding-bottom: 0;
   padding-inline-start: 3px;
+  padding-inline-end: 12px;
   height: 1.4em;
+  background-repeat: no-repeat;
+  background-position: right;
+  background-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow.png");
 }
 
 #msgIdentity[editable="true"] > .menulist-dropmarker {
-  -moz-appearance: none;
-  display: -moz-box;
-  margin-inline-start: 4px;
-  border: none;
-  background: transparent;
-  list-style-image: url("chrome://messenger/skin/icons/toolbarbutton-arrow.png");
+  display: none;
 }
 
 /* ::::: format toolbar ::::: */
 
 #FormatToolbar {
   -moz-appearance: none;
   color: WindowText;
   margin-left: 3px;
--- a/mail/themes/osx/mail/compose/messengercompose.css
+++ b/mail/themes/osx/mail/compose/messengercompose.css
@@ -267,20 +267,33 @@ toolbar[brighttext] #button-print {
 }
 
 #msgIdentity:hover,
 #msgIdentity[focused="true"] {
   background-color: white;
   border-color: #C6C6C6;
 }
 
+#msgIdentity[editable="true"] {
+  padding-inline-end: 12px;
+}
+
 #msgIdentity > .menulist-editable-box {
   padding-inline-start: 3px;
 }
 
+#msgIdentity[editable="true"] > menupopup {
+  -moz-appearance: menupopup;
+  margin-inline-start: 0;
+}
+
+#msgIdentity[editable="true"] > menupopup > menuitem {
+  -moz-appearance: menuitem;
+}
+
 #addresses-box {
   margin: 4px 6px;
 }
 
 #attachments-box {
   padding-top: 5px;
 }