Bug 1516229 - Follow-up: Fix linting errors. r=me DONTBUILD
authorJorg K <jorgk@jorgk.com>
Sat, 05 Jan 2019 00:14:20 +0100
changeset 33264 49c5d6324673
parent 33263 150da20417f3
child 33265 49f231df7030
push id2368
push userclokep@gmail.com
push dateMon, 28 Jan 2019 21:12:50 +0000
treeherdercomm-beta@56d23c07d815 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1516229
Bug 1516229 - Follow-up: Fix linting errors. r=me DONTBUILD
mail/components/accountcreation/content/accountConfig.js
mail/components/accountcreation/content/emailWizard.js
--- a/mail/components/accountcreation/content/accountConfig.js
+++ b/mail/components/accountcreation/content/accountConfig.js
@@ -191,17 +191,17 @@ AccountConfig.prototype =
   addons: null,
 
   /**
    * Returns a deep copy of this object,
    * i.e. modifying the copy will not affect the original object.
    */
   copy() {
     // Workaround: deepCopy() fails to preserve base obj (instanceof)
-    var result = new AccountConfig();
+    let result = new AccountConfig();
     for (let prop in this) {
       result[prop] = deepCopy(this[prop]);
     }
 
     return result;
   },
 
   isComplete() {
@@ -255,45 +255,45 @@ AccountConfig.prototype =
         default:
           return "invalid";
       }
     }
     function usernameToString(username) {
       if (!username) {
         return "undefined";
       }
-      var domain = username.split("@")[1];
+      let domain = username.split("@")[1];
       return domain ? "(redacted)@" + domain : "(redacted)";
     }
     function passwordToString(password) {
       return password ? "set" : "not set";
     }
     function configToString(config) {
       return config.type +
       ", " + config.hostname + ":" + config.port +
       ", " + sslToString(config.socketType) +
       ", auth: " + authToString(config.auth) +
-       ", username: "+ usernameToString(config.username) +
-      ", password: "+ passwordToString(config.password);
+       ", username: " + usernameToString(config.username) +
+      ", password: " + passwordToString(config.password);
     }
 
-    var result =
+    let result =
       "Incoming: " + configToString(this.incoming) +
       "\nOutgoing: ";
     if (this.outgoing.useGlobalPreferredServer) {
       result += "Use global server";
     } else if (this.outgoing.existingServerKey) {
       result += "Use existing server " + this.outgoing.existingServerKey;
     } else {
       result += configToString(this.outgoing);
     }
-    for (var config of this.incomingAlternatives) {
+    for (let config of this.incomingAlternatives) {
       result += "\nIncoming alt: " + configToString(config);
     }
-    for (var config of this.outgoingAlternatives) {
+    for (let config of this.outgoingAlternatives) {
       result += "\nOutgoing alt: " + configToString(config);
     }
     return result;
   },
 };
 
 
 // enum consts
--- a/mail/components/accountcreation/content/emailWizard.js
+++ b/mail/components/accountcreation/content/emailWizard.js
@@ -34,17 +34,16 @@ ChromeUtils.import("resource:///modules/
 // from http://xyfer.blogspot.com/2005/01/javascript-regexp-email-validator.html
 var emailRE = /^[-_a-z0-9\'+*$^&%=~!?{}]+(?:\.[-_a-z0-9\'+*$^&%=~!?{}]+)*@(?:[-a-z0-9.]+\.[a-z]{2,20}|\d{1,3}(?:\.\d{1,3}){3})(?::\d+)?$/i;
 
 if (typeof gEmailWizardLogger == "undefined") {
   ChromeUtils.import("resource:///modules/gloda/log4moz.js");
   var gEmailWizardLogger = Log4Moz.getConfiguredLogger("mail.setup");
   gEmailWizardLogger.level = Log4Moz.Level.Info;
   gEmailWizardLogger.addAppender(new Log4Moz.ConsoleAppender(new Log4Moz.BasicFormatter())); // browser console
-  //gEmailWizardLogger.addAppender(new Log4Moz.DumpAppender(new Log4Moz.BasicFormatter())); // stdout
 }
 
 var gStringsBundle;
 var gMessengerBundle;
 var gBrandShortName;
 
 /**
 TODO for bug 549045: