Bug 1496523 - Remove nodejs requirement for building source package. r=tomprince a=jorgk THUNDERBIRD_64_0b1_BUILD2 THUNDERBIRD_64_0b1_RELEASE
authorRob Lemley <rob@thunderbird.net>
Thu, 04 Oct 2018 20:42:01 +0000
changeset 32611 3341bdccc3d916172959a1f8860a5884b687fa3a
parent 32610 cf8ea6ca4029cef21ed8ffaef286a0b4dc7efd53
child 32612 a1bfa6462906f08fd9163fe7341ab18985f8683e
push id2328
push usermozilla@jorgk.com
push dateThu, 25 Oct 2018 20:43:16 +0000
treeherdercomm-beta@3341bdccc3d9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstomprince, jorgk
bugs1496523
Bug 1496523 - Remove nodejs requirement for building source package. r=tomprince a=jorgk The generated .mozconfig file for building the source tarball will require nodejs to be present. Firefox has included in their mozconfig for source builds: ac_add_options --disable-nodejs Differential Revision: https://phabricator.services.mozilla.com/D7788
mail/config/mozconfigs/linux64/source
--- a/mail/config/mozconfigs/linux64/source
+++ b/mail/config/mozconfigs/linux64/source
@@ -1,6 +1,11 @@
 . "$topsrcdir/comm/mail/config/mozconfigs/common"
 
 # The source "build" only needs a mozconfig because we use the build system as
 # our script for generating it. This allows us to run configure without any
 # extra dependencies on specific toolchains, e.g. gtk3.
 . "$topsrcdir/build/mozconfig.no-compile"
+
+# mozconfig.no-compile does not remove nodejs requirement.
+# The source mozconfig for FF includes the following:
+ac_add_options --disable-nodejs
+unset NODEJS