Bug 1410745 - Fix spacing between attachment items in attachment bucket. r=jorgk
authorRichard Marti <richard.marti@gmail.com>
Tue, 24 Oct 2017 22:04:21 +0200
changeset 29259 260d49e11c293cc9f25b0b5636fa9c2ca8d69508
parent 29258 7dce0721e6b6745002757e1ce9041651a282a80e
child 29260 e0e10be130649451458173cf39ba0cbfc6697e1e
push id2068
push userclokep@gmail.com
push dateMon, 13 Nov 2017 19:02:14 +0000
treeherdercomm-beta@9c7e7ce8672b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorgk
bugs1410745
Bug 1410745 - Fix spacing between attachment items in attachment bucket. r=jorgk
mail/themes/linux/mail/compose/messengercompose.css
mail/themes/osx/mail/compose/messengercompose.css
mail/themes/windows/mail/attachmentList.css
mail/themes/windows/mail/compose/messengercompose.css
--- a/mail/themes/linux/mail/compose/messengercompose.css
+++ b/mail/themes/linux/mail/compose/messengercompose.css
@@ -14,16 +14,20 @@
   width: 15em;
   min-width: 15em;
 }
 
 #attachmentBucket:focus {
   box-shadow: 0 0 2px Highlight inset, 0 0 2px Highlight inset;
 }
 
+#attachmentBucket > scrollbox > .scrollbox-innerbox {
+  padding: 1px;
+}
+
 #compose-toolbox {
   -moz-appearance: none;
   background-color: var(--toolbar-bgcolor);
   border-bottom: 1px solid ThreeDShadow;
 }
 
 #compose-toolbox:-moz-lwtheme {
   background-color: var(--toolbar-bgcolor);
--- a/mail/themes/osx/mail/compose/messengercompose.css
+++ b/mail/themes/osx/mail/compose/messengercompose.css
@@ -20,16 +20,20 @@
   width: 15em;
   min-width: 15em;
 }
 
 #attachmentBucket:focus {
   box-shadow: 0 0 1.5px 1px -moz-mac-focusring inset;
 }
 
+#attachmentBucket > scrollbox > .scrollbox-innerbox {
+  padding: 1px;
+}
+
 #compose-toolbox toolbarbutton[checked="true"] {
   background-color: transparent;
 }
 
 /* Inactive window state */
 #compose-toolbox > toolbar:-moz-window-inactive {
   border-top-color: rgba(255,255,255,0.45);
   border-bottom-color: rgba(0,0,0,0.35);
--- a/mail/themes/windows/mail/attachmentList.css
+++ b/mail/themes/windows/mail/attachmentList.css
@@ -46,95 +46,101 @@ attachmentlist:focus > attachmentitem[se
 }
 
 attachmentlist:focus > attachmentitem[selected="true"] .attachmentcell-icon {
   filter: url("chrome://messenger/skin/imageFilters.svg#selected-focus");
 }
 
 @media (-moz-windows-default-theme) {
   attachmentitem {
-    margin: 1px 0 0 0;
     pointer-events: auto !important;
     border: 2px solid transparent;
     color: -moz-FieldText;
     background-color: transparent;
     background-repeat: no-repeat;
     background-size: 100% 100%;
   }
 
   .attachmentlist-wrapper {
-    margin: 0 1px 1px 0;
+    margin-inline-end: 1px;
+    margin-bottom: 1px;
   }
 
   attachmentlist[orient="horizontal"] > attachmentitem {
-    margin: 1px 0 0 1px;
+    margin-top: 1px;
+    margin-inline-start: 1px;
   }
 
   .attachmentcell-nameselection {
     outline: none !important;
     background-color: inherit !important;
     color: inherit !important;
   }
 
   .attachmentcell-icon {
     filter: none !important;
     padding: 0 1px;
   }
 
   .attachmentcell-name, .attachmentcell-size {
-    margin: 0px 4px 0px 4px;
+    margin: 0 4px;
   }
 
   attachmentitem[selected="true"] {
-    -moz-border-top-colors: rgb(217, 217, 217) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(217, 217, 217) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(217, 217, 217) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(217, 217, 217) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(217, 217, 217) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(217, 217, 217) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(217, 217, 217) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(217, 217, 217) rgba(255, 255, 255, .6);
   }
 
   attachmentitem[selected="true"]:hover {
-    -moz-border-top-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255, 255, 255, .6);
   }
 
   attachmentlist:focus > attachmentitem[current="true"] {
     -moz-border-top-colors: rgb(125, 162, 206) transparent;
     -moz-border-right-colors: rgb(125, 162, 206) transparent;
     -moz-border-left-colors: rgb(125, 162, 206) transparent;
     -moz-border-bottom-colors: rgb(125, 162, 206) transparent;
   }
 
   attachmentlist:focus > attachmentitem[current="true"]:hover {
-    -moz-border-top-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255, 255, 255, .6);
   }
 
   attachmentlist:focus > attachmentitem[selected="true"] {
-    -moz-border-top-colors: rgb(132, 172, 221) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(132, 172, 221) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(132, 172, 221) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(132, 172, 221) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(132, 172, 221) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(132, 172, 221) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(132, 172, 221) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(132, 172, 221) rgba(255, 255, 255, .6);
   }
 
   attachmentlist:focus > attachmentitem[selected="true"][current="true"] {
-    -moz-border-top-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(125, 162, 206) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(125, 162, 206) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(125, 162, 206) rgba(255, 255, 255, .6);
   }
 
   attachmentitem:hover {
-    -moz-border-top-colors: rgb(184, 214, 251) rgba(255,255,255,.4);
-    -moz-border-right-colors: rgb(184, 214, 251) rgba(255,255,255,.4);
-    -moz-border-left-colors: rgb(184, 214, 251) rgba(255,255,255,.4);
-    -moz-border-bottom-colors: rgb(184, 214, 251) rgba(255,255,255,.6);
+    -moz-border-top-colors: rgb(184, 214, 251) rgba(255, 255, 255, .4);
+    -moz-border-right-colors: rgb(184, 214, 251) rgba(255, 255, 255, .4);
+    -moz-border-left-colors: rgb(184, 214, 251) rgba(255, 255, 255, .4);
+    -moz-border-bottom-colors: rgb(184, 214, 251) rgba(255, 255, 255, .6);
+  }
+
+  #attachmentBucket:focus > attachmentitem[selected="true"] +
+    attachmentitem[selected="true"] {
+    -moz-border-top-colors: rgba(131, 183, 249, 0.375) rgba(255, 255, 255, .4);
   }
 }
 
 @media (-moz-os-version: windows-win7) and (-moz-windows-default-theme) {
   attachmentitem {
     border-radius: 3px;
   }
 
--- a/mail/themes/windows/mail/compose/messengercompose.css
+++ b/mail/themes/windows/mail/compose/messengercompose.css
@@ -19,16 +19,20 @@
   background-color: -moz-Field;
   color: -moz-FieldText;
 }
 
 #attachmentBucket:focus {
   box-shadow: 0 0 1px Highlight inset, 0 0 1px Highlight inset;
 }
 
+#attachmentBucket > scrollbox > .scrollbox-innerbox {
+  padding: 1px;
+}
+
 /* ::::: special toolbar colors ::::: */
 
 #composeContentBox {
   -moz-appearance: none;
   color: -moz-dialogtext;
   background-color: -moz-Dialog;
   box-shadow: 0px 2px 4px rgba(0, 0, 0, 0.4) inset;
   /*