Bug 921371 - Allow the user to continue using Account manager even if Local directory is deemed unsafe. r=mkmelin
authoraceman <acelists@atlas.sk>
Tue, 12 Nov 2013 17:07:37 -0500
changeset 16891 1f9de62b2409405e87fd6616cfd7c3cb8730d42f
parent 16890 40c8cff67dc6f45d35a417f052c52fece0455362
child 16892 97eeebff7f37793f0ff0957899baa44bf90ddee8
push id1074
push userbugzilla@standard8.plus.com
push dateMon, 03 Feb 2014 22:47:23 +0000
treeherdercomm-beta@6b791b5369ed [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmkmelin
bugs921371
Bug 921371 - Allow the user to continue using Account manager even if Local directory is deemed unsafe. r=mkmelin
mailnews/base/prefs/content/AccountManager.js
--- a/mailnews/base/prefs/content/AccountManager.js
+++ b/mailnews/base/prefs/content/AccountManager.js
@@ -580,18 +580,22 @@ function checkUserServerChanges(showAler
         Services.prompt.alert(window, alertTitle, changeText.trim());
     }
   }
 
   // Check the new value of the server.localPath field for validity.
   for (let i = 0; i < pageElements.length; i++) {
     if (pageElements[i].id) {
       if (pageElements[i].id == "server.localPath") {
-        if (!checkDirectoryIsUsable(getFormElementValue(pageElements[i])))
-          return false;
+        if (!checkDirectoryIsUsable(getFormElementValue(pageElements[i]))) {
+//          return false; // Temporarily disable this. Just show warning but do not block. See bug 921371.
+          Components.utils.reportError("Local directory '" +
+            getFormElementValue(pageElements[i]).path + "' of account " +
+            currentAccount.key + " is not safe to use. Consider changing it.");
+        }
         break;
       }
     }
   }
 
   // Warn if the Local directory path was changed.
   // This can be removed once bug 2654 is fixed.
   let oldLocalDir = null;