Bug 741062. (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey. r=Neil a=Callek
authorSerge Gautherie <sgautherie.bz@free.fr>
Tue, 03 Apr 2012 08:52:00 -0400
changeset 11206 073883460c394f86479f0241ac366bda3e002edb
parent 11205 d823f490fccb58a5258efbb3e738fe48442656f1
child 11207 88e93158d754dd33ebc469b7396dafc16f152acc
push id463
push userbugzilla@standard8.plus.com
push dateTue, 24 Apr 2012 17:34:51 +0000
treeherdercomm-beta@e53588e8f7b0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersNeil, Callek
bugs741062, 741065
Bug 741062. (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey. r=Neil a=Callek
suite/common/places/controller.js
--- a/suite/common/places/controller.js
+++ b/suite/common/places/controller.js
@@ -1498,17 +1498,17 @@ let PlacesControllerDragHelper = {
     let doCopy = ["copy", "link"].indexOf(dt.dropEffect) != -1;
 
     let transactions = [];
     let dropCount = dt.mozItemCount;
     let movedCount = 0;
     for (let i = 0; i < dropCount; ++i) {
       let flavor = this.getFirstValidFlavor(dt.mozTypesAt(i));
       if (!flavor)
-        return false;
+        return;
 
       let data = dt.mozGetDataAt(flavor, i);
       let unwrapped;
       if (flavor != TAB_DROP_TYPE) {
         // There's only ever one in the D&D case.
         unwrapped = PlacesUtils.unwrapNodes(data, flavor)[0];
       }
       else if (data instanceof XULElement && data.localName == "tab" &&