Bug 1597589 - Port bug 1594344: Use win64-dump-syms toolchain. r=darktrojan
authorRob Lemley <rob@thunderbird.net>
Mon, 18 Nov 2019 21:58:53 -0500
changeset 37069 02de390c9d938e00cbd6fb4cb4d515964f0ccd98
parent 37068 b4ec98d231cdd833486338c60b66aa4050070a38
child 37070 ac3819169b5030145fee3d92c7f120e0423c20e5
push id2552
push userclokep@gmail.com
push dateMon, 10 Feb 2020 21:24:16 +0000
treeherdercomm-beta@f95a6f4408a3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdarktrojan
bugs1597589, 1594344
Bug 1597589 - Port bug 1594344: Use win64-dump-syms toolchain. r=darktrojan Use the Rust-based dump_syms for Windows builds.
taskcluster/ci/build/windows.yml
taskcluster/ci/toolchain/kind.yml
--- a/taskcluster/ci/build/windows.yml
+++ b/taskcluster/ci/build/windows.yml
@@ -5,16 +5,24 @@
 job-defaults:
     run:
         using: mozharness
         use-caches: false
         comm-checkout: true
         config-paths:
             - comm/mozharness
         tooltool-downloads: internal
+    fetches:
+        toolchain:
+            - win64-cbindgen
+            - win64-clang-cl
+            - win64-dump-syms
+            - win64-nasm
+            - win64-node
+            - win64-rust
 
 win32/opt:
     description: "Win32 Opt"
     index:
         product: thunderbird
         job-name: win32-opt
     attributes:
         enable-build-signing: true
@@ -34,21 +42,16 @@ win32/opt:
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win32.py
         extra-config:
             stage_platform: win32
     fetches:
         toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
             - win64-sccache
 
 win32-shippable/opt:
     description: "Win32 Opt Shippable"
     index:
         product: thunderbird
         job-name: win32-opt
         type: shippable
@@ -74,23 +77,16 @@ win32-shippable/opt:
         script: mozharness/scripts/fx_desktop_build.py
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win32.py
             - taskcluster_nightly.py
         extra-config:
             stage_platform: win32
-    fetches:
-        toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
 
 win32/debug:
     description: "Win32 Debug"
     index:
         product: thunderbird
         job-name: win32-debug
     attributes:
         enable-build-signing: true
@@ -110,21 +106,16 @@ win32/debug:
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win32.py
             - builds/taskcluster_sub_win32/debug.py
         mozconfig-variant: debug
     fetches:
         toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
             - win64-sccache
 
 win64/opt:
     description: "Win64 Opt"
     index:
         product: thunderbird
         job-name: win64-opt
     attributes:
@@ -145,21 +136,16 @@ win64/opt:
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win64.py
         extra-config:
             stage_platform: win64
     fetches:
         toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
             - win64-sccache
 
 win64-shippable/opt:
     description: "Win64 Opt Shippable"
     index:
         product: thunderbird
         job-name: win64-opt
         type: shippable
@@ -185,23 +171,16 @@ win64-shippable/opt:
         script: mozharness/scripts/fx_desktop_build.py
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win64.py
             - taskcluster_nightly.py
         extra-config:
             stage_platform: win64
-    fetches:
-        toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
 
 win64/debug:
     description: "Win64 Debug"
     index:
         product: thunderbird
         job-name: win64-debug
     attributes:
         enable-build-signing: true
@@ -221,14 +200,9 @@ win64/debug:
         config:
             - builds/taskcluster_base_thunderbird.py
             - builds/taskcluster_base_windows.py
             - builds/taskcluster_base_win64.py
             - builds/taskcluster_sub_win64/debug.py
         mozconfig-variant: debug
     fetches:
         toolchain:
-            - win64-cbindgen
-            - win64-clang-cl
-            - win64-nasm
-            - win64-node
-            - win64-rust
             - win64-sccache
--- a/taskcluster/ci/toolchain/kind.yml
+++ b/taskcluster/ci/toolchain/kind.yml
@@ -30,13 +30,14 @@ jobs:
     - linux64-rust-macos
     - linux64-sccache
     - linux64-upx
     - macosx64-node
     - wasi-sysroot
     - win32-node
     - win64-cbindgen
     - win64-clang-cl
+    - win64-dump-syms
     - win64-nasm
     - win64-node
     - win64-rust
     - win64-rust-1.39
     - win64-sccache