bdf1f37adbac616743c572d17418b394c77dcf82: No bug - Tagging 195a2aef72e1ab507c07ca93e703600b4b09c3b3 with THUNDERBIRD_65_0b1_BUILD5, THUNDERBIRD_65_0b1_RELEASE a=release CLOSED TREE
Mozilla Releng Treescript <release+treescript@mozilla.org> - Mon, 31 Dec 2018 23:39:13 +0000 - rev 33062
Push 2356 by tbirdbld at Mon, 31 Dec 2018 23:39:20 +0000
No bug - Tagging 195a2aef72e1ab507c07ca93e703600b4b09c3b3 with THUNDERBIRD_65_0b1_BUILD5, THUNDERBIRD_65_0b1_RELEASE a=release CLOSED TREE
636f744e5be4cc85e4c8438b8b87dbe5c3e8beee: Bug 1427317 - Follow-up: Rename currentEngine to defaultEngine (see bug 1510936). r+a=me DONTBUILD
Jorg K <jorgk@jorgk.com> - Mon, 31 Dec 2018 20:39:39 +0100 - rev 33061
Push 2355 by mozilla@jorgk.com at Mon, 31 Dec 2018 19:41:10 +0000
Bug 1427317 - Follow-up: Rename currentEngine to defaultEngine (see bug 1510936). r+a=me DONTBUILD
0fc0c5dd8de5573e8951af5e00fa6ed821f66670: Bug 1427317 - Allow addition of search engines from XML file and removal in general pane in preferences. r=Paenglab a=jorgk
Jorg K <jorgk@jorgk.com> - Tue, 02 Jan 2018 18:25:13 +0100 - rev 33060
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1427317 - Allow addition of search engines from XML file and removal in general pane in preferences. r=Paenglab a=jorgk
faa09be420d4aed29c76d18636af23e5184f9882: Bug 1516450 - Distinguish between hovered and selected tree items with dark theme. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Wed, 26 Dec 2018 19:25:12 +0100 - rev 33059
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516450 - Distinguish between hovered and selected tree items with dark theme. r+a=jorgk
8432e7fd9626148b3787ccc429a28588079a21bf: Bug 1516509 - add undisclosed-recipients when queueing message. r=aceman a=jorgk
Jorg K <jorgk@jorgk.com> - Fri, 28 Dec 2018 10:31:24 +0100 - rev 33058
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516509 - add undisclosed-recipients when queueing message. r=aceman a=jorgk
81e801fbbdbd9df6bc9c8a52db95e697179263b8: Bug 1516320 - Follow-up: Initialise IsQP member variable where appropriate. r=darktrojan a=jorgk
Jorg K <jorgk@jorgk.com> - Thu, 27 Dec 2018 09:59:00 +0100 - rev 33057
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516320 - Follow-up: Initialise IsQP member variable where appropriate. r=darktrojan a=jorgk
e61569181ade20e11058207d79b10ee4647f45de: Bug 1516320 - Fix body search for QP-encoded messages using ISO-2022-JP. r=darktrojan a=jorgk
Jorg K <jorgk@jorgk.com> - Wed, 26 Dec 2018 22:56:53 +0100 - rev 33056
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516320 - Fix body search for QP-encoded messages using ISO-2022-JP. r=darktrojan a=jorgk
a69547fa6bb2c84e2f450944981db81d82752cf5: Bug 1516501 - Bug 1333038 follow-up: Convert forgotten use of nsMsgLineStreamBuffer to 'modern' pointer. r=darktrojan a=jorgk
Jorg K <jorgk@jorgk.com> - Fri, 28 Dec 2018 22:09:31 +0100 - rev 33055
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516501 - Bug 1333038 follow-up: Convert forgotten use of nsMsgLineStreamBuffer to 'modern' pointer. r=darktrojan a=jorgk
9bbb544328750cbd12329a726ccc85bde15ac846: Bug 1514993 - Resolve overlays' script/stylesheet references relative to the overlay; r+a=Fallen
Geoff Lankow <geoff@darktrojan.net> - Mon, 31 Dec 2018 12:17:45 +1300 - rev 33054
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1514993 - Resolve overlays' script/stylesheet references relative to the overlay; r+a=Fallen
8b4c9d319ddbade1ba70963fe7acb8416dccd99e: Bug 1516287 - Wait for stylesheet to load before adding category colours. r+a=philipp
Geoff Lankow <geoff@darktrojan.net> - Wed, 26 Dec 2018 10:55:59 +1300 - rev 33053
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 1516287 - Wait for stylesheet to load before adding category colours. r+a=philipp
8e53a70093a9727303bed0bba44eb795a981cc54: Bug 734966 - Fix "snooze all" button on Mac; r+a=Fallen
Geoff Lankow <geoff@darktrojan.net> - Mon, 31 Dec 2018 12:15:55 +1300 - rev 33052
Push 2354 by mozilla@jorgk.com at Mon, 31 Dec 2018 16:53:09 +0000
Bug 734966 - Fix "snooze all" button on Mac; r+a=Fallen
84b08b96490f60725939d82ba4177d908e358554: Bug 1511943 - Follow-up: always notify WebExtensions framework about this browser, as it might get reused later; rs=me a=jorgk DONTBUILD
Geoff Lankow <geoff@darktrojan.net> - Tue, 18 Dec 2018 19:25:19 +1300 - rev 33051
Push 2353 by mozilla@jorgk.com at Sun, 30 Dec 2018 22:57:45 +0000
Bug 1511943 - Follow-up: always notify WebExtensions framework about this browser, as it might get reused later; rs=me a=jorgk DONTBUILD
195a2aef72e1ab507c07ca93e703600b4b09c3b3: Backed out 4 changesets (bug 1514522, bug 1500105, bug 1511571, bug 1515903) for breaking account creation, bug 1516134. a=backout THUNDERBIRD_65_0b1_BUILD5 THUNDERBIRD_65_0b1_RELEASE
Jorg K <jorgk@jorgk.com> - Sat, 22 Dec 2018 21:56:21 +0100 - rev 33050
Push 2352 by mozilla@jorgk.com at Sat, 22 Dec 2018 20:57:02 +0000
Backed out 4 changesets (bug 1514522, bug 1500105, bug 1511571, bug 1515903) for breaking account creation, bug 1516134. a=backout Backed out changeset 44241fb0b162 (bug 1514522) Backed out changeset 886ee22a3f85 (bug 1515903) Backed out changeset dacb68554465 (bug 1511571) Backed out changeset 60a1cefdf2af (bug 1500105)
ffdb14a414dd1a326a85870b100f442e0a58de0a: No bug - Pin mozilla-beta version (rev 93e2cfcc400d, FIREFOX_65_0b6 plus bug 1515504) for release. a=jorgk
Jorg K <jorgk@jorgk.com> - Fri, 21 Dec 2018 21:52:48 +0100 - rev 33049
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
No bug - Pin mozilla-beta version (rev 93e2cfcc400d, FIREFOX_65_0b6 plus bug 1515504) for release. a=jorgk
61f7be1b30e13797c65b4313c40e6f56abe2251d: Bug 1514951 - Fix filter creation from subject header. r=arshad a=jorgk
Magnus Melin <mkmelin+mozilla@iki.fi> - Wed, 19 Dec 2018 12:30:03 +0200 - rev 33048
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1514951 - Fix filter creation from subject header. r=arshad a=jorgk
994a012451923d399d70cb0b00cb63146e2ac312: Bug 1512581 - Match original behaviour of insertbefore/insertafter attributes; r=Fallen a=jorgk
Geoff Lankow <geoff@darktrojan.net> - Fri, 21 Dec 2018 22:27:05 +1300 - rev 33047
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1512581 - Match original behaviour of insertbefore/insertafter attributes; r=Fallen a=jorgk
44241fb0b16211fe4e3cbe66c7689e9c742e9730: Bug 1514522 - remove link to 3rd party site for account type add-ons. r+a=jorgk
Magnus Melin <mkmelin+mozilla@iki.fi> - Sat, 15 Dec 2018 23:16:41 +0200 - rev 33046
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1514522 - remove link to 3rd party site for account type add-ons. r+a=jorgk
886ee22a3f85d1a7f55c7fa1e5813470be99d88a: Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 21 Dec 2018 15:44:48 +0100 - rev 33045
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk Bug 1514628 changed the icon URL from http: to data:image/png;. However, data: URLs are forbidden, so the addon doesn't show up at all. data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs. However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain code. Then again, SVG can contain JS and must be forbidden. This change opens this up a little bit, allowing specifically PNG and JPEG image data: URLs, and only those. That allows icons to be inline.
dacb68554465e5daf329f5f9502932c0bd5f62af: Bug 1511571 - [autoconfig] Make domain bold. r=aceman a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33044
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1511571 - [autoconfig] Make domain bold. r=aceman a=jorgk To allow the user to more easily make secure decisions, we should make the second level domain of the hostname bold. E.g. for imap.mail.yahoo.com, we should make "yahoo.com" bold. Test Plan: IMAP config display: 1. Enter foo@yahoo.com 2. Click [Continue] 3. -> You see "Incoming: IMAP imap.mail.yahoo.com SSL" 4. -> whereas "yahoo.com" is bold Exchange config display: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> You see e.g. "Exchange server: mail.outlook.com" 5. -> whereas "outlook.com" is bold Insecure IMAP config display: 1. Enter foo@alice.it 2. Click [Continue] 3. -> You see "Incoming: IMAP in.alice.it No encryption" 4. -> whereas "alice.it" is bold 5. -> whereas "No encryption" is red Differential Revision: https://phabricator.services.mozilla.com/D13606
60a1cefdf2afe240abc3558542a8237276e7f000: Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33043
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk Summary: * Parallelize network calls * Exchange AutoDiscover protocol implementation * Try to find IMAP servers in the server response * Offer to install an extension which supports the Exchange protocol to get mails Runs all the ISP config lookup network calls in parallel. Class PriorityOrderAbortable (subclass of ParallelAbortable) implements a policy that waits until one of the calls returns successfully, then takes that result and cancels all pending less desirable calls. Implements the Exchange AutoDiscover protocol to detect Exchange servers. If the server gives an IMAP configuration, we offer that to the user. Alternatively, we offer a compatible verified extension that implements the specific Exchange protocol that the Exchange server returned. Exchange has at least 7 protocols, and we show extensions that support the protocols that the server listed and that are known to work well and actively maintained. The setup process then continues without interruption. Test plan: Exchange autoconfig: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> TB should find an Exchange server with hostname 5. -> TB will offer you to install an extension that supports this protocol type, with explanatory text and a link 6. Click [Install] 7. -> The password is checked, the dialog closes, and the account appears, and your emails are downloaded. Parallel network calls: 1. Open account creation dialog 2. Enter "foo@gmail.com", "foo@yahoo.com", "foo@sys4.de", "foo@example.com", or any other domain 3. -> It works functionally as before, see https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Autoconfiguration 4. -> It's faster than before Differential Revision: https://phabricator.services.mozilla.com/D9215
(0) -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip