195a2aef72e1ab507c07ca93e703600b4b09c3b3: Backed out 4 changesets (bug 1514522, bug 1500105, bug 1511571, bug 1515903) for breaking account creation, bug 1516134. a=backout THUNDERBIRD_65_0b1_BUILD5 THUNDERBIRD_65_0b1_RELEASE
Jorg K <jorgk@jorgk.com> - Sat, 22 Dec 2018 21:56:21 +0100 - rev 33050
Push 2352 by mozilla@jorgk.com at Sat, 22 Dec 2018 20:57:02 +0000
Backed out 4 changesets (bug 1514522, bug 1500105, bug 1511571, bug 1515903) for breaking account creation, bug 1516134. a=backout Backed out changeset 44241fb0b162 (bug 1514522) Backed out changeset 886ee22a3f85 (bug 1515903) Backed out changeset dacb68554465 (bug 1511571) Backed out changeset 60a1cefdf2af (bug 1500105)
ffdb14a414dd1a326a85870b100f442e0a58de0a: No bug - Pin mozilla-beta version (rev 93e2cfcc400d, FIREFOX_65_0b6 plus bug 1515504) for release. a=jorgk
Jorg K <jorgk@jorgk.com> - Fri, 21 Dec 2018 21:52:48 +0100 - rev 33049
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
No bug - Pin mozilla-beta version (rev 93e2cfcc400d, FIREFOX_65_0b6 plus bug 1515504) for release. a=jorgk
61f7be1b30e13797c65b4313c40e6f56abe2251d: Bug 1514951 - Fix filter creation from subject header. r=arshad a=jorgk
Magnus Melin <mkmelin+mozilla@iki.fi> - Wed, 19 Dec 2018 12:30:03 +0200 - rev 33048
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1514951 - Fix filter creation from subject header. r=arshad a=jorgk
994a012451923d399d70cb0b00cb63146e2ac312: Bug 1512581 - Match original behaviour of insertbefore/insertafter attributes; r=Fallen a=jorgk
Geoff Lankow <geoff@darktrojan.net> - Fri, 21 Dec 2018 22:27:05 +1300 - rev 33047
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1512581 - Match original behaviour of insertbefore/insertafter attributes; r=Fallen a=jorgk
44241fb0b16211fe4e3cbe66c7689e9c742e9730: Bug 1514522 - remove link to 3rd party site for account type add-ons. r+a=jorgk
Magnus Melin <mkmelin+mozilla@iki.fi> - Sat, 15 Dec 2018 23:16:41 +0200 - rev 33046
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1514522 - remove link to 3rd party site for account type add-ons. r+a=jorgk
886ee22a3f85d1a7f55c7fa1e5813470be99d88a: Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 21 Dec 2018 15:44:48 +0100 - rev 33045
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1515903 - [autoconfig] Allow PNG and JPEG image data: URLs. r=Neil a=jorgk Bug 1514628 changed the icon URL from http: to data:image/png;. However, data: URLs are forbidden, so the addon doesn't show up at all. data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs. However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain code. Then again, SVG can contain JS and must be forbidden. This change opens this up a little bit, allowing specifically PNG and JPEG image data: URLs, and only those. That allows icons to be inline.
dacb68554465e5daf329f5f9502932c0bd5f62af: Bug 1511571 - [autoconfig] Make domain bold. r=aceman a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33044
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1511571 - [autoconfig] Make domain bold. r=aceman a=jorgk To allow the user to more easily make secure decisions, we should make the second level domain of the hostname bold. E.g. for imap.mail.yahoo.com, we should make "yahoo.com" bold. Test Plan: IMAP config display: 1. Enter foo@yahoo.com 2. Click [Continue] 3. -> You see "Incoming: IMAP imap.mail.yahoo.com SSL" 4. -> whereas "yahoo.com" is bold Exchange config display: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> You see e.g. "Exchange server: mail.outlook.com" 5. -> whereas "outlook.com" is bold Insecure IMAP config display: 1. Enter foo@alice.it 2. Click [Continue] 3. -> You see "Incoming: IMAP in.alice.it No encryption" 4. -> whereas "alice.it" is bold 5. -> whereas "No encryption" is red Differential Revision: https://phabricator.services.mozilla.com/D13606
60a1cefdf2afe240abc3558542a8237276e7f000: Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk
Ben Bucksch <ben.bucksch@beonex.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33043
Push 2351 by mozilla@jorgk.com at Fri, 21 Dec 2018 20:53:50 +0000
Bug 1500105 - Support Exchange AutoDiscover and parallelize network calls. r=aceman,mkmelin,Neil a=jorgk Summary: * Parallelize network calls * Exchange AutoDiscover protocol implementation * Try to find IMAP servers in the server response * Offer to install an extension which supports the Exchange protocol to get mails Runs all the ISP config lookup network calls in parallel. Class PriorityOrderAbortable (subclass of ParallelAbortable) implements a policy that waits until one of the calls returns successfully, then takes that result and cancels all pending less desirable calls. Implements the Exchange AutoDiscover protocol to detect Exchange servers. If the server gives an IMAP configuration, we offer that to the user. Alternatively, we offer a compatible verified extension that implements the specific Exchange protocol that the Exchange server returned. Exchange has at least 7 protocols, and we show extensions that support the protocols that the server listed and that are known to work well and actively maintained. The setup process then continues without interruption. Test plan: Exchange autoconfig: 1. To test Exchange AutoDiscover with an hotmail/outlook.com account (which has an IMAP config in our ISPDB), set these prefs: mailnews.auto_config.guess.enabled = false mailnews.auto_config_url = "" mailnews.mx_service_url = "" 2. Enter you@outlook.com and a valid password (it will not work without valid password, due to the Exchange AutoDiscover protocol design) 3. [Continue] 4. -> TB should find an Exchange server with hostname 5. -> TB will offer you to install an extension that supports this protocol type, with explanatory text and a link 6. Click [Install] 7. -> The password is checked, the dialog closes, and the account appears, and your emails are downloaded. Parallel network calls: 1. Open account creation dialog 2. Enter "foo@gmail.com", "foo@yahoo.com", "foo@sys4.de", "foo@example.com", or any other domain 3. -> It works functionally as before, see https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Autoconfiguration 4. -> It's faster than before Differential Revision: https://phabricator.services.mozilla.com/D9215
fe6b4b76613f02e23c4773e110a354ea072edbcf: Backed out changeset 1f0cb7f8dc0b (bug 1503731) for test failures. a=backout
Jorg K <jorgk@jorgk.com> - Thu, 20 Dec 2018 19:11:22 +0100 - rev 33042
Push 2350 by mozilla@jorgk.com at Thu, 20 Dec 2018 18:12:07 +0000
Backed out changeset 1f0cb7f8dc0b (bug 1503731) for test failures. a=backout
ea62abed1629265310efdd303e24186a7239dbd0: Bug 1515104 - Fix the preferences spinbutton width after bug 1511394. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Tue, 18 Dec 2018 18:35:48 +0100 - rev 33041
Push 2349 by mozilla@jorgk.com at Thu, 20 Dec 2018 11:46:17 +0000
Bug 1515104 - Fix the preferences spinbutton width after bug 1511394. r+a=jorgk
6e4ca7bc98b5066178f61791e44d374484b6eedc: Bug 1514772 - Add missing "restarting" panel to the update dialogs. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Tue, 18 Dec 2018 15:38:09 +0100 - rev 33040
Push 2349 by mozilla@jorgk.com at Thu, 20 Dec 2018 11:46:17 +0000
Bug 1514772 - Add missing "restarting" panel to the update dialogs. r+a=jorgk
1f0cb7f8dc0bf68efab5f02b3b77822210b73090: Bug 1503731 - Avoid timezone conversion for date pattern detection of the datetimepicker; r+a=philipp
MakeMyDay <makemyday@gmx-topmail.de> - Sat, 17 Nov 2018 12:19:14 +0100 - rev 33039
Push 2349 by mozilla@jorgk.com at Thu, 20 Dec 2018 11:46:17 +0000
Bug 1503731 - Avoid timezone conversion for date pattern detection of the datetimepicker; r+a=philipp
83a1ba1a1c350ead0d7b83e5244c5ca061b04d91: Bug 1515337 - Bug 1512356 follow-up: Make nsMsgMailNewsUrl implement nsIIPCSerializableURI. rs=mkmelin a=jorgk
Jorg K <jorgk@jorgk.com> - Thu, 20 Dec 2018 10:29:06 +0100 - rev 33038
Push 2349 by mozilla@jorgk.com at Thu, 20 Dec 2018 11:46:17 +0000
Bug 1515337 - Bug 1512356 follow-up: Make nsMsgMailNewsUrl implement nsIIPCSerializableURI. rs=mkmelin a=jorgk
c69791aff82496ee2da4d993de79d2f379188af1: Bug 1515174 - Remove unnecessary box wrapping pref pane contents. r+a=jorgk
Geoff Lankow <geoff@darktrojan.net> - Wed, 19 Dec 2018 10:39:48 +1300 - rev 33037
Push 2349 by mozilla@jorgk.com at Thu, 20 Dec 2018 11:46:17 +0000
Bug 1515174 - Remove unnecessary box wrapping pref pane contents. r+a=jorgk
0204d7c2655a9df19b523504b0f45630e9d7f916: Bug 1514603 - Improve menubar visibility for AB and composer windows on Windows with a dark theme. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Sun, 16 Dec 2018 19:34:53 +0100 - rev 33036
Push 2348 by mozilla@jorgk.com at Mon, 17 Dec 2018 22:32:11 +0000
Bug 1514603 - Improve menubar visibility for AB and composer windows on Windows with a dark theme. r+a=jorgk
b9239ce6dc86d13d5cb666761ddc294da07d8c02: Bug 1511644 - Load statusbarpanel custom element in FilterListDialog.xul. r=aceman a=jorgk
Arshad Khan <arshdkhn1@gmail.com> - Fri, 07 Dec 2018 16:01:41 +0530 - rev 33035
Push 2348 by mozilla@jorgk.com at Mon, 17 Dec 2018 22:32:11 +0000
Bug 1511644 - Load statusbarpanel custom element in FilterListDialog.xul. r=aceman a=jorgk
557b2c4cc9c1714c7db1458cd443d44a5972e518: Bug 1514867 - Tagging 7ee2051d5d5d1b587a2c0ab2280a36feb5bfb277 with THUNDERBIRD_64_0b4_BUILD2, THUNDERBIRD_64_0b4_RELEASE a=rjl rs=bustage-fix DONTBUILD
Rob Lemley <rob@thunderbird.net> - Mon, 17 Dec 2018 16:06:20 -0500 - rev 33034
Push 2347 by thunderbird@calypsoblue.org at Mon, 17 Dec 2018 21:18:56 +0000
Bug 1514867 - Tagging 7ee2051d5d5d1b587a2c0ab2280a36feb5bfb277 with THUNDERBIRD_64_0b4_BUILD2, THUNDERBIRD_64_0b4_RELEASE a=rjl rs=bustage-fix DONTBUILD Added tag THUNDERBIRD_64_0b4_RELEASE for changeset 7ee2051d5d5d Added tag THUNDERBIRD_64_0b4_BUILD2 for changeset 7ee2051d5d5d
757a1c1c8fdd325a75eec0af48545e7a2f43f179: No bug - Pin mozilla-beta version (rev 17686e2a8e10, incl. bug 1508056 and bug 1508664) for release. a=jorgk
Jorg K <jorgk@jorgk.com> - Sat, 15 Dec 2018 11:17:35 +0100 - rev 33033
Push 2346 by mozilla@jorgk.com at Sat, 15 Dec 2018 10:20:08 +0000
No bug - Pin mozilla-beta version (rev 17686e2a8e10, incl. bug 1508056 and bug 1508664) for release. a=jorgk
907376bcbb3dacad0c725d111a29c2a0fb3e5482: Bug 1512790 - Move the Win7 Aero fog from tabs-toolbar to navigation-toolbox. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Fri, 14 Dec 2018 12:05:14 +0100 - rev 33032
Push 2346 by mozilla@jorgk.com at Sat, 15 Dec 2018 10:20:08 +0000
Bug 1512790 - Move the Win7 Aero fog from tabs-toolbar to navigation-toolbox. r+a=jorgk
6317b7048dcceb73c637a65e9c0d87c6acdd6182: Bug 1512790 - Remove unneeded extra padding introduced with bug 1496752. r+a=jorgk
Richard Marti <richard.marti@gmail.com> - Fri, 14 Dec 2018 11:12:31 +0100 - rev 33031
Push 2346 by mozilla@jorgk.com at Sat, 15 Dec 2018 10:20:08 +0000
Bug 1512790 - Remove unneeded extra padding introduced with bug 1496752. r+a=jorgk
(0) -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip