Bug 1321403 - make build work with python3 again, r=mt
authorFranziskus Kiefer <franziskuskiefer@gmail.com>
Fri, 25 Aug 2017 08:30:24 +0200
changeset 13546 fff2c933097d276680f0078834fe25fa28ac15ce
parent 13544 e0dea8f21d3c579e53350779268fab5bbdfa2a9c
child 13547 f05b3220957bf5dbbda49f1fe45ae8f5b4452c74
push id2337
push userfranziskuskiefer@gmail.com
push dateFri, 25 Aug 2017 06:32:01 +0000
reviewersmt
bugs1321403
Bug 1321403 - make build work with python3 again, r=mt Test Plan: . Reviewers: mt Reviewed By: mt Differential Revision: https://nss-review.dev.mozaws.net/D419
coreconf/werror.py
--- a/coreconf/werror.py
+++ b/coreconf/werror.py
@@ -19,17 +19,17 @@ def main():
     def can_enable():
         # This would be a problem
         if not warning_supported('all'):
             return False
 
         # If we aren't clang, make sure we have gcc 4.8 at least
         if not cc_is_clang:
             try:
-                v = subprocess.check_output([cc, '-dumpversion'], stderr=sink)
+                v = subprocess.check_output([cc, '-dumpversion'], stderr=sink).decode("utf-8")
                 v = v.strip(' \r\n').split('.')
                 v = list(map(int, v))
                 if v[0] < 4 or (v[0] == 4 and v[1] < 8):
                     # gcc 4.8 minimum
                     return False
             except OSError:
                 return False
         return True