Bug 1346602 - Turn -z defs into warnings on BSDs after 1330655. r=ttaubert
authorJan Beich <jbeich@FreeBSD.org>
Mon, 13 Mar 2017 11:26:00 +0000
changeset 13220 b210faf7a112943902a51dfce7b924afedfee3f4
parent 13219 412729bb2f245170bcd9a809e818bfeafe0b7c00
child 13221 703f8f3f23793f8954473bf889767d2f6d9206c7
push id2090
push userttaubert@mozilla.com
push dateThu, 16 Mar 2017 15:36:28 +0000
reviewersttaubert
bugs1346602, 1330655
Bug 1346602 - Turn -z defs into warnings on BSDs after 1330655. r=ttaubert
coreconf/config.gypi
--- a/coreconf/config.gypi
+++ b/coreconf/config.gypi
@@ -214,26 +214,28 @@
       # Shared library specific settings.
       [ '_type=="shared_library"', {
         'conditions': [
           [ 'cc_use_gnu_ld==1', {
             'ldflags': [
               '-Wl,--gc-sections',
             ],
             'conditions': [
-              ['OS=="dragonfly" or OS=="freebsd" or OS=="netbsd" or OS=="openbsd"', {
-                # Bug 1321317 - unix_rand.c:880: undefined reference to `environ'
-                'ldflags': [
-                  '-Wl,--warn-unresolved-symbols',
-                ],
-              }],
               ['no_zdefs==0', {
                 'ldflags': [
                   '-Wl,-z,defs',
                 ],
+               'conditions': [
+                 ['OS=="dragonfly" or OS=="freebsd" or OS=="netbsd" or OS=="openbsd"', {
+                   # Bug 1321317 - unix_rand.c:880: undefined reference to `environ'
+                   'ldflags': [
+                     '-Wl,--warn-unresolved-symbols',
+                   ],
+                 }],
+               ],
               }],
             ],
           }],
         ],
         'xcode_settings': {
           'DYLIB_INSTALL_NAME_BASE': '@executable_path',
           'DYLIB_COMPATIBILITY_VERSION': '1',
           'DYLIB_CURRENT_VERSION': '1',