Bug 469579 Coverity: uninitialized variable used in
pkix_ComCRLSelParams_Duplicate and pkix_CRLSelector_Duplicate
Patch contributed by Timeless <timeless@mozdev.org>, r=nelson
--- a/security/nss/lib/libpkix/pkix/crlsel/pkix_comcrlselparams.c
+++ b/security/nss/lib/libpkix/pkix/crlsel/pkix_comcrlselparams.c
@@ -381,17 +381,17 @@ cleanup:
*/
static PKIX_Error *
pkix_ComCRLSelParams_Duplicate(
PKIX_PL_Object *object,
PKIX_PL_Object **pNewObject,
void *plContext)
{
PKIX_ComCRLSelParams *old;
- PKIX_ComCRLSelParams *new;
+ PKIX_ComCRLSelParams *new = NULL;
PKIX_ENTER(COMCRLSELPARAMS, "pkix_ComCRLSelParams_Duplicate");
PKIX_NULLCHECK_TWO(object, pNewObject);
PKIX_CHECK(pkix_CheckType(object, PKIX_COMCRLSELPARAMS_TYPE, plContext),
PKIX_OBJECTNOTCOMCRLSELPARAMS);
old = (PKIX_ComCRLSelParams *)object;
--- a/security/nss/lib/libpkix/pkix/crlsel/pkix_crlselector.c
+++ b/security/nss/lib/libpkix/pkix/crlsel/pkix_crlselector.c
@@ -326,17 +326,17 @@ cleanup:
*/
static PKIX_Error *
pkix_CRLSelector_Duplicate(
PKIX_PL_Object *object,
PKIX_PL_Object **pNewObject,
void *plContext)
{
PKIX_CRLSelector *old;
- PKIX_CRLSelector *new;
+ PKIX_CRLSelector *new = NULL;
PKIX_ENTER(CRLSELECTOR, "pkix_CRLSelector_Duplicate");
PKIX_NULLCHECK_TWO(object, pNewObject);
PKIX_CHECK(pkix_CheckType
(object, PKIX_CRLSELECTOR_TYPE, plContext),
PKIX_OBJECTNOTCRLSELECTOR);