Bug 334013 - Fix references to undefined symbols in cryptohi.h and secsign.c comments v1, r=emaldona
authorCykesiopka <cykesiopka.bmo@gmail.com>
Thu, 29 May 2014 21:53:22 +0200
changeset 11164 9aafc7846e291c00f226d288fb0e36958cb5ac0b
parent 11163 2a654ae928512fee63e794ef78751d60ccb7013b
child 11165 c6c37cdbad0dc3965482b59d1b6cfe6684fa9b78
push id404
push userkaie@kuix.de
push dateThu, 29 May 2014 19:53:38 +0000
reviewersemaldona
bugs334013
Bug 334013 - Fix references to undefined symbols in cryptohi.h and secsign.c comments v1, r=emaldona
lib/cryptohi/cryptohi.h
lib/cryptohi/secsign.c
--- a/lib/cryptohi/cryptohi.h
+++ b/lib/cryptohi/cryptohi.h
@@ -51,17 +51,17 @@ extern SECItem *DSAU_DecodeDerSigToLen(c
 
 /****************************************/
 /*
 ** Signature creation operations
 */
 
 /*
 ** Create a new signature context used for signing a data stream.
-**	"alg" the signature algorithm to use (e.g. SEC_OID_RSA_WITH_MD5)
+**      "alg" the signature algorithm to use (e.g. SEC_OID_PKCS1_MD5_WITH_RSA_ENCRYPTION)
 **	"privKey" the private key to use
 */
 extern SGNContext *SGN_NewContext(SECOidTag alg, SECKEYPrivateKey *privKey);
 
 /*
 ** Destroy a signature-context object
 **	"cx" the object
 **	"freeit" if PR_TRUE then free the object as well as its sub-objects
--- a/lib/cryptohi/secsign.c
+++ b/lib/cryptohi/secsign.c
@@ -32,17 +32,17 @@ SGN_NewContext(SECOidTag alg, SECKEYPriv
     KeyType keyType;
     SECStatus rv;
 
     /* OK, map a PKCS #7 hash and encrypt algorithm into
      * a standard hashing algorithm. Why did we pass in the whole
      * PKCS #7 algTag if we were just going to change here you might
      * ask. Well the answer is for some cards we may have to do the
      * hashing on card. It may not support CKM_RSA_PKCS sign algorithm,
-     * it may just support CKM_RSA_PKCS_WITH_SHA1 and/or CKM_RSA_PKCS_WITH_MD5.
+     * it may just support CKM_SHA1_RSA_PKCS and/or CKM_MD5_RSA_PKCS.
      */
     /* we have a private key, not a public key, so don't pass it in */
     rv =  sec_DecodeSigAlg(NULL, alg, NULL, &signalg, &hashalg);
     if (rv != SECSuccess) {
 	PORT_SetError(SEC_ERROR_INVALID_ALGORITHM);
 	return 0;
     }
     keyType = seckey_GetKeyType(signalg);