Bug 1377618 - Simplify handling of CertificateVerify, r=kaie
--- a/lib/ssl/ssl3con.c
+++ b/lib/ssl/ssl3con.c
@@ -9753,23 +9753,22 @@ ssl3_HandleCertificateVerify(sslSocket *
if (rv != SECSuccess) {
errCode = PORT_GetError();
desc = decrypt_error;
goto alert_loser;
}
hashAlg = ssl_SignatureSchemeToHashType(sigScheme);
- if (hashes->u.pointer_to_hash_input.data) {
- rv = ssl3_ComputeHandshakeHash(hashes->u.pointer_to_hash_input.data,
- hashes->u.pointer_to_hash_input.len,
- hashAlg, &localHashes);
- } else {
- rv = SECFailure;
- }
+ /* Read from the message buffer, but we need to use only up to the end
+ * of the previous handshake message. The length of the transcript up to
+ * that point is saved in |hashes->u.transcriptLen|. */
+ rv = ssl3_ComputeHandshakeHash(ss->ssl3.hs.messages.buf,
+ hashes->u.transcriptLen,
+ hashAlg, &localHashes);
if (rv == SECSuccess) {
hashesForVerify = &localHashes;
} else {
errCode = SSL_ERROR_DIGEST_FAILURE;
desc = decrypt_error;
goto alert_loser;
}
@@ -11659,25 +11658,25 @@ ssl3_HandleHandshakeMessage(sslSocket *s
* ssl3_HandleCertificateVerify, which will tell us which
* hash function we must use.
*
* (ssl3_HandleCertificateVerify cannot simply look at the
* buffer length itself, because at the time we reach it,
* additional handshake messages will have been added to the
* buffer, e.g. the certificate_verify message itself.)
*
- * Therefore, we use SSL3Hashes.u.pointer_to_hash_input
- * to signal the current state of the buffer.
+ * Therefore, we use SSL3Hashes.u.transcriptLen to save how much
+ * data there is and read directly from ss->ssl3.hs.messages
+ * when calculating the hashes.
*
* ssl3_HandleCertificateVerify will detect
* hashType == handshake_hash_record
* and use that information to calculate the hash.
*/
- hashes.u.pointer_to_hash_input.data = ss->ssl3.hs.messages.buf;
- hashes.u.pointer_to_hash_input.len = ss->ssl3.hs.messages.len;
+ hashes.u.transcriptLen = ss->ssl3.hs.messages.len;
hashesPtr = &hashes;
} else {
computeHashes = PR_TRUE;
}
}
} else {
if (type == certificate_verify) {
computeHashes = TLS13_IN_HS_STATE(ss, wait_cert_verify);
--- a/lib/ssl/ssl3prot.h
+++ b/lib/ssl/ssl3prot.h
@@ -231,17 +231,17 @@ typedef struct {
* which, if |hashAlg==ssl_hash_none| is also a SSL3HashesIndividually
* struct. */
typedef struct {
unsigned int len;
SSLHashType hashAlg;
union {
PRUint8 raw[64];
SSL3HashesIndividually s;
- SECItem pointer_to_hash_input;
+ unsigned int transcriptLen;
} u;
} SSL3Hashes;
typedef struct {
union {
PRUint8 anonymous;
SSL3Hashes certified;
} u;