Bug 507377: useless null check of params in nsc_parameter_gen
Patch contributed by Timeless <timeless@mozdev.org>, r=nelson
--- a/security/nss/lib/softoken/pkcs11c.c
+++ b/security/nss/lib/softoken/pkcs11c.c
@@ -2894,19 +2894,18 @@ nsc_parameter_gen(CK_KEY_TYPE key_type,
crv = sftk_AddAttributeType(key,CKA_NETSCAPE_PQG_SEED,
vfy->seed.data, vfy->seed.len);
if (crv != CKR_OK) goto loser;
crv = sftk_AddAttributeType(key,CKA_NETSCAPE_PQG_H,
vfy->h.data, vfy->h.len);
if (crv != CKR_OK) goto loser;
loser:
- if (params) {
- PQG_DestroyParams(params);
- }
+ PQG_DestroyParams(params);
+
if (vfy) {
PQG_DestroyVerify(vfy);
}
return crv;
}
static CK_RV