[Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
authoralexei.volkov.bugs%sun.com
Tue, 25 Apr 2006 02:33:58 +0000
changeset 6937 559263879210d4077c4753d1b173a691e1c1f535
parent 6936 8e2bec98b31b30d9d2e9fb5a11a373456f33185b
child 6940 8605ce12bc7bcf66df455bc6ecf508ed1b321055
push idunknown
push userunknown
push dateunknown
reviewersrelyea
bugs334277
[Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
security/nss/lib/softoken/pkcs11u.c
--- a/security/nss/lib/softoken/pkcs11u.c
+++ b/security/nss/lib/softoken/pkcs11u.c
@@ -1512,17 +1512,16 @@ sftk_DeleteAttribute(SFTKObject *object,
     }
     PZ_Lock(sessObject->attributeLock);
     if (sftkqueue_is_queued(attribute,attribute->handle,
 				sessObject->head, sessObject->hashSize)) {
 	sftkqueue_delete(attribute,attribute->handle,
 				sessObject->head, sessObject->hashSize);
     }
     PZ_Unlock(sessObject->attributeLock);
-    sftk_FreeAttribute(attribute);
 }
 
 /*
  * this is only valid for CK_BBOOL type attributes. Return the state
  * of that attribute.
  */
 PRBool
 sftk_isTrue(SFTKObject *object,CK_ATTRIBUTE_TYPE type)