Bug 1351459 - disable long b64 tests, r=kaie
authorFranziskus Kiefer <franziskuskiefer@gmail.com>
Wed, 19 Apr 2017 14:50:42 +0200
changeset 13303 00b2cc2b33c737fb2a97862aeca55c1079cdebd8
parent 13302 0658e7288f208215ff5bf426c8e42cff5099b59e
child 13304 89c818ff7f8b0a47c253f6f794addbd633f5ba23
push id2156
push userfranziskuskiefer@gmail.com
push dateWed, 19 Apr 2017 13:57:48 +0000
reviewerskaie
bugs1351459
Bug 1351459 - disable long b64 tests, r=kaie Differential Revision: https://nss-review.dev.mozaws.net/D292
gtests/util_gtest/util_b64_unittest.cc
tests/gtests/gtests.sh
--- a/gtests/util_gtest/util_b64_unittest.cc
+++ b/gtests/util_gtest/util_b64_unittest.cc
@@ -63,17 +63,19 @@ TEST_F(B64EncodeDecodeTest, EncDecTest) 
 
 TEST_F(B64EncodeDecodeTest, FakeDecTest) { EXPECT_TRUE(TestFakeDecode(100)); }
 
 TEST_F(B64EncodeDecodeTest, FakeEncDecTest) {
   EXPECT_TRUE(TestFakeEncode(100));
 }
 
 // These takes a while ...
-TEST_F(B64EncodeDecodeTest, LongFakeDecTest1) {
+TEST_F(B64EncodeDecodeTest, DISABLED_LongFakeDecTest1) {
   EXPECT_TRUE(TestFakeDecode(0x66666666));
 }
-TEST_F(B64EncodeDecodeTest, LongFakeEncDecTest1) { TestFakeEncode(0x3fffffff); }
-TEST_F(B64EncodeDecodeTest, LongFakeEncDecTest2) {
+TEST_F(B64EncodeDecodeTest, DISABLED_LongFakeEncDecTest1) {
+  TestFakeEncode(0x3fffffff);
+}
+TEST_F(B64EncodeDecodeTest, DISABLED_LongFakeEncDecTest2) {
   EXPECT_FALSE(TestFakeEncode(0x40000000));
 }
 
 }  // namespace nss_test
--- a/tests/gtests/gtests.sh
+++ b/tests/gtests/gtests.sh
@@ -50,20 +50,19 @@ gtest_start()
     html_head "$i"
     if [ ! -d "$GTESTDIR" ]; then
       mkdir -p "$GTESTDIR"
     fi
     cd "$GTESTDIR"
     GTESTREPORT="$GTESTDIR/report.xml"
     PARSED_REPORT="$GTESTDIR/report.parsed"
     echo "executing $i"
-    # We disable slow b64 tests because they fail on ppc and armhf (bug 1351459).
     ${BINDIR}/$i "${SOURCE_DIR}/gtests/freebl_gtest/kat/Hash_DRBG.rsp" \
                  -d "$GTESTDIR" --gtest_output=xml:"${GTESTREPORT}" \
-                 --gtest_filter="${GTESTFILTER-*}:-*B64*Long*"
+                                --gtest_filter="${GTESTFILTER-*}"
     html_msg $? 0 "$i run successfully"
     echo "test output dir: ${GTESTREPORT}"
     echo "executing sed to parse the xml report"
     sed -f ${COMMON}/parsegtestreport.sed "${GTESTREPORT}" > "${PARSED_REPORT}"
     echo "processing the parsed report"
     cat "${PARSED_REPORT}" | while read result name; do
       if [ "$result" = "notrun" ]; then
         echo "$name" SKIPPED