searching for reviewer(relyea)
c746e2c152167c0664eff947d684c86989fedbc8: Bug 1221839 - UBSan: left shift of 128 by 24 places cannot be represented in type 'int' pkcs11.c, r=relyea
Franziskus Kiefer <franziskuskiefer@gmail.com> - Fri, 27 Nov 2015 11:49:07 +0000 - rev 11953
Push 1030 by franziskuskiefer@gmail.com at Wed, 02 Mar 2016 10:52:15 +0000
Bug 1221839 - UBSan: left shift of 128 by 24 places cannot be represented in type 'int' pkcs11.c, r=relyea
83cd348f9aa6d362b4934d99d1958969c6648cc2: Bug 1186917 - list nsspki, nssdev, and sspb only once for windows. r=relyea
Elio Maldonado <emaldona@redhat.com> - Tue, 22 Dec 2015 09:30:45 -0800 - rev 11802
Push 923 by emaldona@redhat.com at Tue, 22 Dec 2015 17:31:00 +0000
Bug 1186917 - list nsspki, nssdev, and sspb only once for windows. r=relyea From review comment 38
f9bac028f79a6b2129c561137f1d4312c981cedd: Bug 1095307 - Clean up nssPKIX509_GetIssuerAndSerialFromDER(). r=relyea. NSS_3_18_BETA3
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 18 Nov 2014 15:16:24 -0800 - rev 11309
Push 518 by kaie@kuix.de at Wed, 19 Nov 2014 14:03:20 +0000
Bug 1095307 - Clean up nssPKIX509_GetIssuerAndSerialFromDER(). r=relyea. This patch: - Removes the two static issuer_and_serial_from_encoding() functions. - Rewrites nssPKIX509_GetIssuerAndSerialFromDER() to be almost identical to the issuer_and_serial_from_encoding() from pkistore.c. This new version avoids unnecessary heap allocations (and so doesn't need an |arena| argument), obtains the issuer and serial in the order suggested by the function name, and is more readable than the old version. - Tweaks nssTrustDomain_FindCertificateByEncodedCertificate() to be more like nssTrustDomain_GetCertByDERFromCache() and nssCertificateStore_FindCertificateByEncodedCertificate(), which are the other two functions that now call nssPKIX509_GetIssuerAndSerialFromDER().
902bc119dcdb6ae24bf82c466b22000577639e08: Bug 1094650 - Avoid excessive heap allocation in nss_builtins_FindObjectsInit(). r=relyea
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Nov 2014 13:10:55 +0100 - rev 11306
Push 515 by kaie@kuix.de at Mon, 17 Nov 2014 12:11:07 +0000
Bug 1094650 - Avoid excessive heap allocation in nss_builtins_FindObjectsInit(). r=relyea
3f7c5bec550ba74dbcd15c604881788ea29557ec: Bugzilla bug 301212: Upgraded to zlib 1.2.3. r=relyea.
wtchang%redhat.com - Sat, 07 Nov 2009 01:13:29 +0000 - rev 9451
Bugzilla bug 301212: Upgraded to zlib 1.2.3. r=relyea. Modified Files: README adler32.c compress.c crc32.c deflate.c deflate.h example.c gzio.c infback.c inffast.c inflate.c inflate.h inftrees.c inftrees.h minigzip.c trees.c uncompr.c zconf.h zlib.h zutil.c zutil.h
8156b7b51edb5077f90c504ff426db2093469958: Bugzilla bug 131826: upgraded to zlib 1.2.2. a=relyea,jpierre.
wchang0222%aol.com - Sat, 07 Nov 2009 01:13:23 +0000 - rev 9445
Bugzilla bug 131826: upgraded to zlib 1.2.2. a=relyea,jpierre. Modified Files: README adler32.c compress.c config.mk crc32.c deflate.c deflate.h example.c gzio.c inffast.c inffast.h inffixed.h inflate.c inftrees.c inftrees.h manifest.mn minigzip.c trees.c uncompr.c zconf.h zlib.h zutil.c zutil.h Added Files: crc32.h infback.c inflate.h Removed Files: infblock.c infblock.h infcodes.c infcodes.h infutil.c infutil.h makefile.win maketree.c netscape_mods.doc zip16.def
6984782b053cc325dcd7484dae204f04499ab8d0: Add missing license block. Wrap long lines. Bug 243580. r=relyea.
nelsonb%netscape.com - Sun, 29 Mar 2009 19:04:25 +0000 - rev 9142
Add missing license block. Wrap long lines. Bug 243580. r=relyea.
63d3d81144d1ed0cd2f563779f96786b876d759a: Fix for bug 473505 . softoken's C_Initialize and C_Finalize should succeed after a fork in a child process. r=relyea, nelson
julien.pierre.boogz%sun.com - Tue, 03 Feb 2009 05:34:47 +0000 - rev 8979
Fix for bug 473505 . softoken's C_Initialize and C_Finalize should succeed after a fork in a child process. r=relyea, nelson
ec9a0c0b35e929e487d9a8bba2c58f344aadf1a5: Fix for bug 391771 . pk11_config_name and pk11_config_strings leaked on shutdown. Add new PK11_UnconfigurePKCS11 call to free the strings. r=nelson, relyea NSS_3_11_BRANCH
julien.pierre.boogz%sun.com - Thu, 06 Dec 2007 00:45:12 +0000 - rev 8278
Fix for bug 391771 . pk11_config_name and pk11_config_strings leaked on shutdown. Add new PK11_UnconfigurePKCS11 call to free the strings. r=nelson, relyea
62b4b9a10f72a98064a219ed87301ae9ed3a6c9b: Fix for bug 391771 . pk11_config_name and pk11_config_strings leaked on shutdown. Add new PK11_UnconfigurePKCS11 call to free the strings. r=nelson, relyea
julien.pierre.boogz%sun.com - Thu, 06 Dec 2007 00:40:19 +0000 - rev 8277
Fix for bug 391771 . pk11_config_name and pk11_config_strings leaked on shutdown. Add new PK11_UnconfigurePKCS11 call to free the strings. r=nelson, relyea
1a9550c7f5a3d4cd015db6ad63b13b97d611d8d1: Fix for bug 227049 . Add Windows 64 bits ( AMD64 ) support for NSS libraries. r=nelson, relyea
julien.pierre.boogz%sun.com - Wed, 14 Nov 2007 22:49:44 +0000 - rev 8228
Fix for bug 227049 . Add Windows 64 bits ( AMD64 ) support for NSS libraries. r=nelson, relyea
f6fdfda689094a7337e3cbd31ba0de880f6cc918: Fix for bug 227049 . Add Windows 64 bits (AMD64) support for NSS libraries. r=nelson, relyea NSS_3_11_BRANCH
julien.pierre.boogz%sun.com - Wed, 14 Nov 2007 22:47:51 +0000 - rev 8227
Fix for bug 227049 . Add Windows 64 bits (AMD64) support for NSS libraries. r=nelson, relyea
2ed2e9196457fd43df9de359524f0103b9080127: Fix for bug 399304 . Initialize cert trust and refcount locks early. r=relyea, nelson NSS_3_11_BRANCH
julien.pierre.boogz%sun.com - Sat, 10 Nov 2007 04:26:12 +0000 - rev 8216
Fix for bug 399304 . Initialize cert trust and refcount locks early. r=relyea, nelson
95bc128ecbf27d6c2fb2df7500a463a73f8b7cf4: Fix for bug 399304 . Initialize cert trust and refcount locks early. r=relyea, nelson
julien.pierre.boogz%sun.com - Sat, 10 Nov 2007 04:23:26 +0000 - rev 8215
Fix for bug 399304 . Initialize cert trust and refcount locks early. r=relyea, nelson
eb8c99d86e92e75667974b2577ed0f532dabb5b7: Bugzilla Bug 337034: nested two related tests. r=relyea.
wtchang%redhat.com - Sat, 17 Jun 2006 00:09:59 +0000 - rev 7211
Bugzilla Bug 337034: nested two related tests. r=relyea.
206cc1e41243b14c455aa9d05818118adb69afe4: Fix for bug 335021. Add SEC_ASN1_CONSTRUCTED to S/MIME EKP template. r=relyea
julien.pierre.bugs%sun.com - Sat, 29 Apr 2006 00:18:42 +0000 - rev 6970
Fix for bug 335021. Add SEC_ASN1_CONSTRUCTED to S/MIME EKP template. r=relyea
a9820b45d46678cdb20b4a8bc06291d861cebc70: [Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea NSS_3_11_BRANCH
alexei.volkov.bugs%sun.com - Tue, 25 Apr 2006 02:34:01 +0000 - rev 6938
[Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
559263879210d4077c4753d1b173a691e1c1f535: [Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
alexei.volkov.bugs%sun.com - Tue, 25 Apr 2006 02:33:58 +0000 - rev 6937
[Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
4f1bc469c80c571f1229ac5836f8ccf86e3377ad: Bugzilla Bug 311958: Update the nssckbi versions for NSS 3.11. r=relyea.
wtchang%redhat.com - Fri, 04 Nov 2005 22:51:55 +0000 - rev 6244
Bugzilla Bug 311958: Update the nssckbi versions for NSS 3.11. r=relyea.
90af54c8a55e51ab8f30426cb3920619cd2efa5e: Bugzilla bug 239960: cvs removed cmd/swfort. r=relyea.
wtchang%redhat.com - Thu, 27 Oct 2005 22:49:22 +0000 - rev 6219
Bugzilla bug 239960: cvs removed cmd/swfort. r=relyea.
4378426de7ce2e578917f64ce6ad5f32624b56bf: Bug 299197: added the comment for PK11_TokenKeyGen back. r=relyea.
wtchang%redhat.com - Wed, 21 Sep 2005 01:32:11 +0000 - rev 6130
Bug 299197: added the comment for PK11_TokenKeyGen back. r=relyea.
638674cce583c5b516c4206e0a86e2f19f1f677c: Bug 299197: fixed comments. r=relyea.
wtchang%redhat.com - Wed, 21 Sep 2005 01:31:37 +0000 - rev 6129
Bug 299197: fixed comments. r=relyea.
441c8607aa2be7b254a7e3ce9145daf9b812bf5f: Bugzilla Bug 302219: added CKM_RSA_X9_31_KEY_PAIR_GEN support. r=relyea.
wtchang%redhat.com - Fri, 29 Jul 2005 23:43:40 +0000 - rev 5799
Bugzilla Bug 302219: added CKM_RSA_X9_31_KEY_PAIR_GEN support. r=relyea.
815742f2591eb0926ee877b303f5d5b1bfdd0ced: Bugzilla Bug 298516: fixed problems found by code inspection. r=relyea.
wtchang%redhat.com - Fri, 22 Jul 2005 00:47:18 +0000 - rev 5775
Bugzilla Bug 298516: fixed problems found by code inspection. r=relyea. Modified Files: pk11db.c pkcs11.c
555f7a321d2eb489ef75e731e9997fafcced5331: Bugzilla bug 301212: upgraded to zlib 1.2.3. r=relyea,nelsonb. NSS_3_10_BRANCH
wtchang%redhat.com - Wed, 20 Jul 2005 23:45:58 +0000 - rev 5771
Bugzilla bug 301212: upgraded to zlib 1.2.3. r=relyea,nelsonb. Modified Files: Tag: NSS_3_10_BRANCH README adler32.c compress.c crc32.c deflate.c deflate.h example.c gzio.c infback.c inffast.c inflate.c inflate.h inftrees.c inftrees.h minigzip.c trees.c uncompr.c zconf.h zlib.h zutil.c zutil.h
66d4d67f8634d4e88faf1dbd2ef58520b1d737c2: Bugzilla bug 301212: Upgraded to zlib 1.2.3. r=relyea.
wtchang%redhat.com - Wed, 20 Jul 2005 20:32:42 +0000 - rev 5770
Bugzilla bug 301212: Upgraded to zlib 1.2.3. r=relyea. Modified Files: README adler32.c compress.c crc32.c deflate.c deflate.h example.c gzio.c infback.c inffast.c inflate.c inflate.h inftrees.c inftrees.h minigzip.c trees.c uncompr.c zconf.h zlib.h zutil.c zutil.h
eafd04bd96c54443096ce5dd21400ec99e3b83b5: Fix for bug 217024 . Add a function to compare validity times. r=relyea
julien.pierre.bugs%sun.com - Fri, 08 Jul 2005 07:06:56 +0000 - rev 5757
Fix for bug 217024 . Add a function to compare validity times. r=relyea
2b38d633df02a768aabec6fbde9d4d1f6bbd6b0b: Fix for bug 292809 . Add flags to NSS_Initialize to better cooperate with the Java SunPKCS11 provider. r=relyea, wtchang
julien.pierre.bugs%sun.com - Fri, 08 Jul 2005 04:41:32 +0000 - rev 5756
Fix for bug 292809 . Add flags to NSS_Initialize to better cooperate with the Java SunPKCS11 provider. r=relyea, wtchang
8d809717251e02d4e346b5773e3b474a58b3bb89: Fix for 298955 . Allow rsaperf to authenticate to hardware tokens. r=relyea NSS_PERFORMANCE_HACKS_BRANCH
julien.pierre.bugs%sun.com - Thu, 30 Jun 2005 20:39:46 +0000 - rev 5739
Fix for 298955 . Allow rsaperf to authenticate to hardware tokens. r=relyea
3eedc25ad304f070b0e1958db403d67b6c4d4952: Fix for 298955 - make rsaperf authenticate to hardware tokens. r=relyea
julien.pierre.bugs%sun.com - Thu, 30 Jun 2005 20:38:33 +0000 - rev 5738
Fix for 298955 - make rsaperf authenticate to hardware tokens. r=relyea
58f2533a9dc0699a096d29fc6ab034b7af6705bd: Fix bugzilla 268521 - C_CloseSession getting called after C_CloseAllSessions . r=relyea, nelsonb
julien.pierre.bugs%sun.com - Tue, 09 Nov 2004 23:19:24 +0000 - rev 5434
Fix bugzilla 268521 - C_CloseSession getting called after C_CloseAllSessions . r=relyea, nelsonb
3b296b1629c1319ed89d6ee8099a6c2cfbb41494: Bugzilla bug 131826: upgraded to zlib 1.2.2. a=relyea,jpierre.
wchang0222%aol.com - Tue, 02 Nov 2004 23:40:10 +0000 - rev 5415
Bugzilla bug 131826: upgraded to zlib 1.2.2. a=relyea,jpierre. Modified Files: README adler32.c compress.c config.mk crc32.c deflate.c deflate.h example.c gzio.c inffast.c inffast.h inffixed.h inflate.c inftrees.c inftrees.h manifest.mn minigzip.c trees.c uncompr.c zconf.h zlib.h zutil.c zutil.h Added Files: crc32.h infback.c inflate.h Removed Files: infblock.c infblock.h infcodes.c infcodes.h infutil.c infutil.h makefile.win maketree.c netscape_mods.doc zip16.def
c72e7ffd4b343fcc0dc775a44e1180b0e2cb0e7d: Fix for bug 265707 - SECMOD_FindSlot always returns NULL. r=relyea
julien.pierre.bugs%sun.com - Sun, 24 Oct 2004 18:25:04 +0000 - rev 5397
Fix for bug 265707 - SECMOD_FindSlot always returns NULL. r=relyea
efff4dc05559f585dc8186a793e5d25890ffca6d: Fix for 249488 - root cert module requires locking functions in CK_C_INITIALIZE_ARGS . r=ian, sr=relyea
jpierre%netscape.com - Thu, 29 Jul 2004 22:51:00 +0000 - rev 5307
Fix for 249488 - root cert module requires locking functions in CK_C_INITIALIZE_ARGS . r=ian, sr=relyea
14b7310e1e1960897ca03da03e3d2f39f6e16bd9: Fix for 249488 - root cert module requires locking functions in CK_C_INITIALIZE_ARGS . r=ian, sr=relyea NSS_3_9_BRANCH
jpierre%netscape.com - Thu, 29 Jul 2004 22:50:19 +0000 - rev 5306
Fix for 249488 - root cert module requires locking functions in CK_C_INITIALIZE_ARGS . r=ian, sr=relyea
e7962a3894b1e885001d10c9b208b27f8d0a856e: Fix for 248981 - make SECMOD_LoadPKCS11Module thread safe. r=relyea
jpierre%netscape.com - Thu, 01 Jul 2004 19:20:51 +0000 - rev 5268
Fix for 248981 - make SECMOD_LoadPKCS11Module thread safe. r=relyea
4c50da4f414d6335f11d81e0c7d9c28995c7db96: Backout part of the QuickDER changes from 178895 . r=relyea
jpierre%netscape.com - Thu, 17 Jun 2004 23:23:59 +0000 - rev 5240
Backout part of the QuickDER changes from 178895 . r=relyea
f817f3f2fda0f7a5c36b5989e099b95af0c15a54: Fix for 178895 - QuickDER optimizations. r=relyea
jpierre%netscape.com - Sat, 05 Jun 2004 00:50:32 +0000 - rev 5223
Fix for 178895 - QuickDER optimizations. r=relyea
c3cfab5191a4e0bfe99d6092e11b4bd291f5d795: Export symbols needed for crmftest. r=relyea. bug 244329.
nelsonb%netscape.com - Wed, 02 Jun 2004 22:19:33 +0000 - rev 5217
Export symbols needed for crmftest. r=relyea. bug 244329.
38de205f150004e1257d3dd5e5b172a9fb8a57c4: Fix crash when array member is used as variable. Bug 243655. r=relyea.
nelsonb%netscape.com - Sat, 22 May 2004 01:24:22 +0000 - rev 5208
Fix crash when array member is used as variable. Bug 243655. r=relyea.
8997c2ce935fa1a8115e77b3d66b8fed7fd890b1: Add missing license block. Wrap long lines. Bug 243580. r=relyea.
nelsonb%netscape.com - Sat, 22 May 2004 00:56:46 +0000 - rev 5206
Add missing license block. Wrap long lines. Bug 243580. r=relyea.
971a12b96b30278700c58b38103e6ad1cd40d63a: Fix for 233493 - fix symkeyutil build on OS/2. r=relyea NSS_3_9_BRANCH
jpierre%netscape.com - Tue, 10 Feb 2004 23:49:10 +0000 - rev 5083
Fix for 233493 - fix symkeyutil build on OS/2. r=relyea
1df89cf2c3b12dbd1098d136eb1de91169cc9b60: Fix for 233493 - fix symkeyutil build on OS/2. r=relyea
jpierre%netscape.com - Tue, 10 Feb 2004 23:48:37 +0000 - rev 5082
Fix for 233493 - fix symkeyutil build on OS/2. r=relyea
21d3018981a7cbecdfd9e96235346245b359f76c: Make SECOID_AddEntry be thread safe. Export it. Bug 124923. r=relyea.
nelsonb%netscape.com - Thu, 29 Jan 2004 21:23:36 +0000 - rev 5052
Make SECOID_AddEntry be thread safe. Export it. Bug 124923. r=relyea.
e34719874178989598b704b7b1998ce0986ce248: Plug leaks. Bug 123693. r=wtc,relyea
nelsonb%netscape.com - Thu, 29 Jan 2004 21:18:24 +0000 - rev 5051
Plug leaks. Bug 123693. r=wtc,relyea
355069b87e6940d03dff7eeadf48a2793850f6c5: Bugzilla bug 229289: fixed an unused variable warning. r=relyea.
wchang0222%aol.com - Tue, 13 Jan 2004 01:59:41 +0000 - rev 4994
Bugzilla bug 229289: fixed an unused variable warning. r=relyea.
393cba03fae55a5b92ec5359a402abf566d02784: Made wincx the last argument of PK11_PubDeriveExtended. r=relyea.
wchang0222%aol.com - Fri, 19 Dec 2003 23:54:29 +0000 - rev 4948
Made wincx the last argument of PK11_PubDeriveExtended. r=relyea. Modified Files: pk11func.h pk11skey.c ssl3con.c
632739b5abd34eaf5303c3e6ab1d17f4e019928f: PK11_MoveKey was renamed PK11_MoveSymKey. r=relyea.
wchang0222%aol.com - Fri, 19 Dec 2003 23:29:43 +0000 - rev 4946
PK11_MoveKey was renamed PK11_MoveSymKey. r=relyea. Modified Files: symkeyutil.c nss.def pk11func.h pk11skey.c
957771d4b63f3c5ee4239c5dd8f94d7b5e4a737a: Add null pointer checks to nss_cms_after_end and NSS_CMSEnvelopedData_Decode_AfterData. Bugscape bug 54061. r=wtc,relyea
nelsonb%netscape.com - Thu, 04 Dec 2003 00:14:24 +0000 - rev 4903
Add null pointer checks to nss_cms_after_end and NSS_CMSEnvelopedData_Decode_AfterData. Bugscape bug 54061. r=wtc,relyea Lots of code "cleanup" (reformatting for 80 columns) in cmsdecode.c
5d3d13d23fceac1faeeeb4eb364b576fc0e8a52e: Fixed a comment error. r=relyea.
wchang0222%aol.com - Thu, 13 Nov 2003 16:21:46 +0000 - rev 4837
Fixed a comment error. r=relyea.