f10c3e0757b7b2cef3fb6201b2a9be795c6aecd4: Bug 1459141 - Backed out changeset 474d62c9d0db for PK11_Wrap/Unwrap issues r=me NSS_3_47_BETA3
J.C. Jones <jjones@mozilla.com> - Wed, 16 Oct 2019 11:46:31 -0700 - rev 15341
Push 3538 by jjones@mozilla.com at Wed, 16 Oct 2019 18:47:21 +0000
Bug 1459141 - Backed out changeset 474d62c9d0db for PK11_Wrap/Unwrap issues r=me
3ca8b20b24ee94b917a057b68166aefc8fcb546d: Added tag NSS_3_47_BETA2 for changeset f657d65428c6
J.C. Jones <jjones@mozilla.com> - Tue, 15 Oct 2019 16:56:05 -0700 - rev 15340
Push 3537 by jjones@mozilla.com at Tue, 15 Oct 2019 23:56:23 +0000
Added tag NSS_3_47_BETA2 for changeset f657d65428c6
f657d65428c6e9e3468158df79c40bf5f6f32faf: Bug 1465613 - Fixup clang format a=bustage NSS_3_47_BETA2
J.C. Jones <jjones@mozilla.com> - Tue, 15 Oct 2019 16:54:58 -0700 - rev 15339
Push 3536 by jjones@mozilla.com at Tue, 15 Oct 2019 23:55:32 +0000
Bug 1465613 - Fixup clang format a=bustage
52024949df95c7147c4995bb8ddc094027636001: Bug 1465613 - Created two new fields for scheduled distrust from builtins and updated support commands. r=jcj,kjacobs,mt
Marcus Burghardt <mburghardt@mozilla.com> - Fri, 11 Oct 2019 03:49:25 +0000 - rev 15338
Push 3535 by jjones@mozilla.com at Tue, 15 Oct 2019 19:18:17 +0000
Bug 1465613 - Created two new fields for scheduled distrust from builtins and updated support commands. r=jcj,kjacobs,mt Added two new fields do scheduled distrust of CAs in nssckbi/builtins. Also, created a testlib to validate these fields with gtests. Differential Revision: https://phabricator.services.mozilla.com/D36597
0f563a2571c304c4c51f01a3c546387e3743205c: Bug 1588557 - Fix debug statement, r=jcj
Martin Thomson <martin.thomson@gmail.com> - Mon, 14 Oct 2019 17:15:46 +0000 - rev 15337
Push 3534 by jjones@mozilla.com at Tue, 15 Oct 2019 16:34:44 +0000
Bug 1588557 - Fix debug statement, r=jcj Differential Revision: https://phabricator.services.mozilla.com/D49177
c50f933d37a5e35c916c1d52e1ee5cb1e19af730: bug 1579060 - fix handling of issuerUniqueID and subjectUniqueID in mozilla::pkix::BackCert r=jcj
Dana Keeler <dkeeler@mozilla.com> - Tue, 15 Oct 2019 14:59:05 +0000 - rev 15336
Push 3533 by jjones@mozilla.com at Tue, 15 Oct 2019 14:59:31 +0000
bug 1579060 - fix handling of issuerUniqueID and subjectUniqueID in mozilla::pkix::BackCert r=jcj According to RFC 5280, the definitions of issuerUniqueID and subjectUniqueID in TBSCertificate are as follows: issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL, subjectUniqueID [2] IMPLICIT UniqueIdentifier OPTIONAL, where UniqueIdentifier is a BIT STRING. IMPLICIT tags replace the tag of the underlying type. For these fields, there is no specified class (just a tag number within the class), and the underlying type of BIT STRING is "primitive" (i.e. not constructed). Thus, the tags should be of the form CONTEXT SPECIFIC | [number in class], which comes out to 0x81 and 0x82, respectively. When originally implemented, mozilla::pkix incorrectly required that the CONSTRUCTED bit also be set for these fields. Consequently, the library would reject any certificate that actually contained these fields. Evidently such certificates are rare. Differential Revision: https://phabricator.services.mozilla.com/D49013
474d62c9d0db3f8c3780e62a1a16c91c364fee14: Bug 1459141 - Rewrite softoken CBC pad check to be constant time. r=kjacobs,jcj
Deian Stefan <deian@cs.ucsd.edu> - Mon, 14 Oct 2019 10:03:41 -0700 - rev 15335
Push 3532 by jjones@mozilla.com at Mon, 14 Oct 2019 19:26:13 +0000
Bug 1459141 - Rewrite softoken CBC pad check to be constant time. r=kjacobs,jcj
f60dbafbc1827f4325e1c88bf3f7565857bf25c5: Added tag NSS_3_47_BETA1 for changeset 93245f5733b3
J.C. Jones <jjones@mozilla.com> - Fri, 11 Oct 2019 13:51:07 -0700 - rev 15334
Push 3531 by jjones@mozilla.com at Fri, 11 Oct 2019 20:51:54 +0000
Added tag NSS_3_47_BETA1 for changeset 93245f5733b3
93245f5733b3a042604e3021c0233ea8bfb6e3b9: Bug 1583068 - Require NSPR version 4.23 r=jcj NSS_3_47_BETA1
Kai Engert <kaie@kuix.de> - Fri, 11 Oct 2019 12:38:52 -0700 - rev 15333
Push 3530 by jjones@mozilla.com at Fri, 11 Oct 2019 19:42:16 +0000
Bug 1583068 - Require NSPR version 4.23 r=jcj
9abcea09fdd4b252e7774d450c2f9a622f38f1ad: Bug 1152625 - Add gyp flag for disabling ARM HW AES r=jcj
Kevin Jacobs <kjacobs@mozilla.com> - Fri, 11 Oct 2019 19:33:06 +0000 - rev 15332
Push 3529 by jjones@mozilla.com at Fri, 11 Oct 2019 19:34:03 +0000
Bug 1152625 - Add gyp flag for disabling ARM HW AES r=jcj Adds an option to disable ARMv8 HW AES, if `-Ddisable_arm_hw_aes=1` is passed to build.sh. Depends on D34473 Differential Revision: https://phabricator.services.mozilla.com/D44018
1b0f5c5335ee7480e5856ae3890b0463e4882b95: Bug 1152625 - Part 2. Remove __builtin_assume to avoid crash on PGO. r=kjacobs,mt
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 11 Oct 2019 19:32:43 +0000 - rev 15331
Push 3529 by jjones@mozilla.com at Fri, 11 Oct 2019 19:34:03 +0000
Bug 1152625 - Part 2. Remove __builtin_assume to avoid crash on PGO. r=kjacobs,mt `AESContext->iv` doesn't align to 16 bytes on PGO build, so we should remove __builtin_assume. Also, I guess that `expandedKey` has same problem. Differential Revision: https://phabricator.services.mozilla.com/D40607
efb895a43899642a3f3a6bfe2957870dbaccb91b: Bug 1152625 - Support AES HW acceleration on ARMv8. r=kjacobs,jcj
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 11 Oct 2019 19:33:06 +0000 - rev 15330
Push 3529 by jjones@mozilla.com at Fri, 11 Oct 2019 19:34:03 +0000
Bug 1152625 - Support AES HW acceleration on ARMv8. r=kjacobs,jcj Differential Revision: https://phabricator.services.mozilla.com/D34473
9b418f0a4912e0a7c928d0b0774e1815238984ee: Bug 1549225 - Up front Signature Scheme validation, r=ueno
Martin Thomson <mt@lowentropy.net> - Fri, 06 Sep 2019 19:59:11 +1000 - rev 15329
Push 3528 by martin.thomson@gmail.com at Thu, 10 Oct 2019 06:46:49 +0000
Bug 1549225 - Up front Signature Scheme validation, r=ueno Summary: This patch started as an attempt to ensure that a DSA signature scheme would not be advertised if we weren't willing to negotiate versions less than TLS 1.3. Then I realized that we didn't do the same for PKCS#1 RSA. Then I realized that we were still willing to try to establish connections when we had a certificate that we couldn't use. Then I realized that ssl3_config_match_init() wasn't being run consistently. On resumption, we only ran it when we were PARANOID. That's silly because we weren't checking policies. Then I realized that we were allowing ECDSA certificates to be used when the named group in the certificate was disabled. We weren't enforcing that consistently either. However, I also discovered that the check we have wouldn't work without a tweak because in TLS 1.3 the named group is part of the signature scheme; the configured named groups are only used prior to TLS 1.3 when selecting ECDSA/ECDH certificates. So that sounds like a lot of changes but what it boils down to is more robust checking of the configuration prior to starting a connection. As a result, we should be offering fewer options that we're unwilling or unable to follow through on. A good number of tests needed tweaking as a result because we were relying on getting past the checks in those tests. No real problems were found as a result; this just moves failures that might arise from misconfiguration a little earlier in the process. Differential Revision: https://phabricator.services.mozilla.com/D45966
c319019aee75914fcbc8df0a530de7114e81229b: Bug 1586947 - Store nickname during EC key import. r=jcj
Kevin Jacobs <kjacobs@mozilla.com> - Tue, 08 Oct 2019 22:43:07 +0000 - rev 15328
Push 3527 by jjones@mozilla.com at Tue, 08 Oct 2019 22:43:47 +0000
Bug 1586947 - Store nickname during EC key import. r=jcj This patch stores the nickname (if specified) during EC key import. This was already done for all other key types. Differential Revision: https://phabricator.services.mozilla.com/D48459
b34061c3a377061f9508615551c09c5f5b66d144: Bug 1586456 - Unnecessary conditional in pki3hack, pk11load and stanpcertdb. r=jcj
Marcus Burghardt <mburghardt@mozilla.com> - Tue, 08 Oct 2019 00:32:05 +0000 - rev 15327
Push 3526 by jjones@mozilla.com at Tue, 08 Oct 2019 00:32:27 +0000
Bug 1586456 - Unnecessary conditional in pki3hack, pk11load and stanpcertdb. r=jcj Some conditionals that are always true were removed. Differential Revision: https://phabricator.services.mozilla.com/D48255
dc86215aea17672228b28cf3516da89a751cc24d: Bug 1576307 - Fixup for fips tests, permit NULL iv as necessary. r=jcj
Kevin Jacobs <kjacobs@mozilla.com> - Thu, 03 Oct 2019 00:23:47 +0000 - rev 15326
Push 3525 by jjones@mozilla.com at Thu, 03 Oct 2019 00:24:37 +0000
Bug 1576307 - Fixup for fips tests, permit NULL iv as necessary. r=jcj ECB mode should not require an IV. Differential Revision: https://phabricator.services.mozilla.com/D47990
71ca158e950af759e7f087dbc3342bfb528711f9: Added tag NSS_3_46_1_RTM for changeset 42682c941fd6 NSS_3_46_BRANCH
J.C. Jones <jjones@mozilla.com> - Wed, 02 Oct 2019 13:52:17 -0700 - rev 15325
Push 3524 by jjones@mozilla.com at Wed, 02 Oct 2019 21:47:02 +0000
Added tag NSS_3_46_1_RTM for changeset 42682c941fd6
42682c941fd6e8e89200aaa4adfa496d1102e03e: Set version numbers to 3.46.1 final NSS_3_46_BRANCH NSS_3_46_1_RTM
J.C. Jones <jjones@mozilla.com> - Wed, 02 Oct 2019 13:51:28 -0700 - rev 15324
Push 3524 by jjones@mozilla.com at Wed, 02 Oct 2019 21:47:02 +0000
Set version numbers to 3.46.1 final
f8dc0ce54c16b5094fcbea3befb1634cece457b0: Bug 1577953 - Support longer (up to RFC maximum) HKDF outputs r=jcj NSS_3_46_BRANCH
Kevin Jacobs <kjacobs@mozilla.com> - Tue, 01 Oct 2019 18:13:17 +0000 - rev 15323
Push 3524 by jjones@mozilla.com at Wed, 02 Oct 2019 21:47:02 +0000
Bug 1577953 - Support longer (up to RFC maximum) HKDF outputs r=jcj HKDF-Expand enforces a maximum output length much shorter than stated in the RFC. This patch aligns the implementation with the RFC by allocating more output space when necessary. Differential Revision: https://phabricator.services.mozilla.com/D45249
e2945c4342867ffb29000910df3a14f32a10a17e: Bug 1582343 - Use constant time memcmp in more places r=kjacobs,jcj NSS_3_46_BRANCH
Deian Stefan <deian@cs.ucsd.edu> - Thu, 26 Sep 2019 16:13:21 -0700 - rev 15322
Push 3524 by jjones@mozilla.com at Wed, 02 Oct 2019 21:47:02 +0000
Bug 1582343 - Use constant time memcmp in more places r=kjacobs,jcj
(0) -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip