dedf5290c679153e5b3555ba9c711fe62323c156: Bug 1278071 - Limit iterations for PKCS #12 export for Windows r?kaie
J.C. Jones <jjones@mozilla.com> - Fri, 23 Mar 2018 09:58:32 -0700 - rev 14298
Push 3034 by jjones@mozilla.com at Fri, 23 Mar 2018 17:21:47 +0000
Bug 1278071 - Limit iterations for PKCS #12 export for Windows r?kaie Per Bug 1436873, Windows is limited on importing PKCS12 files of 600k rounds or less. So for compatibility's sake, let's limit there, too.
1bde21f90bd1edaf52bc24e12593eba7b218452d: Bug 1447816 - Fix assignment where a comparison intended r=mt
J.C. Jones <jjones@mozilla.com> - Thu, 22 Mar 2018 07:13:05 -0700 - rev 14297
Push 3033 by jjones@mozilla.com at Thu, 22 Mar 2018 14:16:02 +0000
Bug 1447816 - Fix assignment where a comparison intended r=mt Summary: Coverity found an unintended assignment in dtls_GatherData in a PORT_Assert, which is only evaluated in debug builds. Reviewers: mt Reviewed By: mt Bug #: 1447816 Differential Revision: https://phabricator.services.mozilla.com/D787
da99ed4c1eb08981632b1f8f1503685eb2910008: Bug 1447825 - Check sslBuffer_Append in ssl_CallCustomExtensionSenders r=mt
J.C. Jones <jjones@mozilla.com> - Wed, 21 Mar 2018 15:07:11 -0700 - rev 14296
Push 3032 by jjones@mozilla.com at Thu, 22 Mar 2018 14:00:37 +0000
Bug 1447825 - Check sslBuffer_Append in ssl_CallCustomExtensionSenders r=mt Coverity caught that one use of sslBuffer_Append doesn't check the return, which is abnormal. Since cleanup is the same either way, it's a matter for OOM propagation. This adds the check in a minimal way.
c5dffd6269ea5f0796ad82950075a939c41cfaba: Bug 1446643 - Update to TLS 1.3 draft-26. r=mt
EKR <ekr@rtfm.com> - Thu, 15 Mar 2018 12:01:09 +0000 - rev 14295
Push 3031 by ekr@mozilla.com at Sat, 17 Mar 2018 15:34:21 +0000
Bug 1446643 - Update to TLS 1.3 draft-26. r=mt - Update version number - Forbid negotiating < TLS 1.3 with supported_versions - Change to version number 0303 after HRR. Plus test - Update AAD. https://phabricator.services.mozilla.com/D753
5bbce52d2929a82d14a3ba44ed54ef064d92730d: Bug 1427675 - Short header for DTLS 1.3, r=ekr
Martin Thomson <martin.thomson@gmail.com> - Fri, 16 Mar 2018 10:54:00 +0000 - rev 14294
Push 3030 by martin.thomson@gmail.com at Fri, 16 Mar 2018 11:40:55 +0000
Bug 1427675 - Short header for DTLS 1.3, r=ekr Summary: The code changes here are relatively straightforward, though there are a few changes of note: * To make read and write more consistent, I changed `seqNum` on ssl3CipherSpec `nextSeqNum`. The write side didn't change, but the read side previously saved the last sequence number in that slot. This makes the sequence number recovery simpler and makes the code easier to reason able as a whole. * SSL3Ciphertext now it holds the raw header and no longer has a type field. Passing the raw header through allows ssl3_HandleRecord and the functions that it calls to recover the sequence number. I considered doing the recovery in the gather functions, which used to recover the sequence number, but they don't have access to the cipher spec. * Record construction now works in order: the header is written out first, with the length filled in after encryption. This uses sslBuffer in a way more consistent with other functions. * The hack where a cText of NULL was passed to ssl3_HandleRecord in order to have it handle the outstanding handshake message from the receive buffer was removed. In addition to teaching TlsRecordFilter about the agent that it is operating with (in a separate CL), there are several changes to tests: * We previously relied on the epoch and sequence number being properly encoded for DTLS records, so the sequence number reconstruction (used when we decrypt and re-encrypt) was invalid. I restored the epoch to this field when doing DTLS. * TlsRecordHeader no longer stores the wire format of the version, it includes a variant and non-wire version. * TlsRecordHeader needs to know whether it is parsing DTLS 1.3, so TlsRecordFilter passes that info to it after asking the agent. * TlsRecordHeader writes out DTLS 1.3 records in the 7 octet form always. It can read the 2 octet header, using logic similar to that used by the main code, but it won't ever write that form. * TlsAgentTestBase::MakeRecord also writes the 7 octet header. * I parameterized the record drop tests so that I could test out of order delivery and various patterns with the short header. This revealed some issues, including one good one. I had a neat underflow bug that can happen near zero, which leads to ridiculously large sequence numbers being incorrectly assumed by a receiver. This includes fuzzing-specific changes to account for the fact that fuzzing operates at the record layer, which is inconvenient for this change. Ideally, we should change the fuzzing code so that only the core cipher parts are changed (that is, ssl3CipherSpec->cipher and ssl3CipherSpec->aead). That will have to wait for another day. Reviewers: ekr Reviewed By: ekr Bug #: 1427675 Differential Revision: https://phabricator.services.mozilla.com/D554
3008d1dbd8fc55ff06d985a1b062ee101c9036b7: Bug 1445989, Don't skip ECC tests in ssl.sh, r=kaie
Daiki Ueno <dueno@redhat.com> - Thu, 15 Mar 2018 14:32:34 +0100 - rev 14293
Push 3029 by dueno@redhat.com at Fri, 16 Mar 2018 07:58:48 +0000
Bug 1445989, Don't skip ECC tests in ssl.sh, r=kaie
35f951089cbc8af02b8bdd94d86f654b1545a8c0: Bug 1446100: Add range-check & cast to PR_Write result, to address build warning. r=kaie
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 15 Mar 2018 20:56:32 +0100 - rev 14292
Push 3028 by kaie@kuix.de at Thu, 15 Mar 2018 19:55:38 +0000
Bug 1446100: Add range-check & cast to PR_Write result, to address build warning. r=kaie
f0d4789c89169de0641b8b4e8b7cd2cec015d4dd: Bug 1441219 - always compile FStar to have it available on 32-bit non-intel platforms, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Thu, 15 Mar 2018 09:19:17 +0100 - rev 14291
Push 3027 by franziskuskiefer@gmail.com at Thu, 15 Mar 2018 08:23:01 +0000
Bug 1441219 - always compile FStar to have it available on 32-bit non-intel platforms, r=ttaubert Differential Revision: https://phabricator.services.mozilla.com/D735
1053cc7b45a2dfe4a44558f0a0e7c4b3f0e9c6ec: Bug 1444960, Exercise SSL tests which only run under non-FIPS, r=kaie
Daiki Ueno <dueno@redhat.com> - Mon, 12 Mar 2018 18:29:03 +0100 - rev 14290
Push 3026 by dueno@redhat.com at Wed, 14 Mar 2018 08:28:49 +0000
Bug 1444960, Exercise SSL tests which only run under non-FIPS, r=kaie
be88b7a4fb599a367a13688a9790d3010f3b3692: Bug 1443400 - Don't use getauxval() when not available, r=franziskus
Jan Beich <jbeich@FreeBSD.org> - Fri, 09 Mar 2018 11:52:00 +0100 - rev 14289
Push 3025 by franziskuskiefer@gmail.com at Tue, 13 Mar 2018 14:03:13 +0000
Bug 1443400 - Don't use getauxval() when not available, r=franziskus
d7331353ee3736f64fe4f37af990a52520eb6564: Bug 1413596, Preserve private-key info in PKCS #8 when wrapping
Daiki Ueno <dueno@redhat.com> - Thu, 08 Mar 2018 10:21:39 +0100 - rev 14288
Push 3024 by dueno@redhat.com at Thu, 08 Mar 2018 14:55:28 +0000
Bug 1413596, Preserve private-key info in PKCS #8 when wrapping Summary: Previously, NSS dropped PKCS #8 PrivateKeyInfo when importing a private key from a PKCS #12 file. This patch attaches the corresponding CKA_PUBLIC_KEY_INFO attribute to a private key when unwrapping it (see PKCS #11 v2.40 4.9). When wrapping it again, the attribute is restored in the encrypted PrivateKeyInfo. Reviewers: rrelyea Reviewed By: rrelyea Bug #: 1413596 Differential Revision: https://phabricator.services.mozilla.com/D198
48c5fc260bcc16b350fce6eb6a60eb4897866cee: Bug 1443799 - Update BoGo to a runner that supports draft-23 r=franziskus
Tim Taubert <ttaubert@mozilla.com> - Thu, 08 Mar 2018 09:56:58 +0100 - rev 14287
Push 3023 by ttaubert@mozilla.com at Thu, 08 Mar 2018 09:05:53 +0000
Bug 1443799 - Update BoGo to a runner that supports draft-23 r=franziskus Reviewers: franziskus Reviewed By: franziskus Bug #: 1443799 Differential Revision: https://phabricator.services.mozilla.com/D696
517129fa29bdfe2c3938a8880a819f547e39a62a: Bug 1443759 - Fix clang-format bustage r=me
Tim Taubert <ttaubert@mozilla.com> - Wed, 07 Mar 2018 14:48:08 +0100 - rev 14286
Push 3022 by ttaubert@mozilla.com at Wed, 07 Mar 2018 13:48:59 +0000
Bug 1443759 - Fix clang-format bustage r=me
acbdae88853ea036965c74e40d2c492bdb7a5115: Bug 1443759 - Fix our BoGo shim's signing-prefs switch r=franziskus
Tim Taubert <ttaubert@mozilla.com> - Wed, 07 Mar 2018 14:23:33 +0100 - rev 14285
Push 3021 by ttaubert@mozilla.com at Wed, 07 Mar 2018 13:23:57 +0000
Bug 1443759 - Fix our BoGo shim's signing-prefs switch r=franziskus Reviewers: franziskus Reviewed By: franziskus Bug #: 1443759 Differential Revision: https://phabricator.services.mozilla.com/D692
3cc8e99d905970050a1d4eb62764c457c3fbaac8: Bug 1443136 - Fix build and clang-format bustage r=me
Tim Taubert <ttaubert@mozilla.com> - Tue, 06 Mar 2018 10:28:11 +0100 - rev 14284
Push 3020 by ttaubert@mozilla.com at Tue, 06 Mar 2018 09:29:24 +0000
Bug 1443136 - Fix build and clang-format bustage r=me
e9b2a26297daab9b4e237b1292d3de313102ff96: Bug 1443136 - Add support for signature scheme preferences in BoGo r=franziskus,ekr
Tim Taubert <ttaubert@mozilla.com> - Tue, 06 Mar 2018 10:14:59 +0100 - rev 14283
Push 3019 by ttaubert@mozilla.com at Tue, 06 Mar 2018 09:15:43 +0000
Bug 1443136 - Add support for signature scheme preferences in BoGo r=franziskus,ekr Reviewers: franziskus, ekr Reviewed By: franziskus Bug #: 1443136 Differential Revision: https://phabricator.services.mozilla.com/D676
620af5fe20ad116ceb2c3da2be931dc694176c3a: Bug 1424663 - update HACL* version, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Tue, 06 Mar 2018 08:57:41 +0100 - rev 14282
Push 3018 by franziskuskiefer@gmail.com at Tue, 06 Mar 2018 09:04:24 +0000
Bug 1424663 - update HACL* version, r=ttaubert Unbreak VS2015 32-bit, see bug 1442554. Differential Revision: https://phabricator.services.mozilla.com/D678
eb5b400ffc1b2010a078572e58398a2067b75ff4: Bug 1441219 - HACL* poly1305 32-bit, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Mon, 26 Feb 2018 16:09:56 +0100 - rev 14281
Push 3017 by franziskuskiefer@gmail.com at Tue, 06 Mar 2018 07:46:18 +0000
Bug 1441219 - HACL* poly1305 32-bit, r=ttaubert Differential Revision: https://phabricator.services.mozilla.com/D649
994195935af65cd8d06bfe977ec9cc9d54bdf018: Added tag NSS_3_36_RTM for changeset 33317adf00d6 NSS_3_36_BRANCH
Kai Engert <kaie@kuix.de> - Mon, 05 Mar 2018 16:59:06 +0100 - rev 14280
Push 3016 by kaie@kuix.de at Mon, 05 Mar 2018 15:58:24 +0000
Added tag NSS_3_36_RTM for changeset 33317adf00d6 DONTBUILD
33317adf00d6bc6c3e3499e4b32fca6b899c4b77: set version numbers to 3.36 final NSS_3_36_BRANCH NSS_3_36_RTM
Kai Engert <kaie@kuix.de> - Mon, 05 Mar 2018 16:58:32 +0100 - rev 14279
Push 3016 by kaie@kuix.de at Mon, 05 Mar 2018 15:58:24 +0000
set version numbers to 3.36 final DONTBUILD
(0) -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 tip