author David Keeler <>
Thu, 12 Oct 2017 13:22:47 +0200
changeset 14039 f3766809817ba03aa8cc1da4fdf48bd011fc01e3
parent 12461 5430165f67fd4157fc19899a102c3a95b48a708f
child 15366 6619bb43d746307df1db57bdd5bbaa17aaec6337
permissions -rw-r--r--
Bug 1405522 - Fix authenticated attribute migration under password changes in the sql DBs r=ttaubert Summary: The underlying issue is that the sqlite-backed DB format stores CK_ULONG values in a machine-independent format, meaning it has to translate back and forth when running on a machine where CK_ULONG is not the same size (or endianness, presumably) as the stored format. Before this patch, both sftkdb_SetAttributeValue and sftk_updateMacs did not use the machine-independent format in the correct places. This manifested in a bug where if the password was changed, certificate trust settings would be reset to "untrusted". Bug #: 1405522 Differential Revision:

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#ifndef SFTKDBTI_H
#define SFTKDBTI_H 1

 * private defines
struct SFTKDBHandleStr {
    SDB *db;
    PRInt32 ref;
    SECItem passwordKey;
    SECItem *newKey;
    SECItem *oldKey;
    SECItem *updatePasswordKey;
    PZLock *passwordLock;
    SFTKDBHandle *peerDB;
    SDB *update;
    char *updateID;
    PRBool updateDBIsInit;

#define SFTK_KEYDB_TYPE 0x40000000
#define SFTK_CERTDB_TYPE 0x00000000
#define SFTK_OBJ_TYPE_MASK 0xc0000000
#define SFTK_TOKEN_TYPE 0x80000000

/* the following is the number of id's to handle on the stack at a time,
 * it's not an upper limit of IDS that can be stored in the database */
#define SFTK_MAX_IDS 10

#define SFTK_GET_SDB(handle) \
    ((handle)->update ? (handle)->update : (handle)->db)

SECStatus sftkdb_DecryptAttribute(SECItem *passKey, SECItem *cipherText,
                                  SECItem **plainText);
SECStatus sftkdb_EncryptAttribute(PLArenaPool *arena, SECItem *passKey,
                                  SECItem *plainText, SECItem **cipherText);
SECStatus sftkdb_SignAttribute(PLArenaPool *arena, SECItem *passKey,
                               CK_OBJECT_HANDLE objectID,
                               CK_ATTRIBUTE_TYPE attrType,
                               SECItem *plainText, SECItem **sigText);
SECStatus sftkdb_VerifyAttribute(SECItem *passKey,
                                 CK_OBJECT_HANDLE objectID,
                                 CK_ATTRIBUTE_TYPE attrType,
                                 SECItem *plainText, SECItem *sigText);

PRBool sftkdb_isULONGAttribute(CK_ATTRIBUTE_TYPE type);
void sftk_ULong2SDBULong(unsigned char *data, CK_ULONG value);
CK_RV sftkdb_Update(SFTKDBHandle *handle, SECItem *key);
CK_RV sftkdb_PutAttributeSignature(SFTKDBHandle *handle,
                                   SDB *keyTarget, CK_OBJECT_HANDLE objectID,
                                   CK_ATTRIBUTE_TYPE type, SECItem *signText);