searching for reviewer(bnicholson)
f5b683c6c69aed320bf72e0bcdcd964c15c3f694: Bug 1041448 - Fix crash when double-tapping on empty top site spot. r=bnicholson, a=lmandel
Lucas Rocha <lucasr@mozilla.com> - Tue, 09 Sep 2014 11:04:12 +0100 - rev 217491
Bug 1041448 - Fix crash when double-tapping on empty top site spot. r=bnicholson, a=lmandel
9be2c92a3f288dbfe3407e918ff274f37800f749: Bug 1057438 - Only re-create LinearGradient when necessary. r=bnicholson, a=lmandel
Lucas Rocha <lucasr@mozilla.com> - Tue, 02 Sep 2014 10:52:08 +0100 - rev 217373
Bug 1057438 - Only re-create LinearGradient when necessary. r=bnicholson, a=lmandel
37a1ea2973dd60a290396de193bf48cad8358c0f: Bug 1057634 - Use localized string for default search engine identifier. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 29 Aug 2014 12:06:01 -0700 - rev 216922
Bug 1057634 - Use localized string for default search engine identifier. r=bnicholson
54cafb17e8bc5c67d45bc8a5f0c770ecc97d7934: Bug 1057629 - Use search plugins that ship with Fennec to populate options in search activity settings. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 29 Aug 2014 12:05:58 -0700 - rev 216921
Bug 1057629 - Use search plugins that ship with Fennec to populate options in search activity settings. r=bnicholson
62498bd570c817bf303d666a8c44b68546e8e528: Bug 1058160 - Make o.m.g.BrowserApp LAUNCHER activity default and high priority. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Fri, 29 Aug 2014 11:51:46 -0700 - rev 216919
Bug 1058160 - Make o.m.g.BrowserApp LAUNCHER activity default and high priority. r=bnicholson In order to launch in response to the MAIN activity (via |adb shell am start -a android.intent.action.MAIN org.mozilla.fennec|, for example), the activity must have category default. That is added automatically to <activity> elements that have category LAUNCHER, but apparently not to <activity-alias> elements. This patch adds it manually. In general, <intent-filters> are prioritized by their order in the manifest file. To avoid future confusion, this patch bumps the android:priority of the existing filter.
36bc6b13ac2c8344f7f8d97513d4fcb8460aa004: Bug 1054303 - Use open search plugins for search engines. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Mon, 25 Aug 2014 15:28:11 -0700 - rev 215882
Bug 1054303 - Use open search plugins for search engines. r=bnicholson
176ee3cee1ca9b27b85de8a350133779e51508c5: Bug 1052387 - Don't save session history if clearing history on exit. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Thu, 21 Aug 2014 11:35:16 -0700 - rev 215165
Bug 1052387 - Don't save session history if clearing history on exit. r=bnicholson
7aef335d66275e2c6421dd9c0b1f64bee8095070: Bug 1048444 - Don't store searches that happen in private browsing mode. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 14 Aug 2014 11:39:25 -0700 - rev 213910
Bug 1048444 - Don't store searches that happen in private browsing mode. r=bnicholson
f8fb26b28dea244901beb81b4fa71bdbc4b6c539: Bug 1053494 - Android Eclipse support for Android v7 support libraries and Play Services. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Thu, 14 Aug 2014 11:28:31 -0700 - rev 213909
Bug 1053494 - Android Eclipse support for Android v7 support libraries and Play Services. r=bnicholson
ebba69aab4e2c1d6d961ac7d2a38b7687d752b47: Bug 1052889 - Make Android Eclipse generate R.java. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Thu, 14 Aug 2014 11:28:27 -0700 - rev 213908
Bug 1052889 - Make Android Eclipse generate R.java. r=bnicholson This patch does two things. First, it adds the Search Activity sources to the main Fennec Eclipse project (when enabled). There's no reason for a separate project for these, since they are built as part of the main Fennec package by moz.build. Second, it arranges for Eclipse to generate the R.java and Manifest.java files for all Android libraries and ignores the files generated by moz.build. (The relevant classes are org.mozilla.{gecko,search}.R.) This means renaming the FennecResources Eclipse project's package to org.mozilla.gecko, and renaming the FennecResourcesSearch project's package to org.mozilla.search. To be consistent, I switched org.mozilla.fennec.resources to org.mozilla.gecko throughout. To accommodate the crash reporter resources, which depend on the static and generated resources, I added a layer of indirection. By moving the main resources into project FennecResourcesStatic, we can have (reading indentation as "depends on"): FennecResources FennecResourcesCrashReporter FennecResourcesStatic FennecResourcesGenerated FennecResourcesBranding This lets us break the bidirectional dependency between FennecResources and FennecResourcesCrashReporter.
7bd97e67037c45ec6a9047ebebe9eaa7c29b22b0: Bug 1052288 - Move PageActions to a jsm module. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Wed, 13 Aug 2014 21:38:37 -0700 - rev 213887
Bug 1052288 - Move PageActions to a jsm module. r=bnicholson
f47e1ba9ceca0371da6cffa7b81f1f674a2e751f: Bug 1048000 - Expect undefined for non-matching regex groups. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Wed, 13 Aug 2014 14:53:34 -0700 - rev 213755
Bug 1048000 - Expect undefined for non-matching regex groups. r=bnicholson
5853d370248d3193b18cbc8d7aa25383c9a63a87: Bug 1044133 - Add NineOldAndroids animation library to the tree. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 25 Jul 2014 15:20:13 -0700 - rev 210627
Bug 1044133 - Add NineOldAndroids animation library to the tree. r=bnicholson
476a0455e0e816fe60cc1a6d0dfb893400873041: Bug 1018240 - Part 2: invalidate BrowserSearch engine list when locale has changed. r=bnicholson
Richard Newman <rnewman@mozilla.com> - Mon, 21 Jul 2014 10:54:58 -0700 - rev 209651
Bug 1018240 - Part 2: invalidate BrowserSearch engine list when locale has changed. r=bnicholson
a3f65bfb35a3b0ab7893dbc206cd841ae79de8e1: Bug 1052387 - Don't save session history if clearing history on exit. r=bnicholson a=sylvestre
Wes Johnston <wjohnston@mozilla.com> - Thu, 21 Aug 2014 11:35:16 -0700 - rev 209520
Bug 1052387 - Don't save session history if clearing history on exit. r=bnicholson a=sylvestre
eb429fd7d9c2778fdcac6b254947c5e746b6b0db: Bug 1048444 - Don't store searches that happen in private browsing mode. r=bnicholson, a=sledru
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 14 Aug 2014 11:39:25 -0700 - rev 209388
Bug 1048444 - Don't store searches that happen in private browsing mode. r=bnicholson, a=sledru
3adc5ff487a6d2db21ef4bd02dad84068d264413: Bug 1018240 - Part 2: Invalidate BrowserSearch engine list when locale has changed. r=bnicholson, a=sledru
Richard Newman <rnewman@mozilla.com> - Mon, 21 Jul 2014 10:54:58 -0700 - rev 209133
Bug 1018240 - Part 2: Invalidate BrowserSearch engine list when locale has changed. r=bnicholson, a=sledru
00b81ba0835a987a2e46805a3b6c24387351c02a: Bug 1001309 - Provide a way to clear private data on Exit. r=liuche, bnicholson, mcomella
Wes Johnston <wjohnston@mozilla.com> - Thu, 19 Jun 2014 00:04:00 -0700 - rev 208861
Bug 1001309 - Provide a way to clear private data on Exit. r=liuche, bnicholson, mcomella
67ae43394166e536dce4c816b822f40c1534d611: Bug 1032217 - Export gecko.{WebApp,BrowserApp}. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Fri, 18 Jul 2014 09:39:56 -0700 - rev 208707
Bug 1032217 - Export gecko.{WebApp,BrowserApp}. r=bnicholson This allows explicit intents from outside of the App. Tested locally by: * creating and launching a home screen shortcut; (the presenting issue) * trying a an "old style" webapp home screen launch, like: adb shell am start -a org.mozilla.gecko.WEBAPP -n org.mozilla.fennec_nalexander/.Webapp -d http://penguinpop.justplaymobile.com/penguinpop.webapp and adb shell am start -a org.mozilla.gecko.WEBAPP -n org.mozilla.fennec_nalexander/org.mozilla.gecko.Webapp -d http://penguinpop.justplaymobile.com/penguinpop.webapp Both log the expected message in the dispatcher: W GeckoWebappImpl(12501) no package name; treating as legacy shortcut Both fail with: E GeckoConsole(12177) Error getting pref for application/x-web-app-manifest+json. I verified that this behaviour happens with the Nightly of June 24, 2014 -- the one right before the patch that introduced this regression.
91e7ba697b14b450935c0161b23c07aeb93e8f2a: Bug 1001309 - Provide a way to clear private data on Exit. r=liuche, bnicholson
Wes Johnston <wjohnston@mozilla.com> - Thu, 19 Jun 2014 00:04:00 -0700 - rev 208450
Bug 1001309 - Provide a way to clear private data on Exit. r=liuche, bnicholson
a794759a5272b1edd8cef2edb33b5d68967242d1: Bug 1039738 - Correct private tabs list appearance. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Wed, 16 Jul 2014 16:35:49 -0700 - rev 208391
Bug 1039738 - Correct private tabs list appearance. r=bnicholson
61c29af88d35b090f639908bf9fd94026a0d2643: Bug 1038798 - Regression: After closing all tabs, tabs tray dotted menu can not be accessed again. r=bnicholson
Chenxia Liu <liuche@mozilla.com> - Tue, 15 Jul 2014 14:17:53 -0700 - rev 208124
Bug 1038798 - Regression: After closing all tabs, tabs tray dotted menu can not be accessed again. r=bnicholson
6ee3c3ba17b589a7dd9faa33bdeffdf3823d158d: Bug 1004495 - Revamp notification handlers to work when Gecko is not running. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Fri, 27 Jun 2014 13:25:00 -0700 - rev 208101
Bug 1004495 - Revamp notification handlers to work when Gecko is not running. r=bnicholson
4ecf47ef0ed2e7e57b4cd70c0798c083aa783e3c: Bug 1037217 - Listen for DOMLinkChanged as well as DOMLinkAdded to update favicons r=bnicholson
Mark Finkle <mfinkle@mozilla.com> - Sat, 12 Jul 2014 09:44:28 -0400 - rev 207576
Bug 1037217 - Listen for DOMLinkChanged as well as DOMLinkAdded to update favicons r=bnicholson
a05f8bb2e87695d68c1ebb0b124dc380f634bafc: Bug 1014181 - Use GeckoMenuItem in ActionBarCompat. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Wed, 25 Jun 2014 12:37:22 -0700 - rev 204701
Bug 1014181 - Use GeckoMenuItem in ActionBarCompat. r=bnicholson
0edc7c486fecc43b4b3010629c6d38db5d395d92: Bug 1029232 - Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Tue, 24 Jun 2014 19:14:35 -0700 - rev 204451
Bug 1029232 - Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson
a4f39c9db1d9dba6659a26bc96ebb43b8710e06c: Bug 929865 - Part 3: Replace org.mozilla.gecko.App with BrowserApp. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Tue, 24 Jun 2014 18:20:13 -0700 - rev 204443
Bug 929865 - Part 3: Replace org.mozilla.gecko.App with BrowserApp. r=bnicholson
457213f9d86736c192847fafcd13735d4652afb5: Bug 929865 - Part 2: Use <activity-alias> to wrap activities in generated namespace. r=bnicholson,myk
Nick Alexander <nalexander@mozilla.com> - Tue, 24 Jun 2014 18:20:13 -0700 - rev 204442
Bug 929865 - Part 2: Use <activity-alias> to wrap activities in generated namespace. r=bnicholson,myk
0d67da636065e5d41d4e7269c51173f329ac7fb4: Bug 1004850 - (Part 5) Add recently closed tabs to RecentTabsPanel. r=lucasr,bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Sun, 22 Jun 2014 16:26:49 -0400 - rev 203630
Bug 1004850 - (Part 5) Add recently closed tabs to RecentTabsPanel. r=lucasr,bnicholson
426fabc9a7fa448836c5ecd54480226ef0d9a078: Bug 1027831 - Switch from deprecated FILL_PARENT to MATCH_PARENT in Java and XML. r=bnicholson
Hathibelagal A <hathymo@yahoo.com> - Fri, 20 Jun 2014 09:21:31 -0700 - rev 203608
Bug 1027831 - Switch from deprecated FILL_PARENT to MATCH_PARENT in Java and XML. r=bnicholson
cb5d611cce01fe8982135cab5608ec41f0f24108: Bug 817716 - (Part 2) Add 3-dot menu for tabs tray on tablets. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 19 Jun 2014 08:37:33 -0400 - rev 203385
Bug 817716 - (Part 2) Add 3-dot menu for tabs tray on tablets. r=bnicholson
164923fd51c6de1de52a2297a72aa10a20b4ef97: Bug 817716 - (Part 1) Add 3-dot menu to tabs panel, including a "close all tabs" option. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 19 Jun 2014 08:37:32 -0400 - rev 203384
Bug 817716 - (Part 1) Add 3-dot menu to tabs panel, including a "close all tabs" option. r=bnicholson
5be519918f6509c7fe92e511fae3fc00c72bfdeb: Bug 1026347 - Session:Prefetch should watch for empty nsIURI.host r=bnicholson
Mark Finkle <mfinkle@mozilla.com> - Tue, 17 Jun 2014 09:52:37 -0400 - rev 202880
Bug 1026347 - Session:Prefetch should watch for empty nsIURI.host r=bnicholson
4ff51fc48fa3bc2b3fef63388aa95700a89ba354: Bug 1026347 - Session:Prefetch should watch for empty nsIURI.host r=bnicholson
Mark Finkle <mfinkle@mozilla.com> - Tue, 17 Jun 2014 09:52:37 -0400 - rev 202875
Bug 1026347 - Session:Prefetch should watch for empty nsIURI.host r=bnicholson
595c7791bb167d8a7d751f26646dabc253f9772c: Bug 964861 - Don't update the toolbar state before it gets attached (r=bnicholson)
Lucas Rocha <lucasr@mozilla.com> - Tue, 17 Jun 2014 14:29:31 +0100 - rev 202874
Bug 964861 - Don't update the toolbar state before it gets attached (r=bnicholson)
b136d95a45b29bcb3af4a61dc8a91ad91f018192: Bug 964861 - Don't update the toolbar state before it gets attached (r=bnicholson)
Lucas Rocha <lucasr@mozilla.com> - Fri, 13 Jun 2014 10:56:53 +0100 - rev 202489
Bug 964861 - Don't update the toolbar state before it gets attached (r=bnicholson)
8ef009362d13c3fe164c865d8b9d9766767673b1: Bug 1007442 - Part 1: Add scrolling to remote tabs tray where applicable. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 Jun 2014 14:31:10 -0700 - rev 202114
Bug 1007442 - Part 1: Add scrolling to remote tabs tray where applicable. r=bnicholson
e9a025ac70fe1f1c64849b3c4cde604ca1f50035: Bug 817716 - Add 3-dot menu to tabs panel, including a "close all tabs" option. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 Jun 2014 11:14:26 -0700 - rev 201982
Bug 817716 - Add 3-dot menu to tabs panel, including a "close all tabs" option. r=bnicholson
e1b73deedcb4510a03615fc1e364ac912805b938: Bug 964861 - Don't update the toolbar state before it gets attached. r=bnicholson, a=sledru
Lucas Rocha <lucasr@mozilla.com> - Tue, 17 Jun 2014 14:29:31 +0100 - rev 201292
Bug 964861 - Don't update the toolbar state before it gets attached. r=bnicholson, a=sledru
0b836bae4fd20507ac6a354b5db06364ad44e6f5: Bug 1014181 - Use GeckoMenuItem in ActionBarCompat. r=bnicholson, a=sledru
Wes Johnston <wjohnston@mozilla.com> - Wed, 25 Jun 2014 12:37:22 -0700 - rev 200729
Bug 1014181 - Use GeckoMenuItem in ActionBarCompat. r=bnicholson, a=sledru
44ef5ff8a390466dfdf87cee2eb7ab7fc0e84f75: Bug 1007442 - Part 1: Add scrolling to remote tabs tray where applicable. r=bnicholson, a=lmandel
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 Jun 2014 14:31:10 -0700 - rev 200390
Bug 1007442 - Part 1: Add scrolling to remote tabs tray where applicable. r=bnicholson, a=lmandel
f6d22cf586e140f9d549723fec8aa62edb2f9602: Bug 1023406 - Disable undo close tab toast for Fx32. r=bnicholson a=lsblakk
Margaret Leibovic <margaret.leibovic@gmail.com> - Tue, 10 Jun 2014 10:55:47 -0700 - rev 200251
Bug 1023406 - Disable undo close tab toast for Fx32. r=bnicholson a=lsblakk
7bb8f92028d92b160a8798f4a70e29c3eacedc25: Bug 1020730 - If there's no title to show in undo close tab toast, just say "Closed tab". r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 06 Jun 2014 11:52:46 -0700 - rev 199655
Bug 1020730 - If there's no title to show in undo close tab toast, just say "Closed tab". r=bnicholson
82cdfd1b391408e60b25752900d850674f35c135: Bug 1019595 - Use light cancel edit button with dark lightweight themes. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 05 Jun 2014 11:58:17 -0700 - rev 199423
Bug 1019595 - Use light cancel edit button with dark lightweight themes. r=bnicholson
0dc1743249550e578e3aca7fb980501729a252f0: Bug 1017912 - Restore tab in correct position when undoing close tab. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 04 Jun 2014 19:10:25 -0700 - rev 199250
Bug 1017912 - Restore tab in correct position when undoing close tab. r=bnicholson
80a57d37adcb84ac08bf4a6159dbc8d7de51827f: Bug 1018661 - Use session store data instead of current browser data for undo close tab toast. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 04 Jun 2014 19:10:05 -0700 - rev 199249
Bug 1018661 - Use session store data instead of current browser data for undo close tab toast. r=bnicholson
890e30bcb834b7e79a2b6016346aaaaffc63d28a: Bug 1017047 - Properly restore private/desktopMode state of tab when undo-ing close tab. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 30 May 2014 16:04:59 -0700 - rev 198473
Bug 1017047 - Properly restore private/desktopMode state of tab when undo-ing close tab. r=bnicholson
d4e013191816bc213942eee3d2962b3df337c952: Bug 1006209 - Remove mistakenly referenced projects from Android Eclipse projects. r=bnicholson
Nick Alexander <nalexander@mozilla.com> - Wed, 28 May 2014 15:45:35 -0700 - rev 197899
Bug 1006209 - Remove mistakenly referenced projects from Android Eclipse projects. r=bnicholson DONTBUILD NPOTB
dc94e2a05c97b689a2473485f767d495d651b2bd: Bug 1014988 - Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases. r=bnicholson
Richard Newman <rnewman@mozilla.com> - Wed, 28 May 2014 14:53:59 -0700 - rev 197892
Bug 1014988 - Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases. r=bnicholson
626f73b5a4f8a212b1d98bb61ca3be3349d55a5e: Bug 998009 - (Part 2) Give background color a more generic variable name. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 28 May 2014 12:06:59 -0700 - rev 197875
Bug 998009 - (Part 2) Give background color a more generic variable name. r=bnicholson