Bug 532176: Fix 'make jstestbrowser EXTRA_TEST_ARGS=...'; allow command line to override test list. r=bclary
authorJim Blandy <jimb@mozilla.org>
Thu, 03 Dec 2009 09:27:26 -0800
changeset 35469 88a2ea2b2ca1f67f74d3d90572847a1ed778c676
parent 35468 860a5885545390b4991dfb79973c751fe56e988f
child 35470 c27f496d0d7a1d8aeea25c6c4f9c5d6efb83f890
push idunknown
push userunknown
push dateunknown
reviewersbclary
bugs532176
milestone1.9.3a1pre
Bug 532176: Fix 'make jstestbrowser EXTRA_TEST_ARGS=...'; allow command line to override test list. r=bclary
testing/testsuite-targets.mk
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -91,19 +91,19 @@ reftest:
 	$(call RUN_REFTEST,$(topsrcdir)/$(TEST_PATH))
 	$(CHECK_TEST_ERROR)
 
 crashtest: TEST_PATH=testing/crashtest/crashtests.list
 crashtest:
 	$(call RUN_REFTEST,$(topsrcdir)/$(TEST_PATH))
 	$(CHECK_TEST_ERROR)
 
-jstestbrowser: EXTRA_TEST_ARGS += --extra-profile-file=$(topsrcdir)/js/src/tests/user.js
+jstestbrowser: TEST_PATH=js/src/tests/jstests.list
 jstestbrowser:
-	$(call RUN_REFTEST,$(topsrcdir)/js/src/tests/jstests.list)
+	$(call RUN_REFTEST,$(topsrcdir)/$(TEST_PATH) --extra-profile-file=$(topsrcdir)/js/src/tests/user.js)
 	$(CHECK_TEST_ERROR)
 
 # Execute all xpcshell tests in the directories listed in the manifest.
 # See also config/rules.mk 'xpcshell-tests' target for local execution.
 # Usage: |make [TEST_PATH=...] [EXTRA_TEST_ARGS=...] xpcshell-tests|.
 xpcshell-tests:
 	$(PYTHON) -u $(topsrcdir)/config/pythonpath.py \
 	  -I$(topsrcdir)/build \