Bug 1557296: replace "IsBlackAndDoesNotNeedTracing" with "HasKnownLiveWrapperAndDoesNotNeedTracing" in nsCycleCollectionParticipant's documentation
authorMirko Brodesser <mbrodesser@mozilla.com>
Thu, 06 Jun 2019 11:41:43 +0200
changeset 478285 6069a12f06aad893eb89d08ab6c4e9e4db45fc97
parent 478284 61dee4121753ac1568cadbacb334236c95735a63
child 478286 2f493b1b18cfa0a4b196149bf70309822a85b712
push id5
push uservporof@mozilla.com
push dateWed, 12 Jun 2019 10:24:37 +0000
bugs1557296
milestone69.0a1
Bug 1557296: replace "IsBlackAndDoesNotNeedTracing" with "HasKnownLiveWrapperAndDoesNotNeedTracing" in nsCycleCollectionParticipant's documentation Because the latter method was renamed some time ago to the former. Differential Revision: https://phabricator.services.mozilla.com/D33943
xpcom/base/nsCycleCollectionParticipant.h
--- a/xpcom/base/nsCycleCollectionParticipant.h
+++ b/xpcom/base/nsCycleCollectionParticipant.h
@@ -173,25 +173,25 @@ class NS_NO_VTABLE nsCycleCollectionPart
   // CanSkipInCC is allowed to remove other objects from the purple buffer but
   // should not remove aPtr and should not mark JS things black.  It should also
   // not modify any reference counts.
   //
   // Things can return true from CanSkipInCC if either they know they have no
   // outgoing edges at all in the cycle collection graph or they know for sure
   // they're alive _and_ none of their outgoing edges are to gray (in the GC
   // sense) gcthings.  See also nsWrapperCache::HasNothingToTrace and
-  // nsWrapperCache::IsBlackAndDoesNotNeedTracing.  The restriction on not
-  // having outgoing edges to gray gcthings is because if we _do_ have them that
-  // means we have a "strong" edge to a JS thing and since we're alive we need
-  // to trace through it and mark keep them alive.  Outgoing edges to C++ things
-  // don't matter here, because the criteria for when a CC participant is
-  // considered alive are slightly different for JS and C++ things: JS things
-  // are only considered alive when reachable via an edge from a live thing,
-  // while C++ things are also considered alive when their refcount exceeds the
-  // number of edges via which they are reachable.
+  // nsWrapperCache::HasKnownLiveWrapperAndDoesNotNeedTracing. The restriction
+  // on not having outgoing edges to gray gcthings is because if we _do_ have
+  // them that means we have a "strong" edge to a JS thing and since we're alive
+  // we need to trace through it and mark keep them alive.  Outgoing edges to
+  // C++ things don't matter here, because the criteria for when a CC
+  // participant is considered alive are slightly different for JS and C++
+  // things: JS things are only considered alive when reachable via an edge from
+  // a live thing, while C++ things are also considered alive when their
+  // refcount exceeds the number of edges via which they are reachable.
   bool CanSkipInCC(void* aPtr) {
     return mMightSkip ? CanSkipInCCReal(aPtr) : false;
   }
 
   // CanSkipThis is called during construction of the cycle collector graph,
   // when we traverse an edge to aPtr and consider adding it to the graph.  If
   // it returns true, aPtr is not added to the graph.
   //