Bug 1521599 - Delete the failures data after it has been output. r=Gijs
authorJared Wein <jwein@mozilla.com>
Thu, 31 Jan 2019 23:40:33 +0000
changeset 456386 36d845cdb7f0c001f0a8c38e87a41f8bceb71b3a
parent 456385 e7930893f8f0c64d1bbad3d87f9c397ad9eb7fd0
child 456387 d6cd114bf585f724c94c3b97959785230911cd51
push id19
push usermdeboer@mozilla.com
push dateFri, 01 Feb 2019 10:05:45 +0000
reviewersGijs
bugs1521599
milestone67.0a1
Bug 1521599 - Delete the failures data after it has been output. r=Gijs The failures were remaining in the data object, which later had any remaining keys printed in the diagnostics section. This bug was introduced because we stopped using Array objects to generate formatted strings. In the previous code, this would have ended up just printing out the first failure listed in the diagnostics section (a partial duplicate of the actual Failure Log). Differential Revision: https://phabricator.services.mozilla.com/D18289
toolkit/content/aboutSupport.js
--- a/toolkit/content/aboutSupport.js
+++ b/toolkit/content/aboutSupport.js
@@ -391,16 +391,17 @@ var snapshotFormatters = {
         delete data.indices;
       } else {
         $.append($("graphics-failures-tbody"),
           [$.new("tr", [$.new("th", "LogFailure", "column"),
                         $.new("td", data.failures.map(function(val) {
                           return $.new("p", val);
                        }))])]);
       }
+      delete data.failures;
     } else {
       $("graphics-failures-tbody").style.display = "none";
     }
 
     // Add a new row to the table, and take the key (or keys) out of data.
     //
     // @where        Table section to add to.
     // @key          Data key to use.