1879534289a4034a18002756d80cbf99f73d18da: Bug 1511138 - Fix / update tests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:02:33 +0100 - rev 449662
Bug 1511138 - Fix / update tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13550
7159c6b7e745c9fff5012d08bfb12240dd96202c: Bug 1511138 - Never return styles for disconnected elements. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:01:48 +0100 - rev 449661
Bug 1511138 - Never return styles for disconnected elements. r=smaug https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle says: > If elt is connected, part of the flat tree, and its shadow-including root... WebKit and Blink already do this, and we do it already except for cross-document situations, where we can end up with a PresShell even if GetPresShellForContent returns null. The style system should be able to rely on ShadowRoots having a non-null shadow host. Differential Revision: https://phabricator.services.mozilla.com/D13472
a6ae557a428bb1a50478db2fa6a868fb91372856: backout 5d2f9b45ad97 and 54649cf34d98 (bug 1337655), to reenable -moz prefixed CSS gradient syntax on Nightly.
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 07 Dec 2018 13:43:59 -0500 - rev 449660
backout 5d2f9b45ad97 and 54649cf34d98 (bug 1337655), to reenable -moz prefixed CSS gradient syntax on Nightly. (Backing out due to webcompat fallout.)
5fcc6bd202c45914bdbbfcf9a8e3f3dde23c2870: Backed out 5 changesets (bug 1511138) for causing eslint failure on SelectChild.jsm CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Fri, 07 Dec 2018 20:55:24 +0200 - rev 449659
Backed out 5 changesets (bug 1511138) for causing eslint failure on SelectChild.jsm CLOSED TREE Backed out changeset daee82295b3c (bug 1511138) Backed out changeset d23c9c3e1566 (bug 1511138) Backed out changeset a99600391704 (bug 1511138) Backed out changeset 4ef293b90887 (bug 1511138) Backed out changeset 4df286b234b3 (bug 1511138)
daee82295b3c81d57991a7db1b6851dc7bc8d963: Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Dec 2018 17:22:45 -0500 - rev 449658
Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=jaws,mconley I missed the failure in browser_selectpopup_colors.js since it doesn't run on Linux. Fix the getComputedStyle usage in that code by using getDefaultComputedStyle, which is what it really wants. Also, do a bit of cleanup while at it: uaBackgroundColor was unused, and uaColor was wrong (we don't override the ua color of the <option> element, it just inherits, so it's the same as the <select> color, and that's what we were comparing it against anyway). Differential Revision: https://phabricator.services.mozilla.com/D13956
d23c9c3e1566f64b0257d97597daaae3c3ed0897: Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Dec 2018 21:06:44 -0500 - rev 449657
Bug 1511138 - Improve performance of LightweightThemeConsumer when setting properties, and also avoid _sanitizeCSSColor from getting fooled. r=jaws This probably deserves a comment as of why it belongs to this bug. This patch series caused a single, reproducible timeout on browser_ext_themes_toolbars.js, where the transitionend event it awaits for stops triggering. I got fascinated by it and I decided to poke around it in rr instead of just removing the await line, and here's what's going on. In the previous implementation of _sanitizeCSSColor, we were not flushing style because of the optimization bug 1363805 introduced (which wasn't supposed to deal with out-of-document elements, but it accidentally did so). In any case, the fact that we were not flushing style in _sanitizeCSSColor caused us to flush style sometime later when the lwtheme attribute was already set up, and thus the selector in here matched: https://searchfox.org/mozilla-central/rev/cfaa5a1d48d6bc6552199e73004ecb05d0a9c921/browser/themes/shared/browser.inc.css#40 And thus caused the transition rule to apply at a time where the background-color change happened. Now we were flushing on getComputedStyle on every call, and in the most inefficient way possible (changing a custom property on the root before each property change, which causes us to restyle the whole document to propagate it down to all descendants). Furthermore, we were flushing style at a time where the lwtheme attribute change had not yet happened, and thus when the background-color changed, there was no transition rule applicable, and the transition didn't fire. This patch changes LightweightThemeConsumer to avoid restyling the whole document over and over. Also, while at it I realized that you could fool the sanitizer with !important in an experiment stylesheet or with other !important rule in the page really. It's not clear why you'd do that, but it may be worth to just making that function completely sound, so I did that and added a test for it. Differential Revision: https://phabricator.services.mozilla.com/D13716
a99600391704f8752e6f05e312fe8e8cd588715a: Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 12:40:25 +0100 - rev 449656
Bug 1511138 - Fix LightweightThemeConsumer's use of getComputedStyle. r=jaws,mconley See D13472 for spec quotes and such. Other browsers don't allow getting computed styles in disconnected subtrees and we agreed to follow suit (it does make sense because when you're not on the flat tree it's not defined what you're supposed to inherit from, specially in presence of Shadow DOM). Also, it allows the style system to rely on the DOM being in a sane state. Differential Revision: https://phabricator.services.mozilla.com/D13551
4ef293b908879b56b27c1f473127db680c099a60: Bug 1511138 - Fix / update tests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:02:33 +0100 - rev 449655
Bug 1511138 - Fix / update tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13550
4df286b234b3daf6c315ae2f3f58f857664f88c7: Bug 1511138 - Never return styles for disconnected elements. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:01:48 +0100 - rev 449654
Bug 1511138 - Never return styles for disconnected elements. r=smaug https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle says: > If elt is connected, part of the flat tree, and its shadow-including root... WebKit and Blink already do this, and we do it already except for cross-document situations, where we can end up with a PresShell even if GetPresShellForContent returns null. The style system should be able to rely on ShadowRoots having a non-null shadow host. Differential Revision: https://phabricator.services.mozilla.com/D13472
5e6e283f0e0080fc9d2be472b51d738e8d790ed4: Bug 1501587 - land NSS NSS_3_41_RTM UPGRADE_NSS_RELEASE, r=me
J.C. Jones <jc@mozilla.com> - Fri, 07 Dec 2018 17:01:03 +0000 - rev 449653
Bug 1501587 - land NSS NSS_3_41_RTM UPGRADE_NSS_RELEASE, r=me
efcada818361f5d8cc3ab78fb6039147e3da45ba: Bug 1507943 - Fix ReadableStream constructor handling of "pull" and "cancel" methods. r=arai
Jason Orendorff <jorendorff@mozilla.com> - Sun, 09 Dec 2018 17:57:09 +0000 - rev 449652
Bug 1507943 - Fix ReadableStream constructor handling of "pull" and "cancel" methods. r=arai Differential Revision: https://phabricator.services.mozilla.com/D13747
10e651a2adff43b61e560dd13707598cc08b1bc9: Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester,jimb
Jason Orendorff <jorendorff@mozilla.com> - Sun, 09 Dec 2018 15:48:33 +0000 - rev 449651
Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester,jimb This is an egregious hack. The web-platform-tests were not meant to run in the shell. The eight tests that are included are the ones that we pass with flying colors. In most of the others, we still have a failure or two. Differential Revision: https://phabricator.services.mozilla.com/D11533
88d304c633b6091a21fc64290256ef3fb51b7421: Bug 1423215 - Upload an uncompressed runnable-jobs.json artifact in addition to the gz version r=dustin
Wes Kocher <wkocher@mozilla.com> - Sun, 09 Dec 2018 05:07:48 +0000 - rev 449650
Bug 1423215 - Upload an uncompressed runnable-jobs.json artifact in addition to the gz version r=dustin Uploading both versions will hopefully make this easier to uplift. Once old pushes and artifacts expire, we can stop uploading the gzipped version. Differential Revision: https://phabricator.services.mozilla.com/D13601
3859ee4382cf89c5ab354ce4e495fd19af9ffc58: Bug 1511655 - Re-enable browser_UrlbarInput_tooltip.js on Windows. r=dao
Johann Hofmann <jhofmann@mozilla.com> - Sat, 08 Dec 2018 20:50:12 +0000 - rev 449649
Bug 1511655 - Re-enable browser_UrlbarInput_tooltip.js on Windows. r=dao Differential Revision: https://phabricator.services.mozilla.com/D14016
1f9b987dc95749f0b743e6e82bf85ee8f30eb179: Bug 1510275 - Make sure that we only ever dispatch a single STATE_COOKIES_LOADED notification per top-level document r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 08 Dec 2018 20:19:16 +0000 - rev 449648
Bug 1510275 - Make sure that we only ever dispatch a single STATE_COOKIES_LOADED notification per top-level document r=baku Differential Revision: https://phabricator.services.mozilla.com/D13849
0cfce8efa53e28de8fb2095e279462ec7f5393a8: Bug 1483354 - use promiseDocumentFlushed to execute tabstrip scrolling after creating a background tab, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Sat, 08 Dec 2018 16:27:12 +0000 - rev 449647
Bug 1483354 - use promiseDocumentFlushed to execute tabstrip scrolling after creating a background tab, r=dao Depends on D13675 Differential Revision: https://phabricator.services.mozilla.com/D13676
4fb8cba13911f25d76e404d6a90fba2e15aab4ea: Bug 1483354 - avoid flushing layout for new background tabs when the tabstrip isn't overflowing, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 05 Dec 2018 21:31:45 +0000 - rev 449646
Bug 1483354 - avoid flushing layout for new background tabs when the tabstrip isn't overflowing, r=dao Differential Revision: https://phabricator.services.mozilla.com/D13675
ce7554d953fdfcd815afd66ea91d4da6e28077c6: Bug 1512179 - Fix a nullptr deref crash in ContentPermissionRequestBase::GetPrincipal() r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 07 Dec 2018 18:02:56 +0000 - rev 449645
Bug 1512179 - Fix a nullptr deref crash in ContentPermissionRequestBase::GetPrincipal() r=baku Differential Revision: https://phabricator.services.mozilla.com/D13852
3d100f5e604d23d64866061d6e7d5db244a4a3c6: Bug 1510657 - Ensure that we don't attempt to access a channel's window in the parent process inside AntiTrackingCommon::NotifyBlockingDecision() r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 08 Dec 2018 19:41:05 +0000 - rev 449644
Bug 1510657 - Ensure that we don't attempt to access a channel's window in the parent process inside AntiTrackingCommon::NotifyBlockingDecision() r=baku Some channels such as the dummy channel created inside CookieServiceParent::RecvSetCookieString() do not have an nsIParentChannel interface, but we must be careful to not run the content process code path for them. Differential Revision: https://phabricator.services.mozilla.com/D13519
09493e80dbe7c1486eb3c93960cc81f73c8c5356: Bug 1512410 part 2 - Don't create a TypeNewScript for cross-realm constructors, add more asserts. r=luke
Jan de Mooij <jdemooij@mozilla.com> - Sat, 08 Dec 2018 18:10:29 +0000 - rev 449643
Bug 1512410 part 2 - Don't create a TypeNewScript for cross-realm constructors, add more asserts. r=luke Depends on D13903 Differential Revision: https://phabricator.services.mozilla.com/D13904
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip