980a5c4e312ae995737628f5631f71b0c0b8a3aa: Bug 1329147 - Optimize rendering of RequestListItem r=Honza
Jarda Snajdr <jsnajdr@gmail.com> - Thu, 05 Jan 2017 11:25:41 +0100 - rev 328479
Bug 1329147 - Optimize rendering of RequestListItem r=Honza MozReview-Commit-ID: 8SZbK3yCOBR
d5411799a28f247463e45744ab00668c75e57620: Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:36:43 +0800 - rev 328478
Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron circle() allows the user to define an empty flow area, so IsEmpty() needs to be overridden. The flow area defined by a shape needs to be clipped to the margin-box per https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior In the reftests, both clip-path and shape-outside uses the same value so that it's easier to debug visually. Add LogicalPoint::LineRelative() because we need to convert a point's I() to the line-axis in nsFloatManager. LineRelative() differs from I() in all 'rtl' direction per https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical MozReview-Commit-ID: FxQaFPrEQ73
ff9c71e1dbc8c11fd5b6bd255e4a947142423c69: Bug 1311244 Part 6 - Add ShapeInfo and move <shape-box> impl to BoxShapeInfo. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:36:30 +0800 - rev 328477
Bug 1311244 Part 6 - Add ShapeInfo and move <shape-box> impl to BoxShapeInfo. r=dbaron Create ShapeInfo as a base class for implementing all the shapes. In this design, we only need to create the correct subclass in FloatInfo's constructor whenever shape-outside is used rather than manually branching on StyleShapeSourceType and StyleBasicShape in all the methods like LineRight(), LineLeft(), etc. The concrete subclass of ShapeInfo could focus on implementing how its shape influence the flow area by overriding the needed methods in ShapeInfo. Move ComputeEllipseLineInterceptDiff() and XInterceptAtY() under the scope nsFloatManager so that they could be used by BoxShapeInfo and all the other ShpapeInfo subclasses yet to come. MozReview-Commit-ID: ETVc5FdGNha
96988ec5b81cdf2298ffcdcb407b4826e86a43ea: Bug 1311244 Part 5 - Convert FloatInfo's copy constructor into a move constructor. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:36:19 +0800 - rev 328476
Bug 1311244 Part 5 - Convert FloatInfo's copy constructor into a move constructor. r=dbaron Use move constructor for two reasons. 1) The copy constructor is needed only when appending FloatInfo to mFloats, so using move constructor will likely be more efficient if some of the member variables support move constructor. 2) Part 6 will added a UniquePtr member to FloatInfo, so using move constructor becomes necessary. Also change the return value of AddFloat() to void to simplify the code, since all the other callers do not check the return value, and BlockReflowInput::FloatAndPlaceFloat() only asserts in debug mode. I assume it's safe to omit the OOM check. MozReview-Commit-ID: GVbbsdBjr7b
9d257713833a2f627113c5a0224b295f471704d3: Bug 1311244 Part 4 - Extract the computation of circle radius as ComputeCircleRadius(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:36:05 +0800 - rev 328475
Bug 1311244 Part 4 - Extract the computation of circle radius as ComputeCircleRadius(). r=dbaron MozReview-Commit-ID: LJNvNOoc7FI
2c33905ccb04ce79efcebc40494cb3cf44b4ad08: Bug 1311244 Part 3 - Extract the computation of center as ComputeCircleOrEllipseCenter(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:35:53 +0800 - rev 328474
Bug 1311244 Part 3 - Extract the computation of center as ComputeCircleOrEllipseCenter(). r=dbaron MozReview-Commit-ID: A6OTJ9PD43c
20148e33d523e6d1df786f6c1c5e7d2703e7dc84: Bug 1311244 Part 2 - Create ShapeUtils, and move EnumerationToLength into it. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:35:29 +0800 - rev 328473
Bug 1311244 Part 2 - Create ShapeUtils, and move EnumerationToLength into it. r=dbaron More functions in nsCSSClipPathInstance will be refactored and moved into ShapeUtils in subsequent patches. MozReview-Commit-ID: LmJUevY8YGr
f36cd1532fdb435c13723cf4804894d821c5fa61: Bug 1311244 Part 1 - Use nsPoint type for center in nsCSSClipPathInstance. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:35:00 +0800 - rev 328472
Bug 1311244 Part 1 - Use nsPoint type for center in nsCSSClipPathInstance. r=dbaron |center| should be of nsPoint type since all the arguments of ComputeObjectAnchorPoint() uses nsPoint and nsSize. We should only convert center to Point (which is an an UnknownUnits type) for APIs requiring Point type. MozReview-Commit-ID: EDrQGPUZp6m
2ee4ea83a6b4e30e4064975ee56ff32ca1aac9ef: Bug 1311244 Part 0 - Preemptively fix unified build bustage in nsLayoutUtils. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 06 Jan 2017 16:34:33 +0800 - rev 328471
Bug 1311244 Part 0 - Preemptively fix unified build bustage in nsLayoutUtils. r=dbaron The is a preemptively fix for unified bustage after Part 2 adds a new file under layout/base/. The error was: In static member function 'static bool nsLayoutUtils::SupportsServoStyleBackend(nsIDocument*)': invalid static_cast from type 'nsIDocument*' to type 'nsDocument*' MozReview-Commit-ID: A8xTSPgh8Ls
c2f372cf7314844b996a1c001af4a763c7cccabb: Bug 1328828 - Implement Properties View r=Honza,jsnajdr
Ricky Chien <rchien@mozilla.com> - Thu, 05 Jan 2017 15:14:45 +0800 - rev 328470
Bug 1328828 - Implement Properties View r=Honza,jsnajdr MozReview-Commit-ID: EuFGC12V6BU
d192a99be4b436f2dc839435319f7630d5d8f4b0: No bug, Automated HPKP preload list update from host bld-linux64-spot-076 - a=hpkp-update
ffxbld - Sun, 08 Jan 2017 06:54:07 -0800 - rev 328469
No bug, Automated HPKP preload list update from host bld-linux64-spot-076 - a=hpkp-update
07611cb7a7e1c2bd33e844b4ce1d3075ec09da39: No bug, Automated HSTS preload list update from host bld-linux64-spot-076 - a=hsts-update
ffxbld - Sun, 08 Jan 2017 06:54:04 -0800 - rev 328468
No bug, Automated HSTS preload list update from host bld-linux64-spot-076 - a=hsts-update
4ece183563a44eab8f410818aa2c7984992dbb8d: Merge inbound to m-c. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Sat, 07 Jan 2017 22:14:35 -0500 - rev 328467
Merge inbound to m-c. a=merge
ef46d5e347e2d4147ff7bbae51a07b374d022638: Bug 1322553 - part 3 - add profiler start/end markers for sync IPC; r=mstange
Nathan Froyd <froydnj@mozilla.com> - Sat, 07 Jan 2017 15:56:49 -0500 - rev 328466
Bug 1322553 - part 3 - add profiler start/end markers for sync IPC; r=mstange This is gnarly IPDL code, but the generated code is probably easier to review. Before when sending a sync message, we had: bool sendok__ = (GetIPCChannel())->Send(msg__, (&(reply__))); if ((!(sendok__))) { return false; } Now, we have: bool sendok__; { GeckoProfilerTracingRAII syncIPCTracer( "IPC", "PJavaScript::Msg_PreventExtensions"); sendok__ = (GetIPCChannel())->Send(msg__, (&(reply__))); } if ((!(sendok__))) { return false; }
2aa4b0ffc9d99dddec79cafce0515f0ed01bc976: Bug 1322553 - part 2 - use the new constructor of GeckoProfilerTracingRAII; r=mstange
Nathan Froyd <froydnj@mozilla.com> - Sat, 07 Jan 2017 15:56:49 -0500 - rev 328465
Bug 1322553 - part 2 - use the new constructor of GeckoProfilerTracingRAII; r=mstange This patch is not strictly relevant to the current bug, but doing the work here nicely illustrates how the constructor we added in part 1 can be used in existing parts of the codebase.
30e3a56c6ed6b695d22dd1c6b1c19b379300bfa2: Bug 1322553 - part 1 - add a non-backtrace-taking constructor for GeckoProfilerTracingRAII; r=mstange
Nathan Froyd <froydnj@mozilla.com> - Sat, 07 Jan 2017 15:56:49 -0500 - rev 328464
Bug 1322553 - part 1 - add a non-backtrace-taking constructor for GeckoProfilerTracingRAII; r=mstange Sometimes there's no backtrace available, but you still want to denote an interesting event.
c557bb902365968f8423338d6c7ab805b2a9bf4a: Bug 1201335 - Display notification when a new device is added to Sync account. r=markh
Edouard Oger <eoger@fastmail.com> - Wed, 04 Jan 2017 19:21:36 -0500 - rev 328463
Bug 1201335 - Display notification when a new device is added to Sync account. r=markh MozReview-Commit-ID: D03prgIdL1M
72e93073be64937b7eee2732a4cbf527e399c2ae: Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8
Jared Wein <jwein@mozilla.com> - Fri, 06 Jan 2017 12:09:28 -0500 - rev 328462
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8 MozReview-Commit-ID: 2MhpvzUDgtK
1a0ac57dd3e375329614b504016be5af785b97fa: Bug 1328995 - Remove unnecessary Promise.resolve() wrapper on return from async function. r=kmag
Jared Wein <jwein@mozilla.com> - Thu, 05 Jan 2017 15:55:30 -0500 - rev 328461
Bug 1328995 - Remove unnecessary Promise.resolve() wrapper on return from async function. r=kmag MozReview-Commit-ID: Jp40DyphLDj
77eebb6c80cd5249b9a43bbcdefdaaa9d9845d1e: Merge inbound to m-c. a=merge
Ryan VanderMeulen <ryanvm@gmail.com> - Sat, 07 Jan 2017 15:32:04 -0500 - rev 328460
Merge inbound to m-c. a=merge
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip